From nobody Sat May 10 08:39:39 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1612776052; cv=none; d=zohomail.com; s=zohoarc; b=LRB+5+Lry6cATd+/ttKr34+hLh5hjohZJtTfJCS4U76hQQC/TJtsaVARE0YgyDP4KS2sXGxMLOg0sDh03ss3BNm0eH9CH+Yv6EpTypgd1pGVV3EyNaKWjBFALTcac+4Hkhq5w07Vo3O34rXgix831vTx1LaM2aBL4t3UnVmwiCA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612776052; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Subject:To; bh=B0IIOt3cj9+Gh6aHiITYj112foxYpEHsZahL1VsljjM=; b=BaQgiP6HoaR1WQI6ymXMHM9ClWHJauTKQfVymvKqxQ5XszLEcCtsaXfg6ctyYzhb5QfIvZ/6Zcgi0uG/Ax8sgRtygyi0hRHLDmZwiYThFWZKHC3IOFYSexK79HNQnttklQsS+15PbtwKbnLCJqZX7t5t6eBHnYXQ8C88Ps3SYmc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1612776052896729.0086350471045; Mon, 8 Feb 2021 01:20:52 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231235AbhBHJUI (ORCPT ); Mon, 8 Feb 2021 04:20:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231301AbhBHJAz (ORCPT ); Mon, 8 Feb 2021 04:00:55 -0500 Received: from forward101j.mail.yandex.net (forward101j.mail.yandex.net [IPv6:2a02:6b8:0:801:2::101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B974C0617A9; Mon, 8 Feb 2021 01:00:09 -0800 (PST) Received: from iva1-6891ef6bb416.qloud-c.yandex.net (iva1-6891ef6bb416.qloud-c.yandex.net [IPv6:2a02:6b8:c0c:929a:0:640:6891:ef6b]) by forward101j.mail.yandex.net (Yandex) with ESMTP id 1D8131BE159F; Mon, 8 Feb 2021 12:00:08 +0300 (MSK) Received: from iva5-057a0d1fbbd8.qloud-c.yandex.net (iva5-057a0d1fbbd8.qloud-c.yandex.net [2a02:6b8:c0c:7f1c:0:640:57a:d1f]) by iva1-6891ef6bb416.qloud-c.yandex.net (mxback/Yandex) with ESMTP id PyeKurnvJn-07IqkU4M; Mon, 08 Feb 2021 12:00:08 +0300 Received: by iva5-057a0d1fbbd8.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id N9nOuejTfy-07Jm5NWj; Mon, 08 Feb 2021 12:00:07 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=maquefel.me; s=mail; t=1612774808; bh=B0IIOt3cj9+Gh6aHiITYj112foxYpEHsZahL1VsljjM=; h=In-Reply-To:References:Date:Subject:To:From:Message-Id:Cc; b=Tj/JrZckxfM9Gpijf4UmNkR5Q032U29PDiJvMU9GlyYu9GYH5HDbe3EdrhO5QqE+c 9Q682bY4539OOXXTre+dhU9YiM3Tp9L1g4lgDL08IPUfQV/JBTz3LruAPcJ/B3rD4u YfOa3hc2ZA24bKyXxZZ1r/aOcZvkfgRu/owWQu6k= Authentication-Results: iva1-6891ef6bb416.qloud-c.yandex.net; dkim=pass header.i=@maquefel.me From: Nikita Shubin Cc: Andy Shevchenko , Nikita Shubin , Linus Walleij , Alexander Sverdlin , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 7/7] gpio: ep93xx: refactor base IRQ number Date: Mon, 8 Feb 2021 11:59:54 +0300 Message-Id: <20210208085954.30050-8-nikita.shubin@maquefel.me> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210208085954.30050-1-nikita.shubin@maquefel.me> References: <20210208085954.30050-1-nikita.shubin@maquefel.me> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" - use predefined constants instead of plain numbers - use provided bank IRQ number instead of defined constant for port F Reviewed-by: Linus Walleij Reviewed-by: Alexander Sverdlin Signed-off-by: Nikita Shubin --- drivers/gpio/gpio-ep93xx.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c index e75f7a9e40a0..9cc2c2b4309f 100644 --- a/drivers/gpio/gpio-ep93xx.c +++ b/drivers/gpio/gpio-ep93xx.c @@ -31,6 +31,8 @@ /* Maximum value for irq capable line identifiers */ #define EP93XX_GPIO_LINE_MAX_IRQ 23 =20 +#define EP93XX_GPIO_A_IRQ_BASE 64 +#define EP93XX_GPIO_B_IRQ_BASE 72 /* * Static mapping of GPIO bank F IRQS: * F0..F7 (16..24) to irq 80..87. @@ -301,14 +303,14 @@ struct ep93xx_gpio_bank { =20 static struct ep93xx_gpio_bank ep93xx_gpio_banks[] =3D { /* Bank A has 8 IRQs */ - EP93XX_GPIO_BANK("A", 0x00, 0x10, 0x90, 0, true, false, 64), + EP93XX_GPIO_BANK("A", 0x00, 0x10, 0x90, 0, true, false, EP93XX_GPIO_A_IRQ= _BASE), /* Bank B has 8 IRQs */ - EP93XX_GPIO_BANK("B", 0x04, 0x14, 0xac, 8, true, false, 72), + EP93XX_GPIO_BANK("B", 0x04, 0x14, 0xac, 8, true, false, EP93XX_GPIO_B_IRQ= _BASE), EP93XX_GPIO_BANK("C", 0x08, 0x18, 0x00, 40, false, false, 0), EP93XX_GPIO_BANK("D", 0x0c, 0x1c, 0x00, 24, false, false, 0), EP93XX_GPIO_BANK("E", 0x20, 0x24, 0x00, 32, false, false, 0), /* Bank F has 8 IRQs */ - EP93XX_GPIO_BANK("F", 0x30, 0x34, 0x4c, 16, false, true, 0), + EP93XX_GPIO_BANK("F", 0x30, 0x34, 0x4c, 16, false, true, EP93XX_GPIO_F_IR= Q_BASE), EP93XX_GPIO_BANK("G", 0x38, 0x3c, 0x00, 48, false, false, 0), EP93XX_GPIO_BANK("H", 0x40, 0x44, 0x00, 56, false, false, 0), }; @@ -407,7 +409,7 @@ static int ep93xx_gpio_add_bank(struct ep93xx_gpio_chip= *egc, /* Pick resources 1..8 for these IRQs */ for (i =3D 0; i < girq->num_parents; i++) { girq->parents[i] =3D platform_get_irq(pdev, i + 1); - gpio_irq =3D EP93XX_GPIO_F_IRQ_BASE + i; + gpio_irq =3D bank->irq_base + i; irq_set_chip_data(gpio_irq, &epg->gc[5]); irq_set_chip_and_handler(gpio_irq, &ep93xx_gpio_irq_chip, @@ -416,7 +418,7 @@ static int ep93xx_gpio_add_bank(struct ep93xx_gpio_chip= *egc, } girq->default_type =3D IRQ_TYPE_NONE; girq->handler =3D handle_level_irq; - girq->first =3D EP93XX_GPIO_F_IRQ_BASE; + girq->first =3D bank->irq_base; } =20 return devm_gpiochip_add_data(dev, gc, epg); --=20 2.26.2