From nobody Fri May 17 09:38:25 2024 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1613571749; cv=none; d=zohomail.com; s=zohoarc; b=FPgDm/qev7tcXHEWJBNawPypzf/YxhllFzVyBCMDzp37dO4FCli9g2ZmPwCqFsYfRaU4EavNsWK9/vrUtez3KGJ5TUHRlhON5XI/2Wa1ExK4Y89hPOZsM54uftzRUnvuDb56POCixwbm2O6jM+j4F8qqBMLmxYZbWoI/YH4fqbw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613571749; h=Cc:Date:From:List-Id:Message-ID:Subject:To; bh=tkR3nWvQ+KA65XhBWc3ZlKt+YgDPlZLa5MC3BGSdyyQ=; b=HW3awK1f729QzMRL/1X1AgIVRY1hLwMb083EMX+3xo0/wxiINv+XyIQHdlXVQ1tCrpBY4C3ON+Oot/xM5JxjsWze7d/UZfIxSokBbWkv+2Z+HitkDASE7JtRH3PaOWbr8f9QcFZ4wA8+Y5XPz0sQRcswkpK1hmBZu0d9rWfaUwM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1613571749072575.4807457744629; Wed, 17 Feb 2021 06:22:29 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233427AbhBQOVu (ORCPT ); Wed, 17 Feb 2021 09:21:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233314AbhBQOV1 (ORCPT ); Wed, 17 Feb 2021 09:21:27 -0500 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC592C061574 for ; Wed, 17 Feb 2021 06:20:47 -0800 (PST) Received: by mail-pg1-x535.google.com with SMTP id t11so8568021pgu.8 for ; Wed, 17 Feb 2021 06:20:47 -0800 (PST) Received: from rayare.domain.name ([106.51.141.71]) by smtp.googlemail.com with ESMTPSA id w196sm2704814pfd.23.2021.02.17.06.20.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Feb 2021 06:20:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=tkR3nWvQ+KA65XhBWc3ZlKt+YgDPlZLa5MC3BGSdyyQ=; b=jvUwXMP/BUoo0aubC202imi3Ptt9jD+nY4BVmsw1Juq/TtwA1c+qv+Q4/3kHKTSUid PHfvQ4Y4KaMSXs3FbbBeJA6ehOfOYo8EeW0/2oWhn4i2STe6GjnvGBH6y6MIJnBvGvi2 jrNqAeBeSKGkqjRBzkHHen8shwj1Z4J9eevXJEq09A5wzQ1bj6PAUnrbkI8pnbXeuTeq GxP12dbmuxxUWTtXUc9BGR2ohigN1UZVt98j+Ln0AsIj58lB5/DFtX5pl1OI7Dzc23hN 9l0vW9vpEWwqG8bcYONAFN/6pvKke8gfTVJ3haUOTrYhiTBgawbXOznN0VekO1yPMTCZ Zcvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=tkR3nWvQ+KA65XhBWc3ZlKt+YgDPlZLa5MC3BGSdyyQ=; b=t2yVZE8K7C2Km0nPXPO2Biy6P/T9GkkGTNlyfkNYbDLGjXaDhdJA1Tkzao+t/KzDfw JIu5vvsprTeaunzKKWQyQEk4QcLY4CGsdGCNKxnvKQYAReE1vrTZCpreyNKmVGF4PzOS in3ZT4w6A/kf8k7vFOLmVcnI2ove9Ia8035AF9S8k2oEsmqCSMRNfdo72MU2wIgGb4bw CbscsQuFG+4HixJk7xhOHAZf9uprLcwDvmiHdpD/fP/qpZkQIJbwOKMSsmnoKsNny/z3 OLasQrFjpefw7Zs3Qv9HCxLsaUXBwS2OJh/vpk7Z4hdpkKHb7uiM7RWDiBG5Za3WmYFY NIGQ== X-Gm-Message-State: AOAM530SinuSRjQGynbNLcwcWLrjhnPvIjm23oGglpsCnXRkI/5rcmvv e/DYsSetwXa1j7ztAa7NGD4= X-Google-Smtp-Source: ABdhPJwCqI/M4I79QFL+Lt06dPO+AT9Bsbu9mQ8wmy9KrLsNWG2u5Zz4kfkQCYP0Xu4xUJgf0sdq1A== X-Received: by 2002:a63:9314:: with SMTP id b20mr23841434pge.411.1613571647606; Wed, 17 Feb 2021 06:20:47 -0800 (PST) From: chakravarthikulkarni Cc: chakravarthikulkarni2021@gmail.com, Ian Abbott , H Hartley Sweeten , Greg Kroah-Hartman , Ethan Edwards , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] drivers: staging: comedi: Fixed side effects from macro definition. Date: Wed, 17 Feb 2021 19:50:05 +0530 Message-Id: <20210217142008.29699-1-chakravarthikulkarni2021@gmail.com> X-Mailer: git-send-email 2.17.1 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Warning found by checkpatch.pl script. Signed-off-by: chakravarthikulkarni --- drivers/staging/comedi/comedi.h | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comed= i.h index b5d00a006dbb..b2af6a88d389 100644 --- a/drivers/staging/comedi/comedi.h +++ b/drivers/staging/comedi/comedi.h @@ -1103,9 +1103,12 @@ enum ni_common_signal_names { =20 /* *** END GLOBALLY-NAMED NI TERMINALS/SIGNALS *** */ =20 -#define NI_USUAL_PFI_SELECT(x) (((x) < 10) ? (0x1 + (x)) : (0xb + (x))) -#define NI_USUAL_RTSI_SELECT(x) (((x) < 7) ? (0xb + (x)) : 0x1b) - +#define NI_USUAL_PFI_SELECT(x) \ + ({ typeof(x) _x =3D x; \ + (((_x) < 10) ? (0x1 + (_x)) : (0xb + (_x))); }) +#define NI_USUAL_RTSI_SELECT(x) \ + ({ typeof(x) _x =3D x; \ + (((_x) < 7) ? (0xb + (_x)) : 0x1b); }) /* * mode bits for NI general-purpose counters, set with * INSN_CONFIG_SET_COUNTER_MODE --=20 2.17.1