From nobody Fri May 17 09:04:57 2024 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1613938520; cv=none; d=zohomail.com; s=zohoarc; b=Jz+FfWmD7MvY7lFbfeO1PbdxkxlCL77q8OrlG9jjxo6aatKEZmd6ilLpxbQEUMUK59sUzSqlx/36TbhYR2r6E2PYTTWPj4IGB7IaJgd9fub9uLYuABUHT1igP2mxPxqQvk0KRE1AoF4QCDfEZinJypjskUEIjJisH9PHevP6Hm8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613938520; h=Cc:Date:From:List-Id:Message-ID:Subject:To; bh=/MZ9AB1W/dbMxNAhi0KVsZwY+q1BgLJr0bsgnEfCTfU=; b=YE/9YyMy7QMqYFfJUP0E89CflyTNilab1spF5C1AbO6cVKZtOv6cVAZWO3pzhbEAFca6mMj3XXjUGfoH8yxkDHIrO0spAmIUrJZMNUf/RCZ9x3XN59gJ33fwSLyDqALBeHoxuwNA3sH9ZzZD+3YlNBzil4tRpU0CeB0aYvwxll8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1613938519605559.4913881080644; Sun, 21 Feb 2021 12:15:19 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230450AbhBUUOn (ORCPT ); Sun, 21 Feb 2021 15:14:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230253AbhBUUOb (ORCPT ); Sun, 21 Feb 2021 15:14:31 -0500 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E93F5C061574 for ; Sun, 21 Feb 2021 12:13:50 -0800 (PST) Received: by mail-pf1-x42b.google.com with SMTP id x129so547648pfx.7 for ; Sun, 21 Feb 2021 12:13:50 -0800 (PST) Received: from rayare.domain.name ([106.51.141.71]) by smtp.googlemail.com with ESMTPSA id d4sm12721532pfq.101.2021.02.21.12.13.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Feb 2021 12:13:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=/MZ9AB1W/dbMxNAhi0KVsZwY+q1BgLJr0bsgnEfCTfU=; b=DVDQIQXK+lI9FpI6XKZUP6PmT5GpG9Z156YuDP8RxuG1v1wWrZVtpbILjt3BqmHsZ3 FVqyLQHPHoHQR2YhRGwp/AVMEbhK9fh0UWR7LptW4rCAsyuajOUuA1lCzLidHd7wuB5I B8V2INwsSsjBgq/EAb9+ckUhcvYepGTg9kCikInWdVlWwBR4qOzMbMQLPqZdm6/iRpuU kg3/y0JYEtK8FMWQIC7rRjPkWLGdgF5/LPjfMAtpbD80CzC7dEsyYG6SUuaBwQyXZj5A MAhPCsHxDyFXyj5WbhpnJ4fJRVOtKjhF42BrsgsqrW1GK6oZuctlKQXEyO8xYnHt0Xgn LFqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=/MZ9AB1W/dbMxNAhi0KVsZwY+q1BgLJr0bsgnEfCTfU=; b=TyLv45yMS6NtngTvh2elflLy2cUUzIVTaySmImTnfvk36qKq8z/v8Sc49c5Us7eB4S X/bZOiwqvKIP29lF6wX3oNlE/5ULAQm6GlJcqv4nrRJhU49iBsnPdfIzy2WP4IPWW3K9 TFVCqqgN/ObG6LSejzypzqLe3fErkLZ0SfzcfthIWFEi2bc9ePe9dRET9kTrGa2Hnv8y 2In6OmDx0LGIZ6rg4vzAiQthkSDj1DavCDX1nXQfWSou5uC15MxlfR0y51eG4tBLF9Xi uV+7Zci+dEmeyzkW9+P7B0iCn/KYzsB2OpX++fME4sFRPgXmyvTM9eJirh3f5+rZBFtK n0KA== X-Gm-Message-State: AOAM532vviSUYsB3zq9ReFTgPp2xds7hWELOGN0HorVdX6jQmqy3lA+A cwlygsN/3qRJId9VfOC1mBY= X-Google-Smtp-Source: ABdhPJwtgU7vD26cxEIVe/yhegDad+EYPOJnY1UOXSx4VulhokUGnczz28OKEbIkI6UQrEcSL3ljfw== X-Received: by 2002:aa7:80c6:0:b029:1b6:92ae:a199 with SMTP id a6-20020aa780c60000b02901b692aea199mr11068478pfn.71.1613938430430; Sun, 21 Feb 2021 12:13:50 -0800 (PST) From: chakravarthikulkarni Cc: chakravarthikulkarni2021@gmail.com, Greg Kroah-Hartman , "Gustavo A. R. Silva" , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: ks7010: Replace macros with do while loop. Date: Mon, 22 Feb 2021 01:43:24 +0530 Message-Id: <20210221201327.12714-1-chakravarthikulkarni2021@gmail.com> X-Mailer: git-send-email 2.17.1 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This commit fix errors found in checkpath.pl. Error message is: It is a good idea to keep complex macros in do while loop. Otherwise result may have side effect. Signed-off-by: chakravarthikulkarni --- drivers/staging/ks7010/ks_hostif.h | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks= _hostif.h index 39138191a556..955499054d10 100644 --- a/drivers/staging/ks7010/ks_hostif.h +++ b/drivers/staging/ks7010/ks_hostif.h @@ -498,20 +498,20 @@ struct hostif_mic_failure_request { #define TX_RATE_FIXED 5 =20 /* 11b rate */ -#define TX_RATE_1M (u8)(10 / 5) /* 11b 11g basic rate */ -#define TX_RATE_2M (u8)(20 / 5) /* 11b 11g basic rate */ -#define TX_RATE_5M (u8)(55 / 5) /* 11g basic rate */ -#define TX_RATE_11M (u8)(110 / 5) /* 11g basic rate */ +#define TX_RATE_1M do { (u8) (10 / 5) } while (0) /* 11b 11g basic rate */ +#define TX_RATE_2M do { (u8) (20 / 5) } while (0) /* 11b 11g basic rate */ +#define TX_RATE_5M do { (u8) (55 / 5) } while (0) /* 11g basic rate */ +#define TX_RATE_11M do { (u8) (110 / 5) } while (0) /* 11g basic rate */ =20 /* 11g rate */ -#define TX_RATE_6M (u8)(60 / 5) /* 11g basic rate */ -#define TX_RATE_12M (u8)(120 / 5) /* 11g basic rate */ -#define TX_RATE_24M (u8)(240 / 5) /* 11g basic rate */ -#define TX_RATE_9M (u8)(90 / 5) -#define TX_RATE_18M (u8)(180 / 5) -#define TX_RATE_36M (u8)(360 / 5) -#define TX_RATE_48M (u8)(480 / 5) -#define TX_RATE_54M (u8)(540 / 5) +#define TX_RATE_6M do { (u8) (60 / 5) } while (0) /* 11g basic rate */ +#define TX_RATE_12M do { (u8) (120 / 5) } while (0) /* 11g basic rate */ +#define TX_RATE_24M do { (u8) (240 / 5) } while (0) /* 11g basic rate */ +#define TX_RATE_9M do { (u8) (90 / 5) } while (0) +#define TX_RATE_18M do { (u8) (180 / 5) } while (0) +#define TX_RATE_36M do { (u8) (360 / 5) } while (0) +#define TX_RATE_48M do { (u8) (480 / 5) } while (0) +#define TX_RATE_54M do { (u8) (540 / 5) } while (0) =20 static inline bool is_11b_rate(u8 rate) { --=20 2.17.1