From nobody Mon May 6 14:00:08 2024 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1615909088; cv=none; d=zohomail.com; s=zohoarc; b=W0tPGkx6va6UcEKx7ulhvNcCYZtbQQbgYPTc3IVuymtETODRDauPhuc7Nz+H2px/zLnLaIInCrHOnd98hFy3QVM9oS5I8iqmeISURwjCzA8fEht4jkqbnK4Lhzt84GsaFjNWw7/Qwo63r4hgMO6Bpg8RacTsEWjwrf32zDiKMmQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615909088; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Subject:To; bh=BJeF+DFkWjXvC2+py6aYx1pM4wZgsYdRz94iG+JwIjQ=; b=FCWtGKxt/R3DpTGmc97GW5hwrJbenns+Ri/TGKMb18amllYlyk8i9cjONXe8vSlzbEzivDK4aW8vXwpgipETbHrbGgySF0tYgDaE3aNEwnzfAFrkLDGNdn5DeldvC/TwO9tyTC1w6BpehR3kZcZsaiMCwBBBymES9Zql0cDzJ6E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1615909088332572.304116185638; Tue, 16 Mar 2021 08:38:08 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234651AbhCPPhy (ORCPT ); Tue, 16 Mar 2021 11:37:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229862AbhCPPhX (ORCPT ); Tue, 16 Mar 2021 11:37:23 -0400 Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D47D2C06174A; Tue, 16 Mar 2021 08:37:20 -0700 (PDT) Received: by mail-qt1-x82d.google.com with SMTP id g24so11939568qts.6; Tue, 16 Mar 2021 08:37:20 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:1ee]) by smtp.gmail.com with ESMTPSA id k4sm15491144qke.13.2021.03.16.08.37.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Mar 2021 08:37:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BJeF+DFkWjXvC2+py6aYx1pM4wZgsYdRz94iG+JwIjQ=; b=GoQJBLW7obUr3v6qda9xFMLeM6y9AGbo4dCEQfj6BGRVxRpRHgk1FfBdowzYTmJ2Xy 2yfzTf8noY/ILScIbrwM2SiENNgJLjQDM1RN6c1Z7F+3KA2If4Twpf2OnqwIEVq5tu0A bZH6CDApzDd1PLtJq/8QqAVkg412e1hs1pK6ugbukBHCzJpAPQ6Z7Uyy+MdOxNJVl8lH In0L+Ion5C8hFvnPRSVJZIOOPdoHM0JsXkLoxaZNjFB2ligzdpragEHG5QS1GfzSsTOo TcHZRWRh/G4mGLlk+C7HUUov7uPPjYj+7UFiEJ/e32N4+T3ngM9aywaLdGe9pOCxhJEt hzzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BJeF+DFkWjXvC2+py6aYx1pM4wZgsYdRz94iG+JwIjQ=; b=sIlE+rYQ9A4tyLKT5HQ2QxVuh7nEMK+6aKx+pC4+7zy7mkql4+O9IKfwky6Yompmjy 6NeBo4ZwbDFoYCtiQw2GSg6kyLgOzlHgWXq/ycEcYy4H7NVImwRhETqohgAeS3Vf8g2g +wxcMvqzPAku/McjNsUYM7+/8pRIbVvNyDTAkP5btCcQDo/PBMN5+sqwjKw/0nq3b16u Oz6SkxYor5c++oqAREYJjChteVvK+2iF3QXu6d7M4riPq51w6GxGxRphfiTlpM5GJE2m JclEl3fzbJCofYjz+3UoffgAm61yt/XzC8Tq+UvsWz3zK+a5oaFUnhM7NnN7sSu1FZBf lY0Q== X-Gm-Message-State: AOAM532FgPCP7L1rTMSldHIWzCCX+lKjyI2Rx3oeMiPjuGjXMT7hKWEw 69Z2DXY1jR7JKPCpg18QWXg= X-Google-Smtp-Source: ABdhPJwuCUat0ipVpAbAZY+Gt6SG/1Qi6JcuoU/MbVmGoUKbejTPsR93MqLGiam1VCeIGV6iNh/e5w== X-Received: by 2002:a05:622a:34f:: with SMTP id r15mr237682qtw.107.1615909040068; Tue, 16 Mar 2021 08:37:20 -0700 (PDT) From: Dan Schatzberg Cc: Jens Axboe , Tejun Heo , Zefan Li , Johannes Weiner , Andrew Morton , Michal Hocko , Vladimir Davydov , Hugh Dickins , Shakeel Butt , Roman Gushchin , Muchun Song , Alex Shi , Alexander Duyck , Chris Down , Yafang Shao , Wei Yang , linux-block@vger.kernel.org (open list:BLOCK LAYER), linux-kernel@vger.kernel.org (open list), cgroups@vger.kernel.org (open list:CONTROL GROUP (CGROUP)), linux-mm@kvack.org (open list:MEMORY MANAGEMENT) Subject: [PATCH 1/3] loop: Use worker per cgroup instead of kworker Date: Tue, 16 Mar 2021 08:36:50 -0700 Message-Id: <20210316153655.500806-2-schatzberg.dan@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210316153655.500806-1-schatzberg.dan@gmail.com> References: <20210316153655.500806-1-schatzberg.dan@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Existing uses of loop device may have multiple cgroups reading/writing to the same device. Simply charging resources for I/O to the backing file could result in priority inversion where one cgroup gets synchronously blocked, holding up all other I/O to the loop device. In order to avoid this priority inversion, we use a single workqueue where each work item is a "struct loop_worker" which contains a queue of struct loop_cmds to issue. The loop device maintains a tree mapping blk css_id -> loop_worker. This allows each cgroup to independently make forward progress issuing I/O to the backing file. There is also a single queue for I/O associated with the rootcg which can be used in cases of extreme memory shortage where we cannot allocate a loop_worker. The locking for the tree and queues is fairly heavy handed - we acquire a per-loop-device spinlock any time either is accessed. The existing implementation serializes all I/O through a single thread anyways, so I don't believe this is any worse. Signed-off-by: Dan Schatzberg --- drivers/block/loop.c | 207 ++++++++++++++++++++++++++++++++++++------- drivers/block/loop.h | 12 ++- 2 files changed, 182 insertions(+), 37 deletions(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index a370cde3ddd4..5c080af73caa 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -70,7 +70,6 @@ #include #include #include -#include #include #include #include @@ -83,6 +82,8 @@ =20 #include =20 +#define LOOP_IDLE_WORKER_TIMEOUT (60 * HZ) + static DEFINE_IDR(loop_index_idr); static DEFINE_MUTEX(loop_ctl_mutex); =20 @@ -920,27 +921,83 @@ static void loop_config_discard(struct loop_device *l= o) q->limits.discard_alignment =3D 0; } =20 -static void loop_unprepare_queue(struct loop_device *lo) -{ - kthread_flush_worker(&lo->worker); - kthread_stop(lo->worker_task); -} +struct loop_worker { + struct rb_node rb_node; + struct work_struct work; + struct list_head cmd_list; + struct list_head idle_list; + struct loop_device *lo; + struct cgroup_subsys_state *css; + unsigned long last_ran_at; +}; =20 -static int loop_kthread_worker_fn(void *worker_ptr) -{ - current->flags |=3D PF_LOCAL_THROTTLE | PF_MEMALLOC_NOIO; - return kthread_worker_fn(worker_ptr); -} +static void loop_workfn(struct work_struct *work); +static void loop_rootcg_workfn(struct work_struct *work); +static void loop_free_idle_workers(struct timer_list *timer); =20 -static int loop_prepare_queue(struct loop_device *lo) +static void loop_queue_work(struct loop_device *lo, struct loop_cmd *cmd) { - kthread_init_worker(&lo->worker); - lo->worker_task =3D kthread_run(loop_kthread_worker_fn, - &lo->worker, "loop%d", lo->lo_number); - if (IS_ERR(lo->worker_task)) - return -ENOMEM; - set_user_nice(lo->worker_task, MIN_NICE); - return 0; + struct rb_node **node =3D &(lo->worker_tree.rb_node), *parent =3D NULL; + struct loop_worker *cur_worker, *worker =3D NULL; + struct work_struct *work; + struct list_head *cmd_list; + + spin_lock_irq(&lo->lo_work_lock); + + if (!cmd->css) + goto queue_work; + + node =3D &lo->worker_tree.rb_node; + + while (*node) { + parent =3D *node; + cur_worker =3D container_of(*node, struct loop_worker, rb_node); + if (cur_worker->css =3D=3D cmd->css) { + worker =3D cur_worker; + break; + } else if ((long)cur_worker->css < (long)cmd->css) { + node =3D &(*node)->rb_left; + } else { + node =3D &(*node)->rb_right; + } + } + if (worker) + goto queue_work; + + worker =3D kzalloc(sizeof(struct loop_worker), GFP_NOWAIT | __GFP_NOWARN); + /* + * In the event we cannot allocate a worker, just queue on the + * rootcg worker + */ + if (!worker) + goto queue_work; + + worker->css =3D cmd->css; + css_get(worker->css); + INIT_WORK(&worker->work, loop_workfn); + INIT_LIST_HEAD(&worker->cmd_list); + INIT_LIST_HEAD(&worker->idle_list); + worker->lo =3D lo; + rb_link_node(&worker->rb_node, parent, node); + rb_insert_color(&worker->rb_node, &lo->worker_tree); +queue_work: + if (worker) { + /* + * We need to remove from the idle list here while + * holding the lock so that the idle timer doesn't + * free the worker + */ + if (!list_empty(&worker->idle_list)) + list_del_init(&worker->idle_list); + work =3D &worker->work; + cmd_list =3D &worker->cmd_list; + } else { + work =3D &lo->rootcg_work; + cmd_list =3D &lo->rootcg_cmd_list; + } + list_add_tail(&cmd->list_entry, cmd_list); + queue_work(lo->workqueue, work); + spin_unlock_irq(&lo->lo_work_lock); } =20 static void loop_update_rotational(struct loop_device *lo) @@ -1126,12 +1183,27 @@ static int loop_configure(struct loop_device *lo, f= mode_t mode, !file->f_op->write_iter) lo->lo_flags |=3D LO_FLAGS_READ_ONLY; =20 - error =3D loop_prepare_queue(lo); - if (error) + error =3D -EFBIG; + size =3D get_loop_size(lo, file); + if ((loff_t)(sector_t)size !=3D size) goto out_unlock; + lo->workqueue =3D alloc_workqueue("loop%d", + WQ_UNBOUND | WQ_FREEZABLE | + WQ_MEM_RECLAIM, + lo->lo_number); + if (!lo->workqueue) { + error =3D -ENOMEM; + goto out_unlock; + } =20 set_disk_ro(lo->lo_disk, (lo->lo_flags & LO_FLAGS_READ_ONLY) !=3D 0); =20 + INIT_WORK(&lo->rootcg_work, loop_rootcg_workfn); + INIT_LIST_HEAD(&lo->rootcg_cmd_list); + INIT_LIST_HEAD(&lo->idle_worker_list); + lo->worker_tree =3D RB_ROOT; + timer_setup(&lo->timer, loop_free_idle_workers, + TIMER_DEFERRABLE); lo->use_dio =3D lo->lo_flags & LO_FLAGS_DIRECT_IO; lo->lo_device =3D bdev; lo->lo_backing_file =3D file; @@ -1199,6 +1271,7 @@ static int __loop_clr_fd(struct loop_device *lo, bool= release) int err =3D 0; bool partscan =3D false; int lo_number; + struct loop_worker *pos, *worker; =20 mutex_lock(&lo->lo_mutex); if (WARN_ON_ONCE(lo->lo_state !=3D Lo_rundown)) { @@ -1218,6 +1291,18 @@ static int __loop_clr_fd(struct loop_device *lo, boo= l release) /* freeze request queue during the transition */ blk_mq_freeze_queue(lo->lo_queue); =20 + destroy_workqueue(lo->workqueue); + spin_lock_irq(&lo->lo_work_lock); + list_for_each_entry_safe(worker, pos, &lo->idle_worker_list, + idle_list) { + list_del(&worker->idle_list); + rb_erase(&worker->rb_node, &lo->worker_tree); + css_put(worker->css); + kfree(worker); + } + spin_unlock_irq(&lo->lo_work_lock); + del_timer_sync(&lo->timer); + spin_lock_irq(&lo->lo_lock); lo->lo_backing_file =3D NULL; spin_unlock_irq(&lo->lo_lock); @@ -1254,7 +1339,6 @@ static int __loop_clr_fd(struct loop_device *lo, bool= release) =20 partscan =3D lo->lo_flags & LO_FLAGS_PARTSCAN && bdev; lo_number =3D lo->lo_number; - loop_unprepare_queue(lo); out_unlock: mutex_unlock(&lo->lo_mutex); if (partscan) { @@ -2025,7 +2109,7 @@ static blk_status_t loop_queue_rq(struct blk_mq_hw_ct= x *hctx, } else #endif cmd->css =3D NULL; - kthread_queue_work(&lo->worker, &cmd->work); + loop_queue_work(lo, cmd); =20 return BLK_STS_OK; } @@ -2055,26 +2139,82 @@ static void loop_handle_cmd(struct loop_cmd *cmd) } } =20 -static void loop_queue_work(struct kthread_work *work) +static void loop_set_timer(struct loop_device *lo) +{ + timer_reduce(&lo->timer, jiffies + LOOP_IDLE_WORKER_TIMEOUT); +} + +static void loop_process_work(struct loop_worker *worker, + struct list_head *cmd_list, struct loop_device *lo) { - struct loop_cmd *cmd =3D - container_of(work, struct loop_cmd, work); + int orig_flags =3D current->flags; + struct loop_cmd *cmd; =20 - loop_handle_cmd(cmd); + current->flags |=3D PF_LOCAL_THROTTLE | PF_MEMALLOC_NOIO; + spin_lock_irq(&lo->lo_work_lock); + while (!list_empty(cmd_list)) { + cmd =3D container_of( + cmd_list->next, struct loop_cmd, list_entry); + list_del(cmd_list->next); + spin_unlock_irq(&lo->lo_work_lock); + + loop_handle_cmd(cmd); + cond_resched(); + + spin_lock_irq(&lo->lo_work_lock); + } + + /* + * We only add to the idle list if there are no pending cmds + * *and* the worker will not run again which ensures that it + * is safe to free any worker on the idle list + */ + if (worker && !work_pending(&worker->work)) { + worker->last_ran_at =3D jiffies; + list_add_tail(&worker->idle_list, &lo->idle_worker_list); + loop_set_timer(lo); + } + spin_unlock_irq(&lo->lo_work_lock); + current->flags =3D orig_flags; } =20 -static int loop_init_request(struct blk_mq_tag_set *set, struct request *r= q, - unsigned int hctx_idx, unsigned int numa_node) +static void loop_workfn(struct work_struct *work) { - struct loop_cmd *cmd =3D blk_mq_rq_to_pdu(rq); + struct loop_worker *worker =3D + container_of(work, struct loop_worker, work); + loop_process_work(worker, &worker->cmd_list, worker->lo); +} =20 - kthread_init_work(&cmd->work, loop_queue_work); - return 0; +static void loop_rootcg_workfn(struct work_struct *work) +{ + struct loop_device *lo =3D + container_of(work, struct loop_device, rootcg_work); + loop_process_work(NULL, &lo->rootcg_cmd_list, lo); +} + +static void loop_free_idle_workers(struct timer_list *timer) +{ + struct loop_device *lo =3D container_of(timer, struct loop_device, timer); + struct loop_worker *pos, *worker; + + spin_lock_irq(&lo->lo_work_lock); + list_for_each_entry_safe(worker, pos, &lo->idle_worker_list, + idle_list) { + if (time_is_after_jiffies(worker->last_ran_at + + LOOP_IDLE_WORKER_TIMEOUT)) + break; + list_del(&worker->idle_list); + rb_erase(&worker->rb_node, &lo->worker_tree); + css_put(worker->css); + kfree(worker); + } + if (!list_empty(&lo->idle_worker_list)) + loop_set_timer(lo); + spin_unlock_irq(&lo->lo_work_lock); } =20 static const struct blk_mq_ops loop_mq_ops =3D { .queue_rq =3D loop_queue_rq, - .init_request =3D loop_init_request, .complete =3D lo_complete_rq, }; =20 @@ -2163,6 +2303,7 @@ static int loop_add(struct loop_device **l, int i) mutex_init(&lo->lo_mutex); lo->lo_number =3D i; spin_lock_init(&lo->lo_lock); + spin_lock_init(&lo->lo_work_lock); disk->major =3D LOOP_MAJOR; disk->first_minor =3D i << part_shift; disk->fops =3D &lo_fops; diff --git a/drivers/block/loop.h b/drivers/block/loop.h index a3c04f310672..9289c1cd6374 100644 --- a/drivers/block/loop.h +++ b/drivers/block/loop.h @@ -14,7 +14,6 @@ #include #include #include -#include #include =20 /* Possible states of device */ @@ -54,8 +53,13 @@ struct loop_device { =20 spinlock_t lo_lock; int lo_state; - struct kthread_worker worker; - struct task_struct *worker_task; + spinlock_t lo_work_lock; + struct workqueue_struct *workqueue; + struct work_struct rootcg_work; + struct list_head rootcg_cmd_list; + struct list_head idle_worker_list; + struct rb_root worker_tree; + struct timer_list timer; bool use_dio; bool sysfs_inited; =20 @@ -66,7 +70,7 @@ struct loop_device { }; =20 struct loop_cmd { - struct kthread_work work; + struct list_head list_entry; bool use_aio; /* use AIO interface to handle I/O */ atomic_t ref; /* only for aio */ long ret; --=20 2.30.2 From nobody Mon May 6 14:00:08 2024 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1615909088; cv=none; d=zohomail.com; s=zohoarc; b=JKe78zT4KQ8AiuI76q9V7yRmoRYwZTz4MS8aafbf9ppJazBZ49bxJmo+d2ykKyTENzrlBa2NapF4h5ak0kDzwuDQGSYyXtjdslOp+cFlwBZILY50hOBdLAmWo90FN7y3ljbTOmsM2kPDjVumg/tENBYs3fm1lu8+ADuxz/LoVpQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615909088; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Subject:To; bh=Io4/SuSrOnO2lgbZBjKm6Sy30ngmcZaMUy5F+H9fpyg=; b=Ijp9hJTh1T7T32EucK7FEGXtmMKqDto0qK2dlM1XPTDokBbHwl30dyRqV8hl2+U1zuKxmPlGxGcQ87ldxI6In4MC9mWEbl2z97TVcy8OQSbbibd02pfjZyHdESrvvojwzztOk3Ntsa9SbpYoAkF6ba/B8uZMy7vW48ZqwWhDttc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1615909088653997.1702798744545; Tue, 16 Mar 2021 08:38:08 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234875AbhCPPh7 (ORCPT ); Tue, 16 Mar 2021 11:37:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230358AbhCPPh0 (ORCPT ); Tue, 16 Mar 2021 11:37:26 -0400 Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5140CC06174A; Tue, 16 Mar 2021 08:37:26 -0700 (PDT) Received: by mail-qk1-x72f.google.com with SMTP id n79so35644124qke.3; Tue, 16 Mar 2021 08:37:26 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:1ee]) by smtp.gmail.com with ESMTPSA id k24sm13719703qtu.35.2021.03.16.08.37.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Mar 2021 08:37:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Io4/SuSrOnO2lgbZBjKm6Sy30ngmcZaMUy5F+H9fpyg=; b=litRM2T0M677dAg8+HS9+0ucinGZ/dprpSboNx4ygkFJPc0HA7LeXLHFrv7Q9m7k79 aUxF39PH+bvWZtQ0icKUCN/4ShHLXO2+bh72cKKbvhbVjEJDHIL0WCz61My8fhcto88B QvLWU0tlpdH7qaNFpUHjdjkJ7Asl4Hi0b3cRIqZ93FsHXczVR7keUqqqpiMBaIlsoJ5m HokRsWiOoqXWTO98zQWkfe4xQC3jTTfs0+bMx0aKRlA47CnKyFscvmsBxs3Z7jKLx+jd 1HGoBPab+GGGBMBfNjofRaLQVJrgvBq2KfmpJBH1thj4ZTg7KHcg32MgwI4IJ2rSfJh/ 2noQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Io4/SuSrOnO2lgbZBjKm6Sy30ngmcZaMUy5F+H9fpyg=; b=UGpG9V4OnQC+ojYGwVpuuE57tDN/CJKaCIyFF9O5E6jFskJE8KnHz1twipyETK08A0 VZiIg7amJv6ritRSKUSsDFts/HLgifNK44sfP/vNMY0kONsyPIfX7IAL2iReHum5fGrI nNmVYRzE5Kw6V9RZTAJBOxFKYcrCvuj3OBnzrBu+PpBbXhEbNfLHUM+AFLaVgtiOcfnG Ycft2T7EuoP738a7+2Hjoe58Yv7ble8tF9wUAbVoMYGzbN68dyJeqDuv5Kta3FekUJxE 0qPNLqsOMjcLleF1x4Nm0882MdOdT2IWC4IXIRtUlxkXLNdQs8KThnwqqeOH2gBIKjCw T/sg== X-Gm-Message-State: AOAM531iz5DI4/pTA5rmh9Epbu+vzvtLqtzXqZnirlKUMlq5C5GbcmL5 yd7b7mb+i4SRx3E9/pnBMII= X-Google-Smtp-Source: ABdhPJzLhmIigbpwLFc93Ups8jNMalmervLIp/mKz6S4aNI/h1o+8g1FB8LgzYpx7UXu9v1tS7X0QA== X-Received: by 2002:a37:6ca:: with SMTP id 193mr125522qkg.405.1615909045580; Tue, 16 Mar 2021 08:37:25 -0700 (PDT) From: Dan Schatzberg Cc: Jens Axboe , Tejun Heo , Zefan Li , Johannes Weiner , Andrew Morton , Michal Hocko , Vladimir Davydov , Hugh Dickins , Shakeel Butt , Roman Gushchin , Muchun Song , Alex Shi , Alexander Duyck , Chris Down , Yafang Shao , Wei Yang , linux-block@vger.kernel.org (open list:BLOCK LAYER), linux-kernel@vger.kernel.org (open list), cgroups@vger.kernel.org (open list:CONTROL GROUP (CGROUP)), linux-mm@kvack.org (open list:MEMORY MANAGEMENT) Subject: [PATCH 2/3] mm: Charge active memcg when no mm is set Date: Tue, 16 Mar 2021 08:36:51 -0700 Message-Id: <20210316153655.500806-3-schatzberg.dan@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210316153655.500806-1-schatzberg.dan@gmail.com> References: <20210316153655.500806-1-schatzberg.dan@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" memalloc_use_memcg() worked for kernel allocations but was silently ignored for user pages. This patch establishes a precedence order for who gets charged: 1. If there is a memcg associated with the page already, that memcg is charged. This happens during swapin. 2. If an explicit mm is passed, mm->memcg is charged. This happens during page faults, which can be triggered in remote VMs (eg gup). 3. Otherwise consult the current process context. If it has configured a current->active_memcg, use that. Otherwise, current->mm->memcg. Previously, if a NULL mm was passed to mem_cgroup_try_charge (case 3) it would always charge the root cgroup. Now it looks up the current active_memcg first (falling back to charging the root cgroup if not set). Signed-off-by: Dan Schatzberg Acked-by: Johannes Weiner Acked-by: Tejun Heo Acked-by: Chris Down Reviewed-by: Shakeel Butt --- mm/filemap.c | 2 +- mm/memcontrol.c | 14 +++++++++++--- mm/shmem.c | 4 ++-- 3 files changed, 14 insertions(+), 6 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index 43700480d897..5135f330f05c 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -843,7 +843,7 @@ noinline int __add_to_page_cache_locked(struct page *pa= ge, page->index =3D offset; =20 if (!huge) { - error =3D mem_cgroup_charge(page, current->mm, gfp); + error =3D mem_cgroup_charge(page, NULL, gfp); if (error) goto error; charged =3D true; diff --git a/mm/memcontrol.c b/mm/memcontrol.c index e064ac0d850a..9a1b23ed3412 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -6690,7 +6690,8 @@ void mem_cgroup_calculate_protection(struct mem_cgrou= p *root, * @gfp_mask: reclaim mode * * Try to charge @page to the memcg that @mm belongs to, reclaiming - * pages according to @gfp_mask if necessary. + * pages according to @gfp_mask if necessary. if @mm is NULL, try to + * charge to the active memcg. * * Returns 0 on success. Otherwise, an error code is returned. */ @@ -6726,8 +6727,15 @@ int mem_cgroup_charge(struct page *page, struct mm_s= truct *mm, gfp_t gfp_mask) rcu_read_unlock(); } =20 - if (!memcg) - memcg =3D get_mem_cgroup_from_mm(mm); + if (!memcg) { + if (!mm) { + memcg =3D get_mem_cgroup_from_current(); + if (!memcg) + memcg =3D get_mem_cgroup_from_mm(current->mm); + } else { + memcg =3D get_mem_cgroup_from_mm(mm); + } + } =20 ret =3D try_charge(memcg, gfp_mask, nr_pages); if (ret) diff --git a/mm/shmem.c b/mm/shmem.c index b2db4ed0fbc7..353b362c370e 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -1695,7 +1695,7 @@ static int shmem_swapin_page(struct inode *inode, pgo= ff_t index, { struct address_space *mapping =3D inode->i_mapping; struct shmem_inode_info *info =3D SHMEM_I(inode); - struct mm_struct *charge_mm =3D vma ? vma->vm_mm : current->mm; + struct mm_struct *charge_mm =3D vma ? vma->vm_mm : NULL; struct page *page; swp_entry_t swap; int error; @@ -1816,7 +1816,7 @@ static int shmem_getpage_gfp(struct inode *inode, pgo= ff_t index, } =20 sbinfo =3D SHMEM_SB(inode->i_sb); - charge_mm =3D vma ? vma->vm_mm : current->mm; + charge_mm =3D vma ? vma->vm_mm : NULL; =20 page =3D pagecache_get_page(mapping, index, FGP_ENTRY | FGP_HEAD | FGP_LOCK, 0); --=20 2.30.2 From nobody Mon May 6 14:00:08 2024 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1615909089; cv=none; d=zohomail.com; s=zohoarc; b=HEI0nnEP3MzkSUIpfootKG5Ut7r8s1RxpZLXlAudmf1EGUqIKgyvADTOsweowZA/Blz6R6+F20cZLVOgLuazWvzjCH36SiUEC0yZX0EI8tTorS/GOGohPogAlCUJ3R78RS5B5QyO5GeChJd3LF2VT2LxloJXeT1TznU7HozqT3Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615909089; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Subject:To; bh=SADjSKEOkix4t8p9x6JY890dWdHLGsY9Rc7Lg6faQoU=; b=HMGYG6pnclsAXaSmde5HQOQ8dRUiWtGdUlExT9LUtv/+LX+AFaB+oSO4P0IvMwx7oGLXXRh5Gv8NEmlWlGo8lIBelESrHSnvV8CJ43s5cX8StI1NZAYRCoDifP3B4d9EKvB301VOsQEcEqT/jkq7UmaP7jj8Ng7g7bMSwVHc9AY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1615909089473628.382316597855; Tue, 16 Mar 2021 08:38:09 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237103AbhCPPiD (ORCPT ); Tue, 16 Mar 2021 11:38:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230493AbhCPPhc (ORCPT ); Tue, 16 Mar 2021 11:37:32 -0400 Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D151FC06174A; Tue, 16 Mar 2021 08:37:31 -0700 (PDT) Received: by mail-qk1-x72f.google.com with SMTP id t4so35670472qkp.1; Tue, 16 Mar 2021 08:37:31 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:1ee]) by smtp.gmail.com with ESMTPSA id h11sm10255114qtp.24.2021.03.16.08.37.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Mar 2021 08:37:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SADjSKEOkix4t8p9x6JY890dWdHLGsY9Rc7Lg6faQoU=; b=rM8fq07zA9C4bo9WSbloq+ek277Q5kGSB7HNIy5MooE0Bf/vReCLqO4IviXlNiZ2aw gFCQU9fv/bm/p05hS5ZbsOFJ+grHxZU2+2COb0cuhEMZurcChMHtmgh/wQBzpehMLhBI 7u5utpXXm68vTqK72bGlfjCek7+nFC7VbUauxGyzLmY+68pwX4dfEOm3HM+kkzlwOZZu aoK9mYEyMOmLn4nf4iF05Zkme8X9tDhtgVeDxLr1SpsYTE+PyelRbgcrL7W9/EtqeXLw mXP1Rs1RBVP+kUdU5RkduPWn1/dpECrMQGZzo+5ioaoNCumIxQ9jdLWS/KWgOAgCUwcf 4gPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SADjSKEOkix4t8p9x6JY890dWdHLGsY9Rc7Lg6faQoU=; b=dvYTd1y0T5bHako3qX5y0bER4y2rL5k7ZtFDWTjDabekNZtyp0ZWH6itEgas2htxEA rkwTfM15axoiIjMU4dTvbLB0FVb3gJn+cB3/9na4uLeXiqSc472HKa7wEPAmCxzhW9Di 7YgXQVAwB7wdPyzbKH+VIkg0o6zvbDdm9Elw0Rtv2Lj85iejEn8BwrkL3d+NlBWN1k9Z IlypKwuUTNH+a6/dNJ1Skr9g4/ObRbBWVIvOnXR5GV4TeZN7ln7cZqp4sxmLzEXdD4kO SgxUm+pLsrkZn5HskVKmBoYbQwfKIq1hvAJxE7hgWabjGoyLUN9uSSJtNUeGbM4NigZe CaMg== X-Gm-Message-State: AOAM533wLiWnzzQYNZY0IJeMR1EQG+1+wWIPtcLt1MrsK9Re1mfsFu24 vHqlu3NdjyFHOEXfy794NgK8qWINjzicgw== X-Google-Smtp-Source: ABdhPJy7GZTEmdCMo498WUqWo9a2uGPWdWpqsedqeFm0EtTYld1vhYQOY8G7RBbK3kSdSt6fd4aawQ== X-Received: by 2002:a37:7b41:: with SMTP id w62mr195775qkc.256.1615909051073; Tue, 16 Mar 2021 08:37:31 -0700 (PDT) From: Dan Schatzberg Cc: Jens Axboe , Tejun Heo , Zefan Li , Johannes Weiner , Andrew Morton , Michal Hocko , Vladimir Davydov , Hugh Dickins , Shakeel Butt , Roman Gushchin , Muchun Song , Alex Shi , Alexander Duyck , Chris Down , Yafang Shao , Wei Yang , linux-block@vger.kernel.org (open list:BLOCK LAYER), linux-kernel@vger.kernel.org (open list), cgroups@vger.kernel.org (open list:CONTROL GROUP (CGROUP)), linux-mm@kvack.org (open list:MEMORY MANAGEMENT) Subject: [PATCH 3/3] loop: Charge i/o to mem and blk cg Date: Tue, 16 Mar 2021 08:36:52 -0700 Message-Id: <20210316153655.500806-4-schatzberg.dan@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210316153655.500806-1-schatzberg.dan@gmail.com> References: <20210316153655.500806-1-schatzberg.dan@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The current code only associates with the existing blkcg when aio is used to access the backing file. This patch covers all types of i/o to the backing file and also associates the memcg so if the backing file is on tmpfs, memory is charged appropriately. This patch also exports cgroup_get_e_css and int_active_memcg so it can be used by the loop module. Signed-off-by: Dan Schatzberg Acked-by: Johannes Weiner --- drivers/block/loop.c | 61 +++++++++++++++++++++++++------------- drivers/block/loop.h | 3 +- include/linux/memcontrol.h | 11 +++++++ kernel/cgroup/cgroup.c | 1 + mm/memcontrol.c | 1 + 5 files changed, 56 insertions(+), 21 deletions(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 5c080af73caa..6cf3086a2e75 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -77,6 +77,7 @@ #include #include #include +#include =20 #include "loop.h" =20 @@ -515,8 +516,6 @@ static void lo_rw_aio_complete(struct kiocb *iocb, long= ret, long ret2) { struct loop_cmd *cmd =3D container_of(iocb, struct loop_cmd, iocb); =20 - if (cmd->css) - css_put(cmd->css); cmd->ret =3D ret; lo_rw_aio_do_completion(cmd); } @@ -577,8 +576,6 @@ static int lo_rw_aio(struct loop_device *lo, struct loo= p_cmd *cmd, cmd->iocb.ki_complete =3D lo_rw_aio_complete; cmd->iocb.ki_flags =3D IOCB_DIRECT; cmd->iocb.ki_ioprio =3D IOPRIO_PRIO_VALUE(IOPRIO_CLASS_NONE, 0); - if (cmd->css) - kthread_associate_blkcg(cmd->css); =20 if (rw =3D=3D WRITE) ret =3D call_write_iter(file, &cmd->iocb, &iter); @@ -586,7 +583,6 @@ static int lo_rw_aio(struct loop_device *lo, struct loo= p_cmd *cmd, ret =3D call_read_iter(file, &cmd->iocb, &iter); =20 lo_rw_aio_do_completion(cmd); - kthread_associate_blkcg(NULL); =20 if (ret !=3D -EIOCBQUEUED) cmd->iocb.ki_complete(&cmd->iocb, ret, 0); @@ -927,7 +923,7 @@ struct loop_worker { struct list_head cmd_list; struct list_head idle_list; struct loop_device *lo; - struct cgroup_subsys_state *css; + struct cgroup_subsys_state *blkcg_css; unsigned long last_ran_at; }; =20 @@ -944,7 +940,7 @@ static void loop_queue_work(struct loop_device *lo, str= uct loop_cmd *cmd) =20 spin_lock_irq(&lo->lo_work_lock); =20 - if (!cmd->css) + if (!cmd->blkcg_css) goto queue_work; =20 node =3D &lo->worker_tree.rb_node; @@ -952,10 +948,10 @@ static void loop_queue_work(struct loop_device *lo, s= truct loop_cmd *cmd) while (*node) { parent =3D *node; cur_worker =3D container_of(*node, struct loop_worker, rb_node); - if (cur_worker->css =3D=3D cmd->css) { + if (cur_worker->blkcg_css =3D=3D cmd->blkcg_css) { worker =3D cur_worker; break; - } else if ((long)cur_worker->css < (long)cmd->css) { + } else if ((long)cur_worker->blkcg_css < (long)cmd->blkcg_css) { node =3D &(*node)->rb_left; } else { node =3D &(*node)->rb_right; @@ -967,13 +963,18 @@ static void loop_queue_work(struct loop_device *lo, s= truct loop_cmd *cmd) worker =3D kzalloc(sizeof(struct loop_worker), GFP_NOWAIT | __GFP_NOWARN); /* * In the event we cannot allocate a worker, just queue on the - * rootcg worker + * rootcg worker and issue the I/O as the rootcg */ - if (!worker) + if (!worker) { + cmd->blkcg_css =3D NULL; + if (cmd->memcg_css) + css_put(cmd->memcg_css); + cmd->memcg_css =3D NULL; goto queue_work; + } =20 - worker->css =3D cmd->css; - css_get(worker->css); + worker->blkcg_css =3D cmd->blkcg_css; + css_get(worker->blkcg_css); INIT_WORK(&worker->work, loop_workfn); INIT_LIST_HEAD(&worker->cmd_list); INIT_LIST_HEAD(&worker->idle_list); @@ -1297,7 +1298,7 @@ static int __loop_clr_fd(struct loop_device *lo, bool= release) idle_list) { list_del(&worker->idle_list); rb_erase(&worker->rb_node, &lo->worker_tree); - css_put(worker->css); + css_put(worker->blkcg_css); kfree(worker); } spin_unlock_irq(&lo->lo_work_lock); @@ -2102,13 +2103,18 @@ static blk_status_t loop_queue_rq(struct blk_mq_hw_= ctx *hctx, } =20 /* always use the first bio's css */ + cmd->blkcg_css =3D NULL; + cmd->memcg_css =3D NULL; #ifdef CONFIG_BLK_CGROUP - if (cmd->use_aio && rq->bio && rq->bio->bi_blkg) { - cmd->css =3D &bio_blkcg(rq->bio)->css; - css_get(cmd->css); - } else + if (rq->bio && rq->bio->bi_blkg) { + cmd->blkcg_css =3D &bio_blkcg(rq->bio)->css; +#ifdef CONFIG_MEMCG + cmd->memcg_css =3D + cgroup_get_e_css(cmd->blkcg_css->cgroup, + &memory_cgrp_subsys); +#endif + } #endif - cmd->css =3D NULL; loop_queue_work(lo, cmd); =20 return BLK_STS_OK; @@ -2120,13 +2126,28 @@ static void loop_handle_cmd(struct loop_cmd *cmd) const bool write =3D op_is_write(req_op(rq)); struct loop_device *lo =3D rq->q->queuedata; int ret =3D 0; + struct mem_cgroup *old_memcg =3D NULL; =20 if (write && (lo->lo_flags & LO_FLAGS_READ_ONLY)) { ret =3D -EIO; goto failed; } =20 + if (cmd->blkcg_css) + kthread_associate_blkcg(cmd->blkcg_css); + if (cmd->memcg_css) + old_memcg =3D set_active_memcg( + mem_cgroup_from_css(cmd->memcg_css)); + ret =3D do_req_filebacked(lo, rq); + + if (cmd->blkcg_css) + kthread_associate_blkcg(NULL); + + if (cmd->memcg_css) { + set_active_memcg(old_memcg); + css_put(cmd->memcg_css); + } failed: /* complete non-aio request */ if (!cmd->use_aio || ret) { @@ -2205,7 +2226,7 @@ static void loop_free_idle_workers(struct timer_list = *timer) break; list_del(&worker->idle_list); rb_erase(&worker->rb_node, &lo->worker_tree); - css_put(worker->css); + css_put(worker->blkcg_css); kfree(worker); } if (!list_empty(&lo->idle_worker_list)) diff --git a/drivers/block/loop.h b/drivers/block/loop.h index 9289c1cd6374..cd24a81e00e6 100644 --- a/drivers/block/loop.h +++ b/drivers/block/loop.h @@ -76,7 +76,8 @@ struct loop_cmd { long ret; struct kiocb iocb; struct bio_vec *bvec; - struct cgroup_subsys_state *css; + struct cgroup_subsys_state *blkcg_css; + struct cgroup_subsys_state *memcg_css; }; =20 /* Support for loadable transfer modules */ diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index 0c04d39a7967..fd5dd961d01f 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -1187,6 +1187,17 @@ static inline struct mem_cgroup *get_mem_cgroup_from= _mm(struct mm_struct *mm) return NULL; } =20 +static inline struct mem_cgroup *get_mem_cgroup_from_page(struct page *pag= e) +{ + return NULL; +} + +static inline +struct mem_cgroup *mem_cgroup_from_css(struct cgroup_subsys_state *css) +{ + return NULL; +} + static inline void mem_cgroup_put(struct mem_cgroup *memcg) { } diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index 9153b20e5cc6..94c88f7221c5 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -577,6 +577,7 @@ struct cgroup_subsys_state *cgroup_get_e_css(struct cgr= oup *cgrp, rcu_read_unlock(); return css; } +EXPORT_SYMBOL_GPL(cgroup_get_e_css); =20 static void cgroup_get_live(struct cgroup *cgrp) { diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 9a1b23ed3412..f05501669e29 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -78,6 +78,7 @@ struct mem_cgroup *root_mem_cgroup __read_mostly; =20 /* Active memory cgroup to use from an interrupt context */ DEFINE_PER_CPU(struct mem_cgroup *, int_active_memcg); +EXPORT_PER_CPU_SYMBOL_GPL(int_active_memcg); =20 /* Socket memory accounting disabled? */ static bool cgroup_memory_nosocket; --=20 2.30.2