From nobody Sat May 10 19:40:27 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=quarantine dis=none) header.from=gwmail.gwu.edu ARC-Seal: i=1; a=rsa-sha256; t=1620603221; cv=none; d=zohomail.com; s=zohoarc; b=hGtLSOetFlYNUf59l2Wt21uVcz9ucFndeXC3HLf0XzFmmRpowB6htKW1Gc0l0ZymZWguDYDVLF1fTbhKDXw6fH1I7NIhDFIrsGe03s9b5lYcyrQSuPnLPIE4lR7y7IQsCEo+EGKOqYNPrE2W42hfKK8UYyZDjknyildLQwwewQ4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620603221; h=Cc:Date:From:List-Id:Message-ID:Subject:To; bh=YkDDytZNQxbBUAfAVAEk4fD9xRC/hQr+ckTlhR7Sl/U=; b=h9vHI4w5MmGHAl2WwH0zMl3gMiIin8zEzuR/mY1gZS5w0CcPOSXQ3C66AmecZgtnQq5qbVwuFQKYE9PWhARw3hiV4bWWy+zPjrePIG6U8ebtW4nDitOUZ0Ldxb0boW7gjzz6ZbP6jrXhRE49DMjVwBIvqZpXugJzsT+bs+4NIvo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail header.from= (p=quarantine dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1620603221551358.0114199535118; Sun, 9 May 2021 16:33:41 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230023AbhEIXen (ORCPT ); Sun, 9 May 2021 19:34:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229882AbhEIXel (ORCPT ); Sun, 9 May 2021 19:34:41 -0400 Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71A52C061573 for ; Sun, 9 May 2021 16:33:35 -0700 (PDT) Received: by mail-qk1-x732.google.com with SMTP id o27so13794278qkj.9 for ; Sun, 09 May 2021 16:33:35 -0700 (PDT) Received: from bunsen3.telenet.unc.edu (bunsen3.telenet.unc.edu. [204.85.191.47]) by smtp.googlemail.com with ESMTPSA id 7sm5789256qkd.20.2021.05.09.16.33.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 May 2021 16:33:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gwmail.gwu.edu; s=google; h=from:to:cc:subject:date:message-id; bh=YkDDytZNQxbBUAfAVAEk4fD9xRC/hQr+ckTlhR7Sl/U=; b=FG6PiqyE9rwCmLm9vyAou6ABFbikh0QGJVU0tj77mdedT8Gdo/QKRDk6Gkn50zGeLC Svv58IeJagoFS7uMs2L5zQi0Se21n5ap2lva5U9g3qMt/9IjtBYTGNfLb47dHk1LN92S iWClsRA7Mc1xYvmY1v5g2PEUNU+eSH9HgLTf3QLQ8Dnhqmsc3X/ix2mW6PHZbtTcXdz2 5fI+JZAuWqEChaenVa3KD6cA2a0ZHFJfK/sDWYE+rPFlvkqOnLMkmVv54emtTkv+rfML 6ZRnhHaVcyH7PqQ47CqDBIdP1GBmNeu+UP29Wu5JKza9mvY7yndPNUysZhJsf+CQz0Az rIgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=YkDDytZNQxbBUAfAVAEk4fD9xRC/hQr+ckTlhR7Sl/U=; b=XUeAtN78V+bghYnctV9yor4vqmzSfwy/by2/b5aVAV7Y2ZPn7mmEdidXXTrmOwP4vn RHdrSaQRljwHFZJgNlv46sRF/g3AfGSZtqc1J0p4BAnCN4yBI5uJGFD22Bgsfhqx93Dq MQ7AJh10HvFkecJXZeIFEjpsTOWaELLKQTgjdzJOhCRos2buOi+VbzN5O3hbA9RRbxl/ lwUB74u0Vobm6MRFej3g4NQmnpLBPzctoWHNI3kF2q+rZ45RedKtJtsYL3gmGAY0vIed NHryUB36Fh2WiIvAc76t3V8vejjfr8Xb22e8x+FSv9zpulF1wbIEW8odVEQHfLemIG8j Fxog== X-Gm-Message-State: AOAM531PDg8Br/3n5aVqK5qgnLNr8mS4bt9SkH57zqQbfTUnOEIw+e4J q8iYXBEWK8BK0GlWLMBPLPVwWfJGd9MIdA== X-Google-Smtp-Source: ABdhPJx8IK1oBHvd+hmpLgGmiiozZrYWxFIVWOxr6sSYq+mtN0m69XKwqC5beCyk5AaJfI+3WS4Tvg== X-Received: by 2002:a05:620a:c8f:: with SMTP id q15mr444683qki.400.1620603214599; Sun, 09 May 2021 16:33:34 -0700 (PDT) From: wenhuizhang Cc: wenhui@gwmail.gwu.edu, Steve French , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org Subject: [PATCH] Signed-off-by: wenhuizhang Date: Sun, 9 May 2021 19:33:27 -0400 Message-Id: <20210509233327.22241-1-wenhui@gwmail.gwu.edu> X-Mailer: git-send-email 2.17.1 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Deadstore detected by Lukas Bulwahn's CodeChecker Tool (ELISA group). line 741 struct cifsInodeInfo *cinode; line 747 cinode =3D CIFS_I(d_inode(cfile->dentry)); could be deleted. Signed-off-by: wenhuizhang cinode on filesystem should not be deleted when files are closed, they are = representations of some data fields on a physical disk, thus no further act= ion is required. The virtual inode on vfs will be handled by vfs automatically, and the deno= tation is inode, which is different from the cinode. --- fs/cifs/misc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/cifs/misc.c b/fs/cifs/misc.c index 524dbdfb7184..801a5300f765 100644 --- a/fs/cifs/misc.c +++ b/fs/cifs/misc.c @@ -738,13 +738,11 @@ void cifs_close_all_deferred_files(struct cifs_tcon *tcon) { struct cifsFileInfo *cfile; - struct cifsInodeInfo *cinode; struct list_head *tmp; =20 spin_lock(&tcon->open_file_lock); list_for_each(tmp, &tcon->openFileList) { cfile =3D list_entry(tmp, struct cifsFileInfo, tlist); - cinode =3D CIFS_I(d_inode(cfile->dentry)); if (delayed_work_pending(&cfile->deferred)) mod_delayed_work(deferredclose_wq, &cfile->deferred, 0); } --=20 2.17.1