From nobody Sat May 10 19:33:47 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=quarantine dis=none) header.from=gwmail.gwu.edu ARC-Seal: i=1; a=rsa-sha256; t=1620772477; cv=none; d=zohomail.com; s=zohoarc; b=n03GT3fnZrk9127A8FdY//LH5x8D34S97zIVeDzJivjsA5+LiudJfJUYoIX+NEL815m4TUndlGAOCO9T8NcQvfnszZBXXIwGAONJsehHHSX1vn7aKY/ZFjOmpaEUgnA4Ho2HEmciFCozCDO0qzkJvIdxS2sHJz+2iQLMTyNxtPc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620772477; h=Cc:Date:From:In-Reply-To:List-Id:Message-ID:References:Subject:To; bh=42C6HOQrWTE0332FVLv9iuHqZnhb3K1H7/h3GIL4MSc=; b=oBO5CbCPlkFtuagzB7FQ2OyRRG3tdUIn+OfK3UcJa/1qORE93MCcr1rOMLD+8V4dG8MFYialh7NsI0JoxOlwe07OxNKq/ZI1ewVehrOj6QDmYKbrHizymkGj1gykS6jKnjy7wnk52wI6o9q3VlF4RBjiPzlA0dox2XslMQUq68E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail header.from= (p=quarantine dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1620772477233952.064544634773; Tue, 11 May 2021 15:34:37 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230011AbhEKWfm (ORCPT ); Tue, 11 May 2021 18:35:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229637AbhEKWfl (ORCPT ); Tue, 11 May 2021 18:35:41 -0400 Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD1AAC061574 for ; Tue, 11 May 2021 15:34:34 -0700 (PDT) Received: by mail-qt1-x82f.google.com with SMTP id v4so7093182qtp.1 for ; Tue, 11 May 2021 15:34:34 -0700 (PDT) Received: from bunsen3.telenet.unc.edu (bunsen3.telenet.unc.edu. [204.85.191.47]) by smtp.googlemail.com with ESMTPSA id b23sm9042761qtq.0.2021.05.11.15.34.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 15:34:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gwmail.gwu.edu; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=42C6HOQrWTE0332FVLv9iuHqZnhb3K1H7/h3GIL4MSc=; b=R3jEIakaWLP5NOGisY4zhv2ai1fhVP4du3Af0XCzYkDEr7hC9neNDaWKQFaNRokVff g9ir6mrvxtoheB8wliCGGydK2tz2GMl/NxG8NOHpUVScs7tfT59egprnXznWQs6ENvcD AJ2kOYea2SEWt7YvaD21PciyAuRE1qrtteAul016yMMMQIxpoD3yhJrJTxq3yDS4iraZ nfGf9yBAF8jctw9Qo4GyZVxt3yBf90LThpHG8dEYMzywhTDKuywdgHrde7Z9H6eATbjR o391p+SDKEhSUh5yv28rcdE9TNz9BzR1bpIKY3ZzSkBIuYupdR6kPaG4iEKHHhbhFwT3 1uCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=42C6HOQrWTE0332FVLv9iuHqZnhb3K1H7/h3GIL4MSc=; b=VI3ygKVwozBPKwhSvoVrBN4RXsdreq64IGop68SaUdnD3K18Twlkgx9eWZGjYFtvw0 J4Vd9bCbXPLuk5fSH4JndPjLq+QsuWJhz+IemsBLu+fGsqLO6RbOBbfMbuBOMtFeV5pC 3A45RqnxYYNH0RGnEVY1TFTcNMAuzWsGBtG9N7cQPVoLgPEDEE+LZaab/mzYpe3eHcCv SZZ/wCen/yAhfHIH/yaafQmEF57AXl7xAir1dUCzZoAwQnQW1mbrobKZZAvEdkOoOeZO HGn4RtTLnXfsSvRuPf36Gvy1VhnJ9oern4g2PpHy4U78s6HBInqTSnH91Ir7623db0IS rOaA== X-Gm-Message-State: AOAM531H0BqJawJ7Snfe9YN2S91eLnSc6JEQGs2Obf/DHB3ssLe5hNTD C0uJfbtK+t+9ReDzkJpouwiU003QMfiqcSyz500= X-Google-Smtp-Source: ABdhPJxV96xnFvz7FJPLVu7Br1PXs3Jda9e433Lii337jAA4jXMN/PND2tj93cJuK4xl7CincupAVw== X-Received: by 2002:a05:622a:d1:: with SMTP id p17mr30792975qtw.86.1620772474057; Tue, 11 May 2021 15:34:34 -0700 (PDT) From: wenhuizhang Cc: wenhuizhang , Steve French , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org Subject: [PATCH] Deadstore detected by Lukas Bulwahn's CodeChecker Tool (ELISA group) Date: Tue, 11 May 2021 18:34:25 -0400 Message-Id: <20210511223425.12863-1-wenhui@gwmail.gwu.edu> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210509233327.22241-1-wenhui@gwmail.gwu.edu> References: <20210509233327.22241-1-wenhui@gwmail.gwu.edu> To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Deadstore detected by Lukas Bulwahn's CodeChecker Tool (ELISA group). line 741 struct cifsInodeInfo *cinode; line 747 cinode =3D CIFS_I(d_inode(cfile->dentry)); could be deleted. cinode on filesystem should not be deleted when files are closed, they are = representations of some data fields on a physical disk, thus no further act= ion is required. The virtual inode on vfs will be handled by vfs automatically, and the deno= tation is inode, which is different from the cinode. Signed-off-by: wenhuizhang --- fs/cifs/misc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/cifs/misc.c b/fs/cifs/misc.c index 524dbdfb7184..801a5300f765 100644 --- a/fs/cifs/misc.c +++ b/fs/cifs/misc.c @@ -738,13 +738,11 @@ void cifs_close_all_deferred_files(struct cifs_tcon *tcon) { struct cifsFileInfo *cfile; - struct cifsInodeInfo *cinode; struct list_head *tmp; =20 spin_lock(&tcon->open_file_lock); list_for_each(tmp, &tcon->openFileList) { cfile =3D list_entry(tmp, struct cifsFileInfo, tlist); - cinode =3D CIFS_I(d_inode(cfile->dentry)); if (delayed_work_pending(&cfile->deferred)) mod_delayed_work(deferredclose_wq, &cfile->deferred, 0); } --=20 2.17.1