From nobody Sat May 10 23:48:59 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=quarantine dis=none) header.from=gwmail.gwu.edu ARC-Seal: i=1; a=rsa-sha256; t=1620924934; cv=none; d=zohomail.com; s=zohoarc; b=BXyfnmOkX17PNWEBVd/l7BCj8AGLJ3RBexEJ55Slm/qvvNx0FE8cAGj/hm8M1Y/DrUP9HmilciTFo/sCkLji9Lm3NIr5yzMLDOiT201pVTcm9hj+3WoMTeLyb8A4nlILgg03LdqHJKRdmSh8BuFUGJjTyd1+96HNxMaYU9n/dvQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620924934; h=Cc:Date:From:In-Reply-To:List-Id:Message-ID:References:Subject:To; bh=A3RlebzumK4fwWT1g6X56MvDeVE+yh0/VbEO7iqxO7Y=; b=efcMBJpgPqBbdqbwnB98yGoObmnLPVoOwJdvQqYA3rHP/KwH1tRuZKxM211DOoQraLqT3ygNK5CAMoE00AV5IJvPlPwWI1aWuyd4nOVjMfRPy10Frf2rOsT9rvyKKSkdF5+lkAyC5cetEyD09r3fUXnlCQFvE/6P/oYiDPpdryo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail header.from= (p=quarantine dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1620924934024203.22906993489948; Thu, 13 May 2021 09:55:34 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229659AbhEMQ4l (ORCPT ); Thu, 13 May 2021 12:56:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbhEMQ4h (ORCPT ); Thu, 13 May 2021 12:56:37 -0400 Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBEB8C06174A for ; Thu, 13 May 2021 09:55:23 -0700 (PDT) Received: by mail-qt1-x82a.google.com with SMTP id k19so818451qta.2 for ; Thu, 13 May 2021 09:55:23 -0700 (PDT) Received: from bunsen3.telenet.unc.edu (bunsen3.telenet.unc.edu. [204.85.191.47]) by smtp.googlemail.com with ESMTPSA id x28sm2941976qtm.71.2021.05.13.09.55.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 09:55:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gwmail.gwu.edu; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=A3RlebzumK4fwWT1g6X56MvDeVE+yh0/VbEO7iqxO7Y=; b=aM0eoV69VvprQUrTyUbnsyRwLhtc9v2X9TTz1Bh90nd46vAUrT+gV31TPjMejwxTOh CQm0ficz7+HsBbj3VlrSA2yvkkjcSAYzOAjF5nWlMbxEbnXXHRFwyacMQ8aS5fryRNxa oY7JbaFR2p2696Ai3bWtmhr4BEnyfFdooX8eZOp3kPyzppVHu3WB0NPhqNQn5AUOG819 mq7M0qMuSQJCMQL99KoC8DMOoYssJiWLTuSqdbR0iXYCAh9DKI2wZso9f23vhMXYQwrG 0FcddsgDsF1D1I9D1U16v+Vud12aHFpgS6UjrKBY0JccA+RltlHsbtEX7Z7p7auuGlbz JvqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=A3RlebzumK4fwWT1g6X56MvDeVE+yh0/VbEO7iqxO7Y=; b=RieK+Ngc3TfLKfSzibw9CzFOjJGu+yTAUqZC+KZMLQtKqmYeEyLjbuWUZzGKvAWTQS ZSHTNBdIKIAXvGyi43ptd73qUm/HhXML6Jm0/87jk430kKuftW2Jb7v0lk0VFk+Ctl2D zBbcQhbpD8L1PKmM4H3/jq9XqGv9v7iiDkgYvxnheP7ahFko9yZjhBdIRQr25YEqrwuy Pn0hTM7/ZkYnIN/d2+Oz6trEd5ThR6dC3+X2nZiC/SO3JKSjQwcOOkazCdgAL7uT4B0P uhsws/mMqoZKVsBo9CcrkX3wiPvr+mDe48Wc9kp+7wF1PYL/Tef/y60PwivXyM1quFXE ysbQ== X-Gm-Message-State: AOAM531gWcaTQMioCTLWWUYCr3RypJENMqPkqCOUgi2fzHvpRoQjbegY Nl6LIIdY7ASt3tmBxXnShZ/sNpnzffirIoEj X-Google-Smtp-Source: ABdhPJz9xooi0rxfZFpdaGUuPRq+I58reGjaeHKKrSFzRId6ykzgNlpy2+VVtXYndE/rFxu/go2OTQ== X-Received: by 2002:a05:622a:289:: with SMTP id z9mr39845914qtw.325.1620924922983; Thu, 13 May 2021 09:55:22 -0700 (PDT) From: wenhuizhang Cc: wenhuizhang , Steve French , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org Subject: [PATCH] cifs: remove deadstore in cifs_close_all_deferred_files() Date: Thu, 13 May 2021 12:55:16 -0400 Message-Id: <20210513165516.17723-1-wenhui@gwmail.gwu.edu> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210509233327.22241-1-wenhui@gwmail.gwu.edu> References: <20210509233327.22241-1-wenhui@gwmail.gwu.edu> To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Deadstore detected by Lukas Bulwahn's CodeChecker Tool (ELISA group). line 741 struct cifsInodeInfo *cinode; line 747 cinode =3D CIFS_I(d_inode(cfile->dentry)); could be deleted. cinode on filesystem should not be deleted when files are closed,=20 they are representations of some data fields on a physical disk,=20 thus no further action is required. The virtual inode on vfs will be handled by vfs automatically,=20 and the denotation is inode, which is different from the cinode. Signed-off-by: wenhuizhang --- fs/cifs/misc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/cifs/misc.c b/fs/cifs/misc.c index 524dbdfb7184..801a5300f765 100644 --- a/fs/cifs/misc.c +++ b/fs/cifs/misc.c @@ -738,13 +738,11 @@ void cifs_close_all_deferred_files(struct cifs_tcon *tcon) { struct cifsFileInfo *cfile; - struct cifsInodeInfo *cinode; struct list_head *tmp; =20 spin_lock(&tcon->open_file_lock); list_for_each(tmp, &tcon->openFileList) { cfile =3D list_entry(tmp, struct cifsFileInfo, tlist); - cinode =3D CIFS_I(d_inode(cfile->dentry)); if (delayed_work_pending(&cfile->deferred)) mod_delayed_work(deferredclose_wq, &cfile->deferred, 0); } --=20 2.17.1