From nobody Thu May 9 07:11:06 2024 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=none dis=none) header.from=huawei.com ARC-Seal: i=1; a=rsa-sha256; t=1622801170; cv=none; d=zohomail.com; s=zohoarc; b=UCoZq2gDPe2hezlGLpQQ146nugVm/AKnWETyxLrv7hJglxOYVHsAGUj++ebl+iovTYAnqOam2li6G2z4/UrNfAXwbLeOUM1joY+C05uqubVX+Fk7N434N62x/H4MN783j2fb/9DCk3honSEzZ/mBKjfbG8jhfXmqAsuVepqRElM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622801170; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Id:MIME-Version:Message-ID:Subject:To; bh=ldzzMtX/5X6zPt5A/4L++bK8Nl/EHGPmBMzWVi89kIo=; b=iIETDBzfHKrtxbm/crDM0NVrwbiJfi8jcxJq/YWDNtL+F3nj+ImGK/G62HgMY7YlzwEVtUY/XaHas0muk/2vqG7/zleZd18tu5HhkJXtFtXt7+aAvATLSQg9bJXXMyOBNShiNI3Dns7F+8D6tCG4tg9zb1m8v0ZyAHnFf2Lef3E= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1622801170204632.8795266835094; Fri, 4 Jun 2021 03:06:10 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230084AbhFDKHz (ORCPT ); Fri, 4 Jun 2021 06:07:55 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:7107 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229665AbhFDKHx (ORCPT ); Fri, 4 Jun 2021 06:07:53 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4FxJHX2Jm2zYqnx for ; Fri, 4 Jun 2021 18:03:20 +0800 (CST) Received: from dggemi758-chm.china.huawei.com (10.1.198.144) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Fri, 4 Jun 2021 18:06:06 +0800 Received: from huawei.com (10.175.101.6) by dggemi758-chm.china.huawei.com (10.1.198.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 4 Jun 2021 18:06:05 +0800 From: ChenXiaoSong CC: , , , Subject: [PATCH -next] EDAC/armada_xp: Remove redundant dev_err call in axp_mc_probe() and aurora_l2_probe() Date: Fri, 4 Jun 2021 18:12:18 +0800 Message-ID: <20210604101218.3656427-1-chenxiaosong2@huawei.com> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.101.6] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggemi758-chm.china.huawei.com (10.1.198.144) X-CFilter-Loop: Reflected To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: ChenXiaoSong --- drivers/edac/armada_xp_edac.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/edac/armada_xp_edac.c b/drivers/edac/armada_xp_edac.c index e3e757513d1b..9661c72e6554 100644 --- a/drivers/edac/armada_xp_edac.c +++ b/drivers/edac/armada_xp_edac.c @@ -297,10 +297,8 @@ static int axp_mc_probe(struct platform_device *pdev) } =20 base =3D devm_ioremap_resource(&pdev->dev, r); - if (IS_ERR(base)) { - dev_err(&pdev->dev, "Unable to map regs\n"); + if (IS_ERR(base)) return PTR_ERR(base); - } =20 config =3D readl(base + SDRAM_CONFIG_REG); if (!(config & SDRAM_CONFIG_ECC_MASK)) { @@ -525,10 +523,8 @@ static int aurora_l2_probe(struct platform_device *pde= v) } =20 base =3D devm_ioremap_resource(&pdev->dev, r); - if (IS_ERR(base)) { - dev_err(&pdev->dev, "Unable to map regs\n"); + if (IS_ERR(base)) return PTR_ERR(base); - } =20 l2x0_aux_ctrl =3D readl(base + L2X0_AUX_CTRL); if (!(l2x0_aux_ctrl & AURORA_ACR_PARITY_EN)) --=20 2.25.4