From nobody Sun May 12 20:03:01 2024 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=none dis=none) header.from=huawei.com ARC-Seal: i=1; a=rsa-sha256; t=1622801305; cv=none; d=zohomail.com; s=zohoarc; b=HBf+i4DqVreu/1T2V856Zb5HaiX82qsSlk0eW791z9hRtP1F02fI52T7lrFrGBSaFyoXza9puMGwKQNQ+dxCmy+HgS+1DIxttnfoMNdKNhu/FunRSHjZN8cKBNrMjGGHTYEhNVEqde8lrulKyeYvGlvgU6Dicu3jBdb337ZuLnw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622801305; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Id:MIME-Version:Message-ID:Subject:To; bh=QLcFudTau7ya+IcCbgMmfkuSJgkxpqyWtl6QENIo6ew=; b=OXEp1g2RYLpkp6epGrZjPwDdD+bLKUqG7b3D+fgK6s8wC52G4dOkKO7XL3Kx6mZOJm3zpdPIxszChgxrQmAaElc8TJ/10BJgZYMpMOmGLjVIhy3eMRLxZ9YB+GKP4SybyMySIHHdgWcYXRqlncmcpZkjYdQVvkviX5AtSgl2UA4= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1622801305680157.196014643357; Fri, 4 Jun 2021 03:08:25 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229809AbhFDKKK (ORCPT ); Fri, 4 Jun 2021 06:10:10 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:3062 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229612AbhFDKKJ (ORCPT ); Fri, 4 Jun 2021 06:10:09 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4FxJHq1fmJzWrPT for ; Fri, 4 Jun 2021 18:03:35 +0800 (CST) Received: from dggemi758-chm.china.huawei.com (10.1.198.144) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Fri, 4 Jun 2021 18:08:20 +0800 Received: from huawei.com (10.175.101.6) by dggemi758-chm.china.huawei.com (10.1.198.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 4 Jun 2021 18:08:20 +0800 From: ChenXiaoSong CC: , , , Subject: [PATCH -next] perf: qcom: Remove redundant dev_err call in qcom_l3_cache_pmu_probe() Date: Fri, 4 Jun 2021 18:14:43 +0800 Message-ID: <20210604101443.3657531-1-chenxiaosong2@huawei.com> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.101.6] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggemi758-chm.china.huawei.com (10.1.198.144) X-CFilter-Loop: Reflected To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: ChenXiaoSong --- drivers/perf/qcom_l3_pmu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/perf/qcom_l3_pmu.c b/drivers/perf/qcom_l3_pmu.c index 081273543c6b..c76f6f21d2a8 100644 --- a/drivers/perf/qcom_l3_pmu.c +++ b/drivers/perf/qcom_l3_pmu.c @@ -767,10 +767,8 @@ static int qcom_l3_cache_pmu_probe(struct platform_dev= ice *pdev) =20 memrc =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); l3pmu->regs =3D devm_ioremap_resource(&pdev->dev, memrc); - if (IS_ERR(l3pmu->regs)) { - dev_err(&pdev->dev, "Can't map PMU @%pa\n", &memrc->start); + if (IS_ERR(l3pmu->regs)) return PTR_ERR(l3pmu->regs); - } =20 qcom_l3_cache__init(l3pmu); =20 --=20 2.25.4