From nobody Tue Feb 10 09:14:41 2026 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=none dis=none) header.from=huawei.com ARC-Seal: i=1; a=rsa-sha256; t=1622801382; cv=none; d=zohomail.com; s=zohoarc; b=dE4gVjG2aKhx06ZJXKdZvsJ57ip+QMmjwjHSEdw9bRA+dXoLxzVTh29w3+euS1rH3W/yZw4jImZUecf44U28m8nmkhyHvE8tai2prqHJ/f9GaDnIAGmCs+qLidFO0J5glw6pS/TsIP4TQoSB6QUUgAHYulQ+HS2zq8eI6kGp48Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622801382; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Id:MIME-Version:Message-ID:Subject:To; bh=7hkUg/aiyTlnXn0OZv7hkPiJ3L8YVzW0Tn/AhyPbEH0=; b=TtwT7qfttOLP9B2sE7rqxEmGP/7YE5p1QhosYlpFDA3WCHkLmJtJ9LqI5UiosqR8HJBqdHNgx+RRtg0mnD/isg6t5ehvQTwVxeVvhsfBAJvtxF5IHxIL+O7yom/dlh4FOQdyf3SKdbRXiKDObqRi6bqIF3uagFiw0xRibTp50Dk= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1622801382143354.58511552356777; Fri, 4 Jun 2021 03:09:42 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229810AbhFDKL0 (ORCPT ); Fri, 4 Jun 2021 06:11:26 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:3429 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229668AbhFDKLZ (ORCPT ); Fri, 4 Jun 2021 06:11:25 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4FxJML4CfRz6txr for ; Fri, 4 Jun 2021 18:06:38 +0800 (CST) Received: from dggemi758-chm.china.huawei.com (10.1.198.144) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Fri, 4 Jun 2021 18:09:38 +0800 Received: from huawei.com (10.175.101.6) by dggemi758-chm.china.huawei.com (10.1.198.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 4 Jun 2021 18:09:37 +0800 From: ChenXiaoSong CC: , , , Subject: [PATCH -next] PCI: al: Remove redundant dev_err call in al_pcie_probe() Date: Fri, 4 Jun 2021 18:16:00 +0800 Message-ID: <20210604101600.3658139-1-chenxiaosong2@huawei.com> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.101.6] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggemi758-chm.china.huawei.com (10.1.198.144) X-CFilter-Loop: Reflected To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: ChenXiaoSong --- drivers/pci/controller/dwc/pcie-al.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-al.c b/drivers/pci/controller/= dwc/pcie-al.c index e8afa50129a8..fb4d1eed07ce 100644 --- a/drivers/pci/controller/dwc/pcie-al.c +++ b/drivers/pci/controller/dwc/pcie-al.c @@ -346,11 +346,8 @@ static int al_pcie_probe(struct platform_device *pdev) controller_res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "controller"); al_pcie->controller_base =3D devm_ioremap_resource(dev, controller_res); - if (IS_ERR(al_pcie->controller_base)) { - dev_err(dev, "couldn't remap controller base %pR\n", - controller_res); + if (IS_ERR(al_pcie->controller_base)) return PTR_ERR(al_pcie->controller_base); - } =20 dev_dbg(dev, "From DT: controller_base: %pR\n", controller_res); =20 --=20 2.25.4