From nobody Fri May 9 23:23:02 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=quarantine dis=quarantine) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1638450650233217.03985190828064; Thu, 2 Dec 2021 05:10:50 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358253AbhLBNOG (ORCPT ); Thu, 2 Dec 2021 08:14:06 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:59292 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358206AbhLBNNv (ORCPT ); Thu, 2 Dec 2021 08:13:51 -0500 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1B2DADRF011629; Thu, 2 Dec 2021 07:10:13 -0600 Received: from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1B2DADDO119556 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 2 Dec 2021 07:10:13 -0600 Received: from DFLE115.ent.ti.com (10.64.6.36) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Thu, 2 Dec 2021 07:10:12 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Thu, 2 Dec 2021 07:10:12 -0600 Received: from gsaswath-HP-ProBook-640-G5.dal.design.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1B2DA4Kj031324; Thu, 2 Dec 2021 07:10:09 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1638450613; bh=dn8l7Os6Ucq45HCQxIDhH9KClfTJiZ3Yf7GgLyFAQRo=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=FpwsjjE6U9wTE2g4y/MnISur//9jPLi2xTM5dQ7pDgqHM7cGzWZYM12uoah+ack6T 1w37dLeEsuRzUiM9hAC3564Xuc8F8lacvR6K4rqmzH0dkDPquzSQnw5f3lS1lpBREg 8/jAQk0cXO4R51AoL6CdwQIoM1f9oZZvSGjwowOc= From: Aswath Govindraju CC: Aswath Govindraju , Wolfgang Grandegger , Marc Kleine-Budde , Kishon Vijay Abraham I , Vinod Koul , Rob Herring , , , , Subject: [PATCH 1/2] dt-bindings: phy: ti,tcan104x-can: Document mux-states property Date: Thu, 2 Dec 2021 18:40:01 +0530 Message-ID: <20211202131002.12217-2-a-govindraju@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211202131002.12217-1-a-govindraju@ti.com> References: <20211202131002.12217-1-a-govindraju@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1638450651758100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On some boards, for routing CAN signals from controller to transceivers, muxes might need to be set. This can be implemented using mux-states property. Therefore, document the same in the respective bindings. Signed-off-by: Aswath Govindraju --- .../devicetree/bindings/phy/ti,tcan104x-can.yaml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/D= ocumentation/devicetree/bindings/phy/ti,tcan104x-can.yaml index 6107880e5246..5b2b08016635 100644 --- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml @@ -37,6 +37,18 @@ properties: max bit rate supported in bps minimum: 1 =20 + mux-states: + description: + mux controller node to route the signals from controller to + transceiver. Depending on the mux chip and the control lines + in it, the first and second parameters can be used for + representing control line and state. The number of arguments + is to be used based on '#mux-state-cells' property in the + mux-controller node. If '#mux-state-cells' is equal to + one then, then the argument to be used would be the state. + If it is set to two, then the first argument is the control + line and the second argument would be its corresponding state. + required: - compatible - '#phy-cells' @@ -53,4 +65,5 @@ examples: max-bitrate =3D <5000000>; standby-gpios =3D <&wakeup_gpio1 16 GPIO_ACTIVE_LOW>; enable-gpios =3D <&main_gpio1 67 GPIO_ACTIVE_HIGH>; + mux-states =3D <&mux0 1>; }; --=20 2.17.1 From nobody Fri May 9 23:23:02 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=quarantine dis=quarantine) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1638450681575360.236615285423; Thu, 2 Dec 2021 05:11:21 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346755AbhLBNOh (ORCPT ); Thu, 2 Dec 2021 08:14:37 -0500 Received: from lelv0142.ext.ti.com ([198.47.23.249]:41460 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358191AbhLBNOJ (ORCPT ); Thu, 2 Dec 2021 08:14:09 -0500 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1B2DAHuC048421; Thu, 2 Dec 2021 07:10:17 -0600 Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1B2DAHRH040638 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 2 Dec 2021 07:10:17 -0600 Received: from DLEE113.ent.ti.com (157.170.170.24) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Thu, 2 Dec 2021 07:10:17 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Thu, 2 Dec 2021 07:10:17 -0600 Received: from gsaswath-HP-ProBook-640-G5.dal.design.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1B2DA4Kk031324; Thu, 2 Dec 2021 07:10:14 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1638450617; bh=/NgGi4z2UeQc+qcSMlJU+oGJHEz7+dU8GUdgk8XoMWM=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=sgFp+Jl8WOfIyGB5+lRpNatDWq2bOzta78ho3vng5VRO1lhOoRU4uRS7YmjCjqEN+ d4AQWZv/0Z+nFYmHLL88T3yFMv1Ol6jMry573iKpLW1Tk3QnBoAXpfTWMrSyEpTS6J lz0+GsOKGErWypINiFtvtsrHBEckjJfr4UfSc/eQ= From: Aswath Govindraju CC: Aswath Govindraju , Wolfgang Grandegger , Marc Kleine-Budde , Kishon Vijay Abraham I , Vinod Koul , Rob Herring , , , , Subject: [PATCH 2/2] phy: phy-can-transceiver: Add support for setting mux Date: Thu, 2 Dec 2021 18:40:02 +0530 Message-ID: <20211202131002.12217-3-a-govindraju@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211202131002.12217-1-a-govindraju@ti.com> References: <20211202131002.12217-1-a-govindraju@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1638450683009100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On some boards, for routing CAN signals from controller to transceiver, muxes might need to be set. Therefore, add support for setting the mux by reading the mux-states property from the device tree node. Signed-off-by: Aswath Govindraju --- drivers/phy/Kconfig | 1 + drivers/phy/phy-can-transceiver.c | 22 ++++++++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 82b63e60c5a2..300b0f2b5f84 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -64,6 +64,7 @@ config USB_LGM_PHY config PHY_CAN_TRANSCEIVER tristate "CAN transceiver PHY" select GENERIC_PHY + select MULTIPLEXER help This option enables support for CAN transceivers as a PHY. This driver provides function for putting the transceivers in various diff --git a/drivers/phy/phy-can-transceiver.c b/drivers/phy/phy-can-transc= eiver.c index 6f3fe37dee0e..cb91d0e94da7 100644 --- a/drivers/phy/phy-can-transceiver.c +++ b/drivers/phy/phy-can-transceiver.c @@ -10,6 +10,7 @@ #include #include #include +#include =20 struct can_transceiver_data { u32 flags; @@ -21,13 +22,22 @@ struct can_transceiver_phy { struct phy *generic_phy; struct gpio_desc *standby_gpio; struct gpio_desc *enable_gpio; + struct mux_state *mux_state; }; =20 /* Power on function */ static int can_transceiver_phy_power_on(struct phy *phy) { + int ret; struct can_transceiver_phy *can_transceiver_phy =3D phy_get_drvdata(phy); =20 + if (can_transceiver_phy->mux_state) { + ret =3D mux_state_select(can_transceiver_phy->mux_state); + if (ret) { + dev_err(&phy->dev, "Failed to select CAN mux: %d\n", ret); + return ret; + } + } if (can_transceiver_phy->standby_gpio) gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 0); if (can_transceiver_phy->enable_gpio) @@ -45,6 +55,8 @@ static int can_transceiver_phy_power_off(struct phy *phy) gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 1); if (can_transceiver_phy->enable_gpio) gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 0); + if (can_transceiver_phy->mux_state) + mux_state_deselect(can_transceiver_phy->mux_state); =20 return 0; } @@ -95,6 +107,16 @@ static int can_transceiver_phy_probe(struct platform_de= vice *pdev) match =3D of_match_node(can_transceiver_phy_ids, pdev->dev.of_node); drvdata =3D match->data; =20 + if (of_property_read_bool(dev->of_node, "mux-states")) { + struct mux_state *mux_state; + + mux_state =3D devm_mux_state_get(dev, NULL); + if (IS_ERR(mux_state)) + return dev_err_probe(&pdev->dev, PTR_ERR(mux_state), + "failed to get mux\n"); + can_transceiver_phy->mux_state =3D mux_state; + } + phy =3D devm_phy_create(dev, dev->of_node, &can_transceiver_phy_ops); if (IS_ERR(phy)) { --=20 2.17.1