[PATCH] perf tools: Fix NULL vs IS_ERR_OR_NULL() checking

Miaoqian Lin posted 1 patch 3 years, 4 months ago
tools/perf/util/python.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] perf tools: Fix NULL vs IS_ERR_OR_NULL() checking
Posted by Miaoqian Lin 3 years, 4 months ago
The function trace_event__tp_format_id may return ERR_PTR(-ENOMEM).
Use IS_ERR_OR_NULL to check tp_format.

Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
 tools/perf/util/python.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c
index 563a9ba8954f..7f782a31bda3 100644
--- a/tools/perf/util/python.c
+++ b/tools/perf/util/python.c
@@ -461,7 +461,7 @@ get_tracepoint_field(struct pyrf_event *pevent, PyObject *attr_name)
 		struct tep_event *tp_format;
 
 		tp_format = trace_event__tp_format_id(evsel->core.attr.config);
-		if (!tp_format)
+		if (IS_ERR_OR_NULL(tp_format))
 			return NULL;
 
 		evsel->tp_format = tp_format;
-- 
2.17.1