From nobody Sat May 4 13:27:25 2024 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1641382272355949.0484717877772; Wed, 5 Jan 2022 03:31:12 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239703AbiAELbL (ORCPT ); Wed, 5 Jan 2022 06:31:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233838AbiAELbJ (ORCPT ); Wed, 5 Jan 2022 06:31:09 -0500 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A651AC061761; Wed, 5 Jan 2022 03:31:09 -0800 (PST) Received: by mail-pf1-x436.google.com with SMTP id t19so34933590pfg.9; Wed, 05 Jan 2022 03:31:09 -0800 (PST) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id ko19sm1356860pjb.16.2022.01.05.03.31.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jan 2022 03:31:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=66oKtQBJWcP3R2oSjIbdUHJLe2B+Ok04ztzTZ14ozJY=; b=iTjJFJ/pC1uamObrV/phXCXqspm8x8J+oUbdHjQxjmuwCGPa65S8XZf3mE/nZogJvH SMbeYB2FXkcGxwCXnXvVHadMEw5RP1PS3IuWMgxMtEtIQXq2sqZxJmeZWS2Swq3EWSfI N9eGvK365Gh4OYNPiIHizKiAIiSLhnfGmq9MvvKOxYbSy/KDbUE8E9lbiWZ6wPOeQAlJ flUOYvfn22ddSNWY541HnT2DNIjT3CGrTAJ2wXl+lDVgh/VNUIu84AnKeuPQLHdPYf1C U2MEsF42yo27vxdu0UkpocVsJR+D0e/Kz9siHJKd8Z7JndLx/oWZJSADqgPiVVG6f7+Y VyxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=66oKtQBJWcP3R2oSjIbdUHJLe2B+Ok04ztzTZ14ozJY=; b=Mrh1tQsoRt8E369jmh/hwwnZZSwmKHaBHnLEFCXeZXCE2XE5JT3AYimr2F1IXw3yB3 j/mMyLJQ6s/4M4UV3+NTt2T9MOoC3OX9hkV5WKSRK5UTIfVuXhIj4embSJGwIdxHmB3J D5aXrk7CPvcn4jeVMrKV+MhENLd4fLFSBMF2z6GxE50PnmdAilOZ0nVNq5KLG6gMbwOM hMXwEZ7O5p6bONUsWVb+2/bDfkUgXAvk8WvcZpuz/8OpNUgb0QR2c2AR8SpI29wFx03o 9aN2GqospyIRju0dO53hj/UQ4WLaMLEUJcYAfbsKbNa21vDnpw0aWKrQbg3SCgBRQzjx 67xg== X-Gm-Message-State: AOAM532m0IOrf+NHX8UKQxep6i6RGNPuKeudUinc3zWwk38dEpUi3/ZZ MiWG0woSBUMuS91h2IvF82Q= X-Google-Smtp-Source: ABdhPJyWlKRUUhbqI670/X0/OGjf06XnH1U9JnjKB4fTLiz98rI60u483wWbBAuk8N4PMMesSFV0ig== X-Received: by 2002:aa7:973d:0:b0:4ba:70f9:14a0 with SMTP id k29-20020aa7973d000000b004ba70f914a0mr55010892pfg.37.1641382269213; Wed, 05 Jan 2022 03:31:09 -0800 (PST) From: Miaoqian Lin Cc: linmq006@gmail.com, Jean-Christophe Trotin , Mauro Carvalho Chehab , Peter Griffin , Yannick Fertre , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: st-hva: Fix PM disable depth imbalance in hva_hw_probe Date: Wed, 5 Jan 2022 11:31:03 +0000 Message-Id: <20220105113104.7783-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1641382273413100003 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The pm_runtime_enable will increase power disable depth. If the probe fails, we should use pm_runtime_disable() to balance pm_runtime_enable(). Fixes: 57b2c06 ("[media] st-hva: multi-format video encoder V4L2 driver") Signed-off-by: Miaoqian Lin --- drivers/media/platform/sti/hva/hva-hw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/sti/hva/hva-hw.c b/drivers/media/platfo= rm/sti/hva/hva-hw.c index 15e8f83b1b56..bef880951921 100644 --- a/drivers/media/platform/sti/hva/hva-hw.c +++ b/drivers/media/platform/sti/hva/hva-hw.c @@ -406,7 +406,8 @@ int hva_hw_probe(struct platform_device *pdev, struct h= va_dev *hva) err_clk: if (hva->clk) clk_unprepare(hva->clk); - +disable_pm_runtime: + pm_runtime_disable(dev); return ret; } =20 --=20 2.17.1