From nobody Sun May 5 23:44:43 2024 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=none dis=none) header.from=bluerivertech.com Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1641429030736854.1445122688206; Wed, 5 Jan 2022 16:30:30 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343807AbiAFAa1 (ORCPT ); Wed, 5 Jan 2022 19:30:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343871AbiAFAaJ (ORCPT ); Wed, 5 Jan 2022 19:30:09 -0500 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82FA2C061212 for ; Wed, 5 Jan 2022 16:30:09 -0800 (PST) Received: by mail-pj1-x102b.google.com with SMTP id ie13so847759pjb.1 for ; Wed, 05 Jan 2022 16:30:09 -0800 (PST) Received: from localhost.localdomain (c-73-231-33-37.hsd1.ca.comcast.net. [73.231.33.37]) by smtp.gmail.com with ESMTPSA id x19sm162272pgi.19.2022.01.05.16.30.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jan 2022 16:30:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bluerivertech.com; s=google; h=from:to:cc:subject:date:message-id:reply-to:mime-version :content-transfer-encoding; bh=sItKhyjYiBTIjJbWyCsjJdRLFFEaR2+GFLFbvvEQQ8g=; b=sXNtGJJAQGNGLYM3ZJbRzUrX2NXrOAoLBfdN4Zp/iPp+uusm2oqybEc5NfQC0PYgQB 969nm4Al16dFnS7Wft0RHUI16jeFwBlHYSb8qqmIvNqghC7HPdYonl/mblupKnoB2B+G IEEGJKBhKx5I9IkutugK1JWF5SG9EAGZ56w/Xyb739WkGNw8CT/tzGwWBq9XWRSTeM8o oXeS3kqDTqY66tlG1Mkl4b7HpuFpAyTzIU/DNL/IifBxjlURL8dlUqIRinnQdRXFvuj+ FXRExsJkRjEkb1FkLxTIYhxVukUdVhjiP9inogL1PaCE7I86KU3lIDFbaHPQFL34fwV8 bF2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :mime-version:content-transfer-encoding; bh=sItKhyjYiBTIjJbWyCsjJdRLFFEaR2+GFLFbvvEQQ8g=; b=iU62Is0DZKhFCudHl2Be+P709ZSytCaam8zbEsMTo/g13p0jyrGZ2eHsikWgKNzymR LmgJntE9r4mcIsLN7Nf2ZXcIEL5DfG6lsmrS9IgrVe/dKWMpe1qHCINk4B27Gu3IAaw3 VeuRMeMCxGkTWVRcmF0TWUvrA1MMUSHrAxozzMPsOwV+FRzjQG7XCQAwBCV9R+UBDsDN nz8gWtrNd6ykJi3PNYaX+mivCAhazGHRNbOdDDK+sFXzNeDo0+qfPvgpedAzLmlIJSLL Qod2oZo3kfArGuY1ypt4/ELA73IDdbgGjQCsdVsUEKZ0a+w9TeeoT7m7P71vKf1NqxQ1 82hQ== X-Gm-Message-State: AOAM533Rcq7buHqcH/pIohI5HHInT+CHeOZF3GYmFJllnT++IxsqNQ0Z GqKA5mwao+jEMMB7Etjln+ceMA== X-Google-Smtp-Source: ABdhPJxTyCrS99bXEs/Aq31tycZyMFH9/2cuo3exypyaTaOHipoMZ+y1Metycy+IFqMStfXLdiR+Rg== X-Received: by 2002:a17:90b:1c91:: with SMTP id oo17mr7104592pjb.58.1641429009060; Wed, 05 Jan 2022 16:30:09 -0800 (PST) From: Brian Silverman Cc: Brian Silverman , Brian Silverman , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Jakub Kicinski , Vincent Mailhol , linux-can@vger.kernel.org (open list:CAN NETWORK DRIVERS), netdev@vger.kernel.org (open list:NETWORKING DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] can: gs_usb: Zero-initialize flags Date: Wed, 5 Jan 2022 16:29:50 -0800 Message-Id: <20220106002952.25883-1-brian.silverman@bluerivertech.com> X-Mailer: git-send-email 2.20.1 Reply-To: Brian Silverman MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1641429031955100001 Content-Type: text/plain; charset="utf-8" No information is deliberately sent here in host->device communications, but the open-source candleLight firmware echoes it back, which can result in the GS_CAN_FLAG_OVERFLOW flag being set and generating spurious ERRORFRAMEs. Signed-off-by: Brian Silverman --- drivers/net/can/usb/gs_usb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/can/usb/gs_usb.c b/drivers/net/can/usb/gs_usb.c index 1b400de00f51..cc4ad8d59bd7 100644 --- a/drivers/net/can/usb/gs_usb.c +++ b/drivers/net/can/usb/gs_usb.c @@ -507,6 +507,7 @@ static netdev_tx_t gs_can_start_xmit(struct sk_buff *sk= b, =20 hf->echo_id =3D idx; hf->channel =3D dev->channel; + hf->flags =3D 0; =20 cf =3D (struct can_frame *)skb->data; =20 base-commit: d2f38a3c6507b2520101f9a3807ed98f1bdc545a --=20 2.20.1