From nobody Sat Sep 7 23:52:24 2024 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail header.i=@ucr.edu; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=none dis=none) header.from=ucr.edu Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1643846290244409.7752509521348; Wed, 2 Feb 2022 15:58:10 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229980AbiBBX6J (ORCPT ); Wed, 2 Feb 2022 18:58:09 -0500 Received: from mx-lax3-1.ucr.edu ([169.235.156.35]:12195 "EHLO mx-lax3-1.ucr.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348185AbiBBX6G (ORCPT ); Wed, 2 Feb 2022 18:58:06 -0500 Received: from mail-pj1-f70.google.com ([209.85.216.70]) by smtp-lax3-1.ucr.edu with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 Feb 2022 15:58:06 -0800 Received: by mail-pj1-f70.google.com with SMTP id i10-20020a17090acf8a00b001b82365dbcfso556062pju.0 for ; Wed, 02 Feb 2022 15:58:06 -0800 (PST) Received: from kq.cs.ucr.edu (kq.cs.ucr.edu. [169.235.27.223]) by smtp.googlemail.com with ESMTPSA id b22sm27854781pfl.121.2022.02.02.15.58.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Feb 2022 15:58:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ucr.edu; i=@ucr.edu; q=dns/txt; s=selector3; t=1643846286; x=1675382286; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xYvx8fe8wRHtOQTQUEuPl7xZb+NEUT35cy+DHSkqPn4=; b=CPFrLbHLUEruZERJu8vJSXVoF0H0+jypGndiTU28gwejER9Y9m2iKCaU cm8CKYjsv2nBMeQmMjCyVjdwivrO3rSigtER9g07Enz+jEH1J64rWmrKo jPmVoUhvSdoS+/4eY7rU+gbARDb5n1Szj1CGVdT9S/23xWgR04ynHFEzH vyjWOIYhpX3cfszj9Rb7l6q1FscaV5bOWoNZ7VB75Dn7XPFH5AdK36fxh JbxesJxg1Yv/hYNLFfXADF2rcnoPaXGg2unJdGSQtQr3eDUlBHrRILyRg RXpB2bdj636yLhwHFkIJeOOgegaOmimy3R3tTHKM3huDzxLNoF38XPzKc Q==; X-IronPort-AV: E=Sophos;i="5.88,338,1635231600"; d="scan'208";a="102028824" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucr.edu; s=rmail; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GUOM8bvwC+la2NKqFvk2uI9Asw+K/wrTaRpdb2Kdz7U=; b=HrYsDT4AbEktOiXWlPEMn/m7e6zv2dsefdTeMC5C2hJLezPbv+I1/ftDBXrJt6Un0z GqSD3kzgEw3q1pfOdDoOgKDJvmgHKg8NIkh4s4COvIsupoE4p/b9lbZQZ4gbhXZtj7sK 4vUh0ntfzQGjCKF3AZQ0GIBqkvnKIMkIts8xw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GUOM8bvwC+la2NKqFvk2uI9Asw+K/wrTaRpdb2Kdz7U=; b=Czb0ZL/a9kwF01M/K+m1uGcYQrJMR9X9Xig7kIevNEAP3Enyi5jlLGfHCEPYBeNo3Q lNhdC4RVydHEzUbrtatAQI5YinMNw/Nxh0MElEqlvZwEmlbTyhuEnaqcqz1zQ1YC+U8H KFuD/VbeUK6IEoXrjju8EoFuwQ1wc1FSHXJ+M8fmam5HqAJCylJ3a6tvXWf/Rpm++kNJ WFjZUiBmURfYcEuB2YTzPBtcs2f7bnH3lyM8mbpWQBl1LCGgAakrWOOPzlwVV3JbdUe7 AFGM6TNHrk0NT8JM0w5rvnSiMaC9ZEip+nkIEUNBDGPX6PutilhqOoPL5D66hLsEDevF fogw== X-Gm-Message-State: AOAM530joS2svCLmQcNfR3evX89beQpcD3w/Eo5jLrcQOLp8Uo+Ep4vx R4zlJ53ttdZMwXlfI35/J42u4j7FMkrdTEFZz+LRQYUO1HFX1X68VzYiKzB9sIit+n5ncq1Jzpo g3KULklGyA2VCCw2dTKqaMoEoTg== X-Received: by 2002:a17:903:2310:: with SMTP id d16mr33430925plh.20.1643846285923; Wed, 02 Feb 2022 15:58:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJxZKL++WYDLmSn9xU1SSYz871Lo6pf/fCV7Hf709Wi2UHiygHMvfWHZxapRrgqd4vPTs3zu2w== X-Received: by 2002:a17:903:2310:: with SMTP id d16mr33430902plh.20.1643846285669; Wed, 02 Feb 2022 15:58:05 -0800 (PST) From: Yizhuo Zhai Cc: Yizhuo Zhai , Helge Deller , Daniel Vetter , Sam Ravnborg , Matthew Wilcox , Alex Deucher , Xin Tan , Xiyu Yang , Tetsuo Handa , Zhen Lei , Zheyu Ma , Guenter Roeck , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v6] fbdev: fbmem: Fix the implicit type casting Date: Wed, 2 Feb 2022 15:58:08 -0800 Message-Id: <20220202235811.1621017-1-yzhai003@ucr.edu> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZM-MESSAGEID: 1643846292741100001 Content-Type: text/plain; charset="utf-8" In function do_fb_ioctl(), the "arg" is the type of unsigned long, and in "case FBIOBLANK:" this argument is casted into an int before passig to fb_blank(). In fb_blank(), the comparision if (blank > FB_BLANK_POWERDOWN) would be bypass if the original "arg" is a large number, which is possible because it comes from the user input. Fix this by adding the check before the function call. Signed-off-by: Yizhuo Zhai --- drivers/video/fbdev/core/fbmem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fb= mem.c index 0fa7ede94fa6..13083ad8d751 100644 --- a/drivers/video/fbdev/core/fbmem.c +++ b/drivers/video/fbdev/core/fbmem.c @@ -1160,6 +1160,8 @@ static long do_fb_ioctl(struct fb_info *info, unsigne= d int cmd, ret =3D fbcon_set_con2fb_map_ioctl(argp); break; case FBIOBLANK: + if (arg > FB_BLANK_POWERDOWN) + return -EINVAL; console_lock(); lock_fb_info(info); ret =3D fb_blank(info, arg); --=20 2.25.1