From nobody Thu Mar 28 11:19:54 2024 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1643902306552304.370030762474; Thu, 3 Feb 2022 07:31:46 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351872AbiBCPbd (ORCPT ); Thu, 3 Feb 2022 10:31:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236346AbiBCPba (ORCPT ); Thu, 3 Feb 2022 10:31:30 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33281C061714; Thu, 3 Feb 2022 07:31:30 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id w11so5777542wra.4; Thu, 03 Feb 2022 07:31:30 -0800 (PST) Received: from baligh-ThinkCentre-M720q.iliad.local (freebox.vlq16.iliad.fr. [213.36.7.13]) by smtp.googlemail.com with ESMTPSA id n5sm8627250wmq.43.2022.02.03.07.31.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Feb 2022 07:31:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=qRQ95PT/Vrnz3TmgchsWQMEElvKn8TkczXxrd4JiXxg=; b=AkoM/A5rnKXsxCvCu64RpwCAa1kHe1CnXoXLu7P+imwHaVaI9eP28fg51hSaEFMOF4 +XPtzorhUV3yBmmCMxYy7eRn7+382DNo2rGvb+Fbkmd+zeq+pvWQ2ekbk1jBexZIVbcZ 5H9wxYmQj4P9dT3TqF+66PF81ZCqNeycsCVEAeNSxsSqoWFzJ5PslzH/ody6xNEO9DVa xKe1uvavMWzkVxrmnfvY9BlpN58Eo6m2hRwpsIju37UTIUipmjWEAKg5q1M0L7YthmOT uwxncGk607ESanGw5jKMLgLgMXVQehyqYk5yA7czIimEWTA734NnlDAbLubDDYW58LCU wMPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=qRQ95PT/Vrnz3TmgchsWQMEElvKn8TkczXxrd4JiXxg=; b=qXeLInK9aVSXvJPHs2nkJsI7f9x87BOdw2sGlyd2TZPHxUagbWpXUUb3dS2Io5aUG+ 23e8FLhELkTCNjLGNAwQWvLqiKBih22u2cdnVE/T/T4nxf7cTWXk1NW7IFlNym3ISucQ KVRQUpz+8DrQICcFL9VDhkf79k3+PQA+ZnuAIkZjRwvuAEUF9/HmHCFBqIlr/lgvN1mg DAeE9T+9KkPRYQhNSxDJaByh8bTY+CTY4Aji+rmyB/J1Kz1OdEKWiKAfrz7vmjvgFFZx 8vh+xvpcFaFdSoeAFKetSBUoHyaIZnrn+vb6NDk0mcBzlbGA/1kd+W6ul0fFwo5PoRUc JbPw== X-Gm-Message-State: AOAM533XTSnyHz9ll0SD+0k9H6MdJs3mrk7dEuqA+8acXVyFoz0bBQ+G auyyEuxdjZCPQ7H5yxNACdyQVPCKeg1QkQ== X-Google-Smtp-Source: ABdhPJxGJDjfwZpXdBMoGDpmAenPPoddfCUlQWcfP8GotPPMuvY6LU011UtpkpATUFXf9XHLI7i27g== X-Received: by 2002:adf:fd8b:: with SMTP id d11mr29096831wrr.606.1643902288679; Thu, 03 Feb 2022 07:31:28 -0800 (PST) From: Baligh Gasmi Cc: gasmibal@gmail.com, Johannes Berg , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org (open list:MAC80211), netdev@vger.kernel.org (open list:NETWORKING [GENERAL]), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] mac80211: remove useless ieee80211_vif_is_mesh() check Date: Thu, 3 Feb 2022 16:30:34 +0100 Message-Id: <20220203153035.198697-1-gasmibal@gmail.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1643902310183100001 Content-Type: text/plain; charset="utf-8" We check ieee80211_vif_is_mesh() at the top if() block, there's no need to check for it again. Signed-off-by: Baligh Gasmi --- net/mac80211/sta_info.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c index 537535a88990..91fbb1ee5c38 100644 --- a/net/mac80211/sta_info.c +++ b/net/mac80211/sta_info.c @@ -364,8 +364,7 @@ struct sta_info *sta_info_alloc(struct ieee80211_sub_if= _data *sdata, goto free; sta->mesh->plink_sta =3D sta; spin_lock_init(&sta->mesh->plink_lock); - if (ieee80211_vif_is_mesh(&sdata->vif) && - !sdata->u.mesh.user_mpm) + if (!sdata->u.mesh.user_mpm) timer_setup(&sta->mesh->plink_timer, mesh_plink_timer, 0); sta->mesh->nonpeer_pm =3D NL80211_MESH_POWER_ACTIVE; --=20 2.35.1