From nobody Sat May 10 05:46:26 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1619518439; cv=none; d=zohomail.com; s=zohoarc; b=BSS/bXD9mg4fPF84rFMHLTZ1EkxZz+n2V8cfejbTYjKFbeJyn02Ter9zBvhXoy+6c1WmWj/19PA3I3Gmz6zMKq2CDwC2iu43jwbCBAfHwxoNxj0mNi2gbLZpNQauIyqNcJuBB6p2zJNvWBBVb/o/LqQtQdjuK15oVyaD2xHCR2k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619518439; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Y4HbtEW1zV5dDZwbpaA+MDL4IcAxQ1flmWTbEwBwsyg=; b=HlxGKFmeKxEMlYlUZnK6TZxjLtwDjJ/oWWu5oaTKJYEWzggg+Ls3b/V7kQUydpfAY62KBGAQjPZBZFW9MM72lGYHj/raDD3haaegmMFn4h7E0KHI/uJnrgikgqGSzdNo/3mt98msrqp7ftsDUeQByVgME6QYL/e5ShaIWO2h7aU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1619518439476608.4867742518019; Tue, 27 Apr 2021 03:13:59 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235485AbhD0KOk (ORCPT ); Tue, 27 Apr 2021 06:14:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:34416 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230341AbhD0KOe (ORCPT ); Tue, 27 Apr 2021 06:14:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CBC1D6101D; Tue, 27 Apr 2021 10:13:50 +0000 (UTC) Received: by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1lbKiy-000j4p-Dl; Tue, 27 Apr 2021 12:13:48 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619518430; bh=v0N3nXsqMajMGBVdnEBF4DR9l7FpjhgT+LyWaPFGjVY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n/kz6QWyev0skRLpw2DZgDie2FWO3S8xNLHUdmf3C68v45zePcljDBMHgroqkJCpY A2DaPMJK3Rb+Nohy0CRDswgkjwHchK/lko6z7EVo5UZ/a0vAB6jLt5Lu9cUclHp4QT TmyTbDEmLbW12Cb6YaF1e6Q2d1uK/GVtRktNmpnsZil4o6yigXVKQ66vMxmw5OB2aS lZdfbF9QpFC6oHMZLGZYlzS8Y43DGF/Jz6NwXxKOV6YbA1i9nWQIr8o8LbUGtcmei2 Smzp/jVFZFNPtqu89QBpGB4JdoAZc0/RqTjXbbBUUY2TUjvtcv5kRODK6aFcpoyZ1L vOr9Y0vHTgqNg== From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , Akinobu Mita , Hans Verkuil , Matt Ranostay , Mauro Carvalho Chehab , Sakari Ailus , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v2 05/79] media: i2c: video-i2c: don't resume at remove time Date: Tue, 27 Apr 2021 12:12:32 +0200 Message-Id: <25c574a9459b43940d71e3f18942b936aae64820.1619518193.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Calling pm_runtime_get_sync() at driver's removal time is not right, as this will resume PM runtime. This is clearly not what it is desired there, since it calls pm_runtime_set_suspended() afterwards. So, just remove pm runtime get/put logic from the device removal logic. Fixes: 69d2a734c5dc ("media: video-i2c: support runtime PM") Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/video-i2c.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/i2c/video-i2c.c b/drivers/media/i2c/video-i2c.c index 0465832a4090..c9a774f4c8d2 100644 --- a/drivers/media/i2c/video-i2c.c +++ b/drivers/media/i2c/video-i2c.c @@ -893,10 +893,8 @@ static int video_i2c_remove(struct i2c_client *client) { struct video_i2c_data *data =3D i2c_get_clientdata(client); =20 - pm_runtime_get_sync(&client->dev); pm_runtime_disable(&client->dev); pm_runtime_set_suspended(&client->dev); - pm_runtime_put_noidle(&client->dev); =20 if (data->chip->set_power) data->chip->set_power(data, false); --=20 2.30.2