From nobody Sat May 10 06:27:20 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1619519321; cv=none; d=zohomail.com; s=zohoarc; b=mV53/aRyPl8Z+/txt8KdXgInvZvU+aMitBOlWF+5iL2Xa2P5KVEUMSvzhE8ctscsvztGUNrthuc0H54wL+IlB4LULDyL12mRdgdz1Kbm/6kEUYpre7eV4++AQDykwyIW/14ePMq2Q0NYJnoF2Z8jlJ+djXmk66uCyHVgZj3IXns= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619519321; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Y4HbtEW1zV5dDZwbpaA+MDL4IcAxQ1flmWTbEwBwsyg=; b=YRwu3V6/aH34C7/Q4g81C+7TJK25X3uE4yQcpQ5QfoFMDiUEDmAjWI+NKU8Dez1ZPK5Jk4RXEyt3sk4ABFDM2ucZecvVtnuo43F6W0R9kcWnJcioX/dpchepMWNPXt6dCuYXdbvihi43gdh0ZgE2KpqO5llb/OnGtPe3eVCCDhQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1619519321264384.1495383253583; Tue, 27 Apr 2021 03:28:41 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238469AbhD0K3U (ORCPT ); Tue, 27 Apr 2021 06:29:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:48192 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235545AbhD0K2E (ORCPT ); Tue, 27 Apr 2021 06:28:04 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3874E613E4; Tue, 27 Apr 2021 10:27:16 +0000 (UTC) Received: by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1lbKvv-000nzS-1M; Tue, 27 Apr 2021 12:27:11 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619519236; bh=v0N3nXsqMajMGBVdnEBF4DR9l7FpjhgT+LyWaPFGjVY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TEf7qhVehujQVV6Albr0nyFqVDACoM1pOFSNDknpUYSeLQo1k5o5iS4ZlIsro3/vb W9TlBQ8H0Eyv+qGhzZjeBPOFR9neTQrJ/cpFVgVdt+Xg8UEwVP8buY5RxkXAz+sSvC xX4kGpzAlFRoAHPmor+FmDiBI25kezRKSDxIA7ZD2zip2r+qo6JqJ82QISjANJin+p K0lND4+TZUI+yDlJhzC7Ey0o09YNEQdVhWs7i5G82W4nqm5RwzsUBby9xjUHKLUHtG WOJ9Ndlb1DoAGxvOJxpJYPfWKF3nhvAMxGD/teKpUuMQKY0DzZKlvT3GZsFszAiQOo vb7ZhXR4js0rQ== From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , Akinobu Mita , Hans Verkuil , Matt Ranostay , Mauro Carvalho Chehab , Sakari Ailus , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v3 05/79] media: i2c: video-i2c: don't resume at remove time Date: Tue, 27 Apr 2021 12:25:55 +0200 Message-Id: <2b0d9e2e11bc883f1d630d43a5a464af9279b267.1619519080.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Calling pm_runtime_get_sync() at driver's removal time is not right, as this will resume PM runtime. This is clearly not what it is desired there, since it calls pm_runtime_set_suspended() afterwards. So, just remove pm runtime get/put logic from the device removal logic. Fixes: 69d2a734c5dc ("media: video-i2c: support runtime PM") Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/video-i2c.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/i2c/video-i2c.c b/drivers/media/i2c/video-i2c.c index 0465832a4090..c9a774f4c8d2 100644 --- a/drivers/media/i2c/video-i2c.c +++ b/drivers/media/i2c/video-i2c.c @@ -893,10 +893,8 @@ static int video_i2c_remove(struct i2c_client *client) { struct video_i2c_data *data =3D i2c_get_clientdata(client); =20 - pm_runtime_get_sync(&client->dev); pm_runtime_disable(&client->dev); pm_runtime_set_suspended(&client->dev); - pm_runtime_put_noidle(&client->dev); =20 if (data->chip->set_power) data->chip->set_power(data, false); --=20 2.30.2