From nobody Sat May 10 03:25:36 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1619246866; cv=none; d=zohomail.com; s=zohoarc; b=CTROaUNZcprQdehuUleQZ+vz94VKuzXL4UcdDOJQgakHi/iGT9Dj3FjwLwFlMzIJC8BCJmM7o/UcFda1PcqN5wHlAQHYthPVWvyIixyebgD5/luD+E417oXa/LGREaySSwC8UzqFTT6t9S32PLhf9zBuCpsxwqML5L/5DoKrAxg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619246866; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UjsYSMuzLPFH4lSShxqME3l9tUnqU+P7+GCgLEzExgc=; b=R7NvZJU+yZhtB1ulevXZLUGpi4yiYzyhjw09XEBhNzJBjutHUr36faPoNp/sjKxlQx+5bTW6v/wCHST/6l9zcLPbp7h38hz+GkcUsNFCYpurXOP6EoudqM/pLEWgp37VjnWifbffAWEfsx2+4Ru4vez2q5DKRMuTYwJasqBIxAk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1619246866208456.6927995376161; Fri, 23 Apr 2021 23:47:46 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244288AbhDXGsU (ORCPT ); Sat, 24 Apr 2021 02:48:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:35962 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232714AbhDXGqN (ORCPT ); Sat, 24 Apr 2021 02:46:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5E59561628; Sat, 24 Apr 2021 06:45:33 +0000 (UTC) Received: by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1laC2l-004Jev-Jd; Sat, 24 Apr 2021 08:45:31 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619246733; bh=asptFjthmpMSH40y9mihi2F9WNWJSxY/te/hCXNd4N0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p1kFI7dNHSXKbUgS80WMhQC6LqhkxbCf1jUIwAk/BCInO9XdY17uh1tZzGG+5RGsG I+a31BBjJzYlzijfv46g/nFcAuuPmaQnKqrjQlQrMxfhAkesYKbvFZFDC/vszGKDFn 0rTLsDcs1b1LR3Uf8Y58LCFpXj06icDaMYG+f1MRPe3V7rsdvY6h462w+k8sQzejnd axVbg69mhPmjdR0+Io8erfCNUUDL7lgs3yW5MTiswR5+dLbQlaeFBM8iUarHwE2SsU xy/NS5a4F++w80OLthwDrlq/NnSIrj3TAuSfkiEON4OPTBZb5NoNNruz6MPXQD6Xwe /gmw5dQdzB0PQ== From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , Mauro Carvalho Chehab , Sakari Ailus , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH 25/78] media: i2c: ccs-core: use pm_runtime_resume_and_get() Date: Sat, 24 Apr 2021 08:44:35 +0200 Message-Id: <34da940f76da6c1d61a193409164070f47243b64.1619191723.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal wi= th usage counter") added pm_runtime_resume_and_get() in order to automatically handle dev->power.usage_count decrement on errors. Use the new API, in order to cleanup the error check logic. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/ccs/ccs-core.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-c= ore.c index 9dc3f45da3dc..1441ddcc9b35 100644 --- a/drivers/media/i2c/ccs/ccs-core.c +++ b/drivers/media/i2c/ccs/ccs-core.c @@ -1880,12 +1880,11 @@ static int ccs_pm_get_init(struct ccs_sensor *senso= r) struct i2c_client *client =3D v4l2_get_subdevdata(&sensor->src->sd); int rval; =20 - rval =3D pm_runtime_get_sync(&client->dev); - if (rval < 0) { - pm_runtime_put_noidle(&client->dev); - + rval =3D pm_runtime_resume_and_get(&client->dev); + if (rval < 0) return rval; - } else if (!rval) { + + if (!rval) { rval =3D v4l2_ctrl_handler_setup(&sensor->pixel_array-> ctrl_handler); if (rval) @@ -3089,7 +3088,7 @@ static int __maybe_unused ccs_suspend(struct device *= dev) bool streaming =3D sensor->streaming; int rval; =20 - rval =3D pm_runtime_get_sync(dev); + rval =3D pm_runtime_resume_and_get(dev); if (rval < 0) { pm_runtime_put_noidle(dev); =20 --=20 2.30.2