From nobody Sat May 10 06:25:19 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1619518737; cv=none; d=zohomail.com; s=zohoarc; b=kJyTX4/Qi9oPDPdKAdQ78QXNUFM12DII+c+Kv6BeijtgJr27o/+2c8VcuMw5jz3sMYoBaaahQ05TjUQJlo6kVR7BwZJYBQevUbEm+b1J9X7joiDyhi8ZaLAy3P+f1NEhGM/SrIouXS1cMCF4oioZgwBdQRKgzy3Y5GzqrbMq8Ug= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619518737; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Sender:Subject:To; bh=sgE3dj4dMaYUyhw2sD63gAOAxEhr9JpTC4MUmn50jX8=; b=B2Tx6kSUCiOetguyd9zGbz/o4qyuNcElzyrIDCvCTmPwM2mRgkGOJ5cz18RIPQpvi2JKSn9G99sPiySZM+ySKI7i5ului6tfNRLzfa5jKqL3vJwZVnootk6FzLX+cTkOa4WcjpbjImNSCPmtr4YJJesIAaK/wRY6mNo6puv5Sac= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1619518737600466.94757041332934; Tue, 27 Apr 2021 03:18:57 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238040AbhD0KTj (ORCPT ); Tue, 27 Apr 2021 06:19:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:35422 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235543AbhD0KPK (ORCPT ); Tue, 27 Apr 2021 06:15:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D8A3F6195B; Tue, 27 Apr 2021 10:13:53 +0000 (UTC) Received: by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1lbKj2-000j87-1H; Tue, 27 Apr 2021 12:13:52 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619518433; bh=bbBhKTio+K3X9fPKV58F4G07rHzCE6SQVXwv0W77lPM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rLTfLIbrLBJ2cw0yC6O5y1QiYTLCWZRFzgjVDZ0X6Gc+TVikcfzOmRs3otKqPy8qG FhfF3ATiNUHAIFMEFzYNruiTBKOtnZUZRDhsKozdaIxp4xGYq0s6BqJoldn5JJq9WO ku4Edmpo+xTYboLWvBrU/BU4hV6dhMhu7dm3AXRPu4ETFW9MGs8SUX78Y2IYpNlziR EOhSmH2nnhh88Mx9lzrj8OA0Hf3VoR/ssWdBA1EbspQPqMHOPl8zVe8bGQp9DisOyI SGl7KKtTUht6GLvGCyTW0/AV9zT/yEkMXaRUkzE+Gww8p7y/+To61dMr3Q7Mxx2bek CvZISc/Tm5SgQ== From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , Fabien Dessenne , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v2 73/79] media: bdisp-v4l2: use pm_runtime_resume_and_get() Date: Tue, 27 Apr 2021 12:13:40 +0200 Message-Id: <5c243195eab766e74b783e9da91224d360869635.1619518193.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal wi= th usage counter") added pm_runtime_resume_and_get() in order to automatically handle dev->power.usage_count decrement on errors. Use the new API, in order to cleanup the error check logic. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c b/drivers/media/= platform/sti/bdisp/bdisp-v4l2.c index 060ca85f64d5..85288da9d2ae 100644 --- a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c +++ b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c @@ -499,7 +499,7 @@ static int bdisp_start_streaming(struct vb2_queue *q, u= nsigned int count) { struct bdisp_ctx *ctx =3D q->drv_priv; struct vb2_v4l2_buffer *buf; - int ret =3D pm_runtime_get_sync(ctx->bdisp_dev->dev); + int ret =3D pm_runtime_resume_and_get(ctx->bdisp_dev->dev); =20 if (ret < 0) { dev_err(ctx->bdisp_dev->dev, "failed to set runtime PM\n"); @@ -1364,10 +1364,10 @@ static int bdisp_probe(struct platform_device *pdev) =20 /* Power management */ pm_runtime_enable(dev); - ret =3D pm_runtime_get_sync(dev); + ret =3D pm_runtime_resume_and_get(dev); if (ret < 0) { dev_err(dev, "failed to set PM\n"); - goto err_pm; + goto err_remove; } =20 /* Filters */ @@ -1395,6 +1395,7 @@ static int bdisp_probe(struct platform_device *pdev) bdisp_hw_free_filters(bdisp->dev); err_pm: pm_runtime_put(dev); +err_remove: bdisp_debugfs_remove(bdisp); v4l2_device_unregister(&bdisp->v4l2_dev); err_clk: --=20 2.30.2