From nobody Tue Feb 10 08:20:41 2026 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1618230074; cv=none; d=zohomail.com; s=zohoarc; b=hgnwbx6R1gxCJQPb/BZ5xZkMWmDJj/q6ZI5X2a6l5rB6PEXbwBEh+re3B2NqUklQmTYVAkvKxhviKztSpKpl4EMAKLbqaeYQuou5FFwGf+uQG/LUvHIV7zjpyRCwr0r4/XWsqEGpWynFCNftbTHAfg7ScxuL0r/LDBWX+SuTY9I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618230074; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Subject:To; bh=yqtWDF/P2rEqZ8lDgxw9NumV6DV5wLbLDgBLsyv19iQ=; b=cc6UDX0AMfO1eFHbmoRcGwaocyW2q1t9yIh9s4PmXoSMsy1q12MlYwyiAGQuZ58LabMA/e6csS1p1FzWzpbmHuB3ksUlDpXM4BT+L16AWiqnHmSJxSqF4ZfPFykGvByllXQtR7l6i+Q+Ndf4m9JLp78krOjV8CSl32U+VAsb1Po= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1618230074927890.1700833234036; Mon, 12 Apr 2021 05:21:14 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240702AbhDLMV3 (ORCPT ); Mon, 12 Apr 2021 08:21:29 -0400 Received: from mail.pr-group.ru ([178.18.215.3]:50835 "EHLO mail.pr-group.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238059AbhDLMV0 (ORCPT ); Mon, 12 Apr 2021 08:21:26 -0400 Received: from localhost.localdomain ([178.70.223.189]) (authenticated user i.bornyakov@metrotek.ru) by mail.pr-group.ru with ESMTPSA (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256 bits)); Mon, 12 Apr 2021 15:20:56 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=metrotek.ru; s=mail; h=from:subject:date:message-id:to:cc:mime-version:content-transfer-encoding: in-reply-to:references; bh=oh4kxZwGwy53nO5b07oWCLMSgMZkgNXyPwI/EEEgYp0=; b=BVAfYqIVJvmgjXBbf+qX8BJu5es9xlstzTa5zY7BQIlxWrS655ykUZvvS2z2XUKbc1Ki/6X1FU4Ei C89ZyYKYd28R5ybUAKW4L2fqX3fckwIqVSoF+psbf4PINDjtV9zm6k7UmcDzZXyL6iZln3iqUyKrpu 2Cf1YliPKss7dIIPwfaHozvRkF53b3vnQTfpG7mT7sUtg1rbjrDXExAJ6h64drmhNpnAgNaN6bjHAl ZXvliT4PjWFTcX2PoXfkv1rbKLNUWauMZ+UkWYLFwAZIZjyMoyBdqjdrWmKx4macZbPwjpiP0me2l2 Eu3Cw6v3dZNuRA+QzzWvTmWM8aVeZ+w== X-Spam-Status: No, hits=0.0 required=3.4 tests=AWL: 0.000, BAYES_00: -1.665, CUSTOM_RULE_FROM: ALLOW, TOTAL_SCORE: -1.665,autolearn=ham X-Spam-Level: X-Footer: bWV0cm90ZWsucnU= From: Ivan Bornyakov Cc: Ivan Bornyakov , system@metrotek.ru, andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 1/2] net: phy: marvell-88x2222: check that link is operational Date: Mon, 12 Apr 2021 15:16:59 +0300 Message-Id: <614b534f1661ecf1fff419e2f36eddfb0e6f066d.1618227910.git.i.bornyakov@metrotek.ru> X-Mailer: git-send-email 2.26.3 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Some SFP modules uses RX_LOS for link indication. In such cases link will be always up, even without cable connected. RX_LOS changes will trigger link_up()/link_down() upstream operations. Thus, check that SFP link is operational before actual read link status. Signed-off-by: Ivan Bornyakov --- drivers/net/phy/marvell-88x2222.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/drivers/net/phy/marvell-88x2222.c b/drivers/net/phy/marvell-88= x2222.c index eca8c2f20684..fb285ac741b2 100644 --- a/drivers/net/phy/marvell-88x2222.c +++ b/drivers/net/phy/marvell-88x2222.c @@ -51,6 +51,7 @@ struct mv2222_data { phy_interface_t line_interface; __ETHTOOL_DECLARE_LINK_MODE_MASK(supported); + bool sfp_link; }; =20 /* SFI PMA transmit enable */ @@ -148,6 +149,9 @@ static int mv2222_read_status(struct phy_device *phydev) phydev->speed =3D SPEED_UNKNOWN; phydev->duplex =3D DUPLEX_UNKNOWN; =20 + if (!priv->sfp_link) + return 0; + if (priv->line_interface =3D=3D PHY_INTERFACE_MODE_10GBASER) link =3D mv2222_read_status_10g(phydev); else @@ -446,9 +450,31 @@ static void mv2222_sfp_remove(void *upstream) linkmode_zero(priv->supported); } =20 +static void mv2222_sfp_link_up(void *upstream) +{ + struct phy_device *phydev =3D upstream; + struct mv2222_data *priv; + + priv =3D (struct mv2222_data *)phydev->priv; + + priv->sfp_link =3D true; +} + +static void mv2222_sfp_link_down(void *upstream) +{ + struct phy_device *phydev =3D upstream; + struct mv2222_data *priv; + + priv =3D (struct mv2222_data *)phydev->priv; + + priv->sfp_link =3D false; +} + static const struct sfp_upstream_ops sfp_phy_ops =3D { .module_insert =3D mv2222_sfp_insert, .module_remove =3D mv2222_sfp_remove, + .link_up =3D mv2222_sfp_link_up, + .link_down =3D mv2222_sfp_link_down, .attach =3D phy_sfp_attach, .detach =3D phy_sfp_detach, }; --=20 2.26.3