From nobody Mon Dec 15 03:19:51 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1619621662; cv=none; d=zohomail.com; s=zohoarc; b=JFPMT6Kh2psaFh3x4L0lyFEODG9iryyJREpT24r9KxLGs5+YpL4X9ZRAaj/kmxak/q7tbwNwUyn/k0FA+LoisxsQaxA9AQxOpNIS0iouF/kpxfX6a/qr8R7V7ICp0Fh/TgDTuhlI/jKB7G/xzalZoPdlmU7PoYfNZ3nucEbJx1E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619621662; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Sender:Subject:To; bh=tWU6oxk3O0XbPxS5UZj38gwI17sYWRfTMEjtpdj4j80=; b=KknCevOdC6hpCwN8BF4Ewa+v0zKLwo9Gzg/0GVMRvojJqnpN/wD9SnPyG7thScTpyzBMtpeAWNY3Fy4atoTk3DSdKBK6rQLLFCjRwAjw46kk/zkimJ2wy3+q/MJYAbLPdonoMVV/SUqxxqW+wbDsk7DhisU3T3g0ZN0wveoz7Co= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1619621662914201.31984789194746; Wed, 28 Apr 2021 07:54:22 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240410AbhD1Oxt (ORCPT ); Wed, 28 Apr 2021 10:53:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:35764 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240266AbhD1Ox3 (ORCPT ); Wed, 28 Apr 2021 10:53:29 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B947561443; Wed, 28 Apr 2021 14:52:43 +0000 (UTC) Received: by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1lblYP-001DqA-TN; Wed, 28 Apr 2021 16:52:41 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619621563; bh=WqKoYQevkaStNcKaOzNIvfyWSTMDPdaJk89Ynu0GOzk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AhluyASWRvSudbSL/CU0ekYMC1zmCrn+0YnbTPYtxfpVFanBm5Xe11SQxMkFeoqhB bUjanReRTPCuRe6bDw/qwq4S+fIr5zpAwCJI3NiSFiY7qhXkLu3f5bcRZVV0PPVm6v 3XGM5VeA0QFK010Bu5lxxX8phMSf622hHvF7G34AOGaR30XOxiKVxRWwm3hlDqVd5E 4bWF3IqZidQlbRNyOr/nTk0j8GE9A7yKFcU+ltGk5pc3QqDA+010sVBqXUsznScVn/ YrT9YUwB1XazB+WZHdKySiAKvvYDr1KUaktEVxmBN69o9S/5Zfiq54TKtOTmu3G7rb SfMU4eKWGR12A== From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , Jacopo Mondi , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: [PATCH v4 12/79] media: renesas-ceu: Properly check for PM errors Date: Wed, 28 Apr 2021 16:51:33 +0200 Message-Id: <70e2f612d1d3b7ad74fbfc5f90850f3874670fb2.1619621413.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Right now, the driver just assumes that PM runtime resume worked, but it may fail. Well, the pm_runtime_get_sync() internally increments the dev->power.usage_count without decrementing it, even on errors. So, using it is tricky. Let's replace it by the new pm_runtime_resume_and_get(), introduced by: commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal wi= th usage counter") and return an error if something bad happens. This should ensure that the PM runtime usage_count will be properly decremented if an error happens at open time. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/renesas-ceu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/renesas-ceu.c b/drivers/media/platform/= renesas-ceu.c index cd137101d41e..17f01b6e3fe0 100644 --- a/drivers/media/platform/renesas-ceu.c +++ b/drivers/media/platform/renesas-ceu.c @@ -1099,10 +1099,10 @@ static int ceu_open(struct file *file) =20 mutex_lock(&ceudev->mlock); /* Causes soft-reset and sensor power on on first open */ - pm_runtime_get_sync(ceudev->dev); + ret =3D pm_runtime_resume_and_get(ceudev->dev); mutex_unlock(&ceudev->mlock); =20 - return 0; + return ret; } =20 static int ceu_release(struct file *file) --=20 2.30.2