From nobody Tue Feb 10 16:41:17 2026 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1621350925; cv=none; d=zohomail.com; s=zohoarc; b=nHvVNFdjuaoj0+P8rp7lrEgt9pKx88ujfnnD3fP3Y2PTyhirHhiqLIq4FGvXEe9iByBLv8vkxCK5p6VtcqLR8E5xgAY2BTy4UfBkaqUkLvYZh3lojqt8VE+eBcL4+87CO+f4n2AnJHs57HeLmems/NedpDpABL4JAYGfV1x7IKU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621350925; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dvM0Oqd/+J5FEvOLxy2PQ/S/PbxZLFgb947fjD4dRhA=; b=OS8nPbWjuxnMZqVB0tqba/O/jhDcY/vvq/PRTXOVV09S5oMYruXXI/tXPzPEAXTluDeVjBWfm8YX5or1SU+3ypP08krqrz4MbH94ZKqBEoTMCt9YTOjjaO2lJTDEYwF2gvMGbzG78Z6kVjGabLFVH9xkoJaXdWUZo/EP4GVULOk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1621350925193137.63976452533393; Tue, 18 May 2021 08:15:25 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242985AbhERPMf (ORCPT ); Tue, 18 May 2021 11:12:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:49626 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344988AbhERPKe (ORCPT ); Tue, 18 May 2021 11:10:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 66FDF613AF; Tue, 18 May 2021 15:09:10 +0000 (UTC) Received: by mail.kernel.org with local (Exim 4.94.2) (envelope-from ) id 1lj1LI-007HOw-MP; Tue, 18 May 2021 17:09:08 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621350550; bh=DLdEfx6xwQIJPGQdiBgHEYPiWWkAAU8NZ8TS0QVIJfo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SHXdEkXqJRbfyeImoZNRyK3cV+2OWJTIzLCRSpmvac0YB36l64vEcf3j8IMHwMzTr rdsUkP+i/e/mc97bjaPSUQ8CCMqzes0zhdPPmsv2lrL8ns1LRVUWSf3sbWwqaerr3V 36c9twPHni0prdQ6TqwkytqFHxa9NWMt2pHLKeFqtehyczzW7jBOXWx2zK7vPZdznG emAmqCnOd4VJIzw356tuwW+Sc5Xduo9yncKW/ks1Y5vlTCXogUSvVCYvLF8EEDJcaa /U2ltWkejDiQUgsao9DuagaHyWLCjYbN+zSldjWBeUdbaRgKS5C+CwV/RcduEle03H 3x6cTZSU5Cf4w== From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , Pavel Machek , gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: [PATCH v2 16/17] leds: leds-nuc: add support for changing the ethernet type indicator Date: Tue, 18 May 2021 17:09:05 +0200 Message-Id: <792598f4a1a3219b6517057c92559b0f0a95b419.1621349814.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The Ethernet type indicator can be configured to show the status of LAN1, LAN1 or both. Add support for it. Signed-off-by: Mauro Carvalho Chehab --- drivers/leds/leds-nuc.c | 89 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 89 insertions(+) diff --git a/drivers/leds/leds-nuc.c b/drivers/leds/leds-nuc.c index 4d4ea6fbeff4..f84ec5662f5c 100644 --- a/drivers/leds/leds-nuc.c +++ b/drivers/leds/leds-nuc.c @@ -1698,12 +1698,100 @@ static ssize_t store_hdd_default(struct device *de= v, return len; } =20 +/* Ethernet type */ +static const char * const ethernet_type[] =3D { + "LAN1", + "LAN2", + "LAN1+LAN2" +}; + +static ssize_t show_ethernet_type(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct led_classdev *cdev =3D dev_get_drvdata(dev); + struct nuc_nmi_led *led =3D container_of(cdev, struct nuc_nmi_led, cdev); + u8 input[NUM_INPUT_ARGS] =3D { 0 }; + u8 output[NUM_OUTPUT_ARGS]; + int ctrl, ret, val, i, n; + int size =3D PAGE_SIZE; + char *p =3D buf; + + if (led->indicator !=3D LED_IND_ETHERNET) + return -EINVAL; + + ctrl =3D led->reg_table[led->indicator][LED_FUNC_ETH_TYPE]; + + if (!nuc_wmi_test_control(dev, led, ctrl)) + return -ENODEV; + + input[0] =3D LED_NEW_GET_CONTROL_ITEM; + input[1] =3D led->id; + input[2] =3D led->indicator; + input[3] =3D ctrl; + + ret =3D nuc_nmi_cmd(dev, LED_NEW_GET_STATUS, input, output); + if (ret) + return ret; + + val =3D output[0]; + + for (i =3D 0; i < ARRAY_SIZE(ethernet_type); i++) { + if (i =3D=3D val) + n =3D scnprintf(p, size, "[%s] ", ethernet_type[i]); + else + n =3D scnprintf(p, size, "%s ", ethernet_type[i]); + p +=3D n; + size -=3D n; + } + size -=3D scnprintf(p, size, "\n"); + + return PAGE_SIZE - size; +} + +static ssize_t store_ethernet_type(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t len) +{ + struct led_classdev *cdev =3D dev_get_drvdata(dev); + struct nuc_nmi_led *led =3D container_of(cdev, struct nuc_nmi_led, cdev); + u8 input[NUM_INPUT_ARGS] =3D { 0 }; + int ctrl, val, ret; + const char *tmp; + + if (led->indicator !=3D LED_IND_ETHERNET) + return -EINVAL; + + ctrl =3D led->reg_table[led->indicator][LED_FUNC_ETH_TYPE]; + + if (!nuc_wmi_test_control(dev, led, ctrl)) + return -ENODEV; + + for (val =3D 0; val < ARRAY_SIZE(ethernet_type); val++) + if (!strcasecmp(tmp, ethernet_type[val])) + break; + + if (val >=3D ARRAY_SIZE(ethernet_type)) + return -EINVAL; + + input[0] =3D led->id; + input[1] =3D led->indicator; + input[2] =3D ctrl; + input[3] =3D val; + + ret =3D nuc_nmi_cmd(dev, LED_SET_VALUE, input, NULL); + if (ret) + return ret; + + return len; +} =20 static LED_ATTR_RW(indicator); static LED_ATTR_RW(color); static LED_ATTR_RW(blink_behavior); static LED_ATTR_RW(blink_frequency); static LED_ATTR_RW(hdd_default); +static LED_ATTR_RW(ethernet_type); =20 LED_ATTR_POWER_STATE_RW(s0_brightness, brightness, 0); LED_ATTR_POWER_STATE_RW(s0_blink_behavior, blink_behavior, 0); @@ -1732,6 +1820,7 @@ LED_ATTR_POWER_STATE_RW(standby_blink_frequency, blin= k_frequency, 2); static struct attribute *nuc_wmi_led_attr[] =3D { &dev_attr_indicator.attr, &dev_attr_hdd_default.attr, + &dev_attr_ethernet_type.attr, NULL, }; =20 --=20 2.31.1