From nobody Sat May 10 05:55:24 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1619518672; cv=none; d=zohomail.com; s=zohoarc; b=J3n7udY/iebiIpR/U+eewI3tW+WcAoFxrPGbxvpKV1ERgOtMIBXWbivP7LFWyjWghqkwV+OHEKdI95MmrnKauD0MW6rXGxdqtxo2CL7QcuDjYEQniUpy5XdC0e9NUVjjXy+BqQPxmLuF+4MjoQzlZfEqJICqFqUTXYS87j3alvc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619518672; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6TxO13Hcq2LXkVzqJrqf06IWGakAOWK6g1rNPJ+wpFM=; b=hl5t0U0iWNk5s+fFufsnTjBO7RhQxE/G9GMKQfx6m68zXowkMMzyF/39nGg4xCzJxd/QI91tKkB2D1UPXtec3ASzdAA1hfPOzv7u1Xnc2my66M/I/kURC8dKCF/yVxVa1VdR8xpn1EP1ZRrgcA0npsG/izZbMbIyaZWJ0GwF/M4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1619518672370797.6747409838941; Tue, 27 Apr 2021 03:17:52 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235505AbhD0KSd (ORCPT ); Tue, 27 Apr 2021 06:18:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:35522 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235577AbhD0KOr (ORCPT ); Tue, 27 Apr 2021 06:14:47 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0FC1F61883; Tue, 27 Apr 2021 10:13:53 +0000 (UTC) Received: by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1lbKj1-000j7O-7G; Tue, 27 Apr 2021 12:13:51 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619518433; bh=hgVIRXIaDP3qryP6Ow1GN4bGxSo94x3BXa49gnOI5oU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cLqoAGCfIL2OxVF4O1wFYsX4vv+YDrtXpUlPSG89NjnuWXuWVfchPC9BvNe1g4nW0 d2WMATiDQbGC51S+BV1vqBiBKSkssy/SwRZge9UDOl7Lh9m3dn/8zZycicXvMCSh1K baePTv9eIiGJE5e16PRSv+b7SYKcQFJ7RFj7q6Zs8kc5Ze42Steiztc6kXJS7ujIbS USJYcXCqXjNCZBXuDDwTvz88yjMYUMJuRQ4KQYnA/Mx7U4NH4342I802FtBupvP3WQ 6rx9zSlKmgc7UEhA7nDLPoiG31ZgNqu7nMGFhbwGH7F+EX2QaPlhuAGpX7OnU/2R7P MVqMUU9c42uVw== From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , Matt Ranostay , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v2 58/79] media: i2c: video-i2c: use pm_runtime_resume_and_get() Date: Tue, 27 Apr 2021 12:13:25 +0200 Message-Id: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal wi= th usage counter") added pm_runtime_resume_and_get() in order to automatically handle dev->power.usage_count decrement on errors. Use the new API, in order to cleanup the error check logic. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/video-i2c.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/media/i2c/video-i2c.c b/drivers/media/i2c/video-i2c.c index c9a774f4c8d2..910a139c5e14 100644 --- a/drivers/media/i2c/video-i2c.c +++ b/drivers/media/i2c/video-i2c.c @@ -286,11 +286,9 @@ static int amg88xx_read(struct device *dev, enum hwmon= _sensor_types type, __le16 buf; int tmp; =20 - tmp =3D pm_runtime_get_sync(regmap_get_device(data->regmap)); - if (tmp < 0) { - pm_runtime_put_noidle(regmap_get_device(data->regmap)); + tmp =3D pm_runtime_resume_and_get(regmap_get_device(data->regmap)); + if (tmp < 0) return tmp; - } =20 tmp =3D regmap_bulk_read(data->regmap, AMG88XX_REG_TTHL, &buf, 2); pm_runtime_mark_last_busy(regmap_get_device(data->regmap)); @@ -512,11 +510,9 @@ static int start_streaming(struct vb2_queue *vq, unsig= ned int count) if (data->kthread_vid_cap) return 0; =20 - ret =3D pm_runtime_get_sync(dev); - if (ret < 0) { - pm_runtime_put_noidle(dev); + ret =3D pm_runtime_resume_and_get(dev); + if (ret < 0) goto error_del_list; - } =20 ret =3D data->chip->setup(data); if (ret) --=20 2.30.2