From nobody Tue May 7 01:15:14 2024 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1618323059; cv=none; d=zohomail.com; s=zohoarc; b=R5/9eh66Cr5IbVWB2xJxerZRcCFLc0STmMTg044b96f1+ticvEZUKRLBB7MjjI+Fik6YoOz9eOAnOA5O9C7lnwFZkvM1aBnlzs05cS5JEafSPVhnBXc8CpCF0ro7QAMvMosoMVlcdmxIiilHxl936ABRgFfNxjEFrgpogake2uY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618323059; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Subject:To; bh=5vH99A1fpuY8PmP3SpQC4JZoT0N6aqKLVm35tssstBY=; b=RzEA3lK9s7mWYeHeeEigFpQj/YgJ5/gLfzaDG/oFHSdy7sObxGbwzEe2Lp7yqw1zQjcyck8/eUBSoXsSQiFNOzwpSL85TlU3JhtZwza96cdxLUTKMXLajpR/JcFSZEx2vaKxuqSrHBO2tUJmdZfkHqI+Ilv13blXfoFhRjeA85E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1618323059413891.8085607080582; Tue, 13 Apr 2021 07:10:59 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231905AbhDMOLL (ORCPT ); Tue, 13 Apr 2021 10:11:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231317AbhDMOLI (ORCPT ); Tue, 13 Apr 2021 10:11:08 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10C30C061756 for ; Tue, 13 Apr 2021 07:10:48 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id c15so7669918wro.13 for ; Tue, 13 Apr 2021 07:10:47 -0700 (PDT) Received: from agape ([5.171.81.171]) by smtp.gmail.com with ESMTPSA id h63sm2557871wmh.13.2021.04.13.07.10.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 07:10:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5vH99A1fpuY8PmP3SpQC4JZoT0N6aqKLVm35tssstBY=; b=YyeJkG/wviaq9AXZn5iPJ2pxSoBnDP7b3oGypT2AOj0I1I5/6JBkckXNpvyK8tLtoA a+caxOgoPnKgmh0N89rwqt0CnMXF2iCGzm4yFets7UJeggn50+lxo68uVXw+i+Sz3NOX K683TGIXcTxUY0gVaQEzODVTX7cQc6zsfVUFEfmW+kUvDXPm61XeX+ew4cN3WZt7K82I ykSy71vgxBK+fs1FEeWUhfPta/5CA1A20mElqAEvTwR27czg9gyt17AFG7rTN9q0WOKj yoYwGnpank+RDJTj8GN/jyDwXECfKhiPbP3Jpb4knGkWA5f7BBRlzDA2UBvb7yqNS7VB 9qcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5vH99A1fpuY8PmP3SpQC4JZoT0N6aqKLVm35tssstBY=; b=sS6ah61yMpnROkMxEk+iyhzaZvrCiDJfAJblwXYjccGjo3XGieWLS3HZ6od5P3PKDn 9ZJS4qrmGZeKuoTxCVjjym0xOkyXGfG9Cndo2tMm6sBK2Grf4pWIcoTiA+QcN3MEb719 XmnFy3OpeS906VdOd6WD08/wiihajE0rNMWFFsV0rg/wvNvpsivngr//z+/ptr5VlwtJ gH0ijjJpnSHtDo1nfIIatyH3bCr2zcalMuwXcplZHt7+G98B1vP/EbcOBFSy68/vNIJ8 OoS+nvikef1+D3n9H6jPaiS+d4iKHuyJSQX7jXPyjyms4JF2FSCVmSMl5yTQ8R7l+xIj HhzA== X-Gm-Message-State: AOAM531I3HUKHJK17eO/CK+KxgWoN//RVoeUWWM/RouygfCRqo6wVF/X UcpcAkI8Dg9ZOAxl4bPmzYVPV5EQX/jGtA== X-Google-Smtp-Source: ABdhPJx1zFyzztrVNNrVNW9vLsorNK6xLTat/RMZw06mPIcS3fqsjJ9lquGTIohLKgujqG12NznsrA== X-Received: by 2002:a5d:4a48:: with SMTP id v8mr13339054wrs.204.1618323046572; Tue, 13 Apr 2021 07:10:46 -0700 (PDT) From: Fabio Aiuto Cc: julia.lawall@inria.fr, joe@perches.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 1/7] staging: rtl8723bs: replace dump_drv_version usage with netdev_* Date: Tue, 13 Apr 2021 16:10:36 +0200 Message-Id: <463d327e54e903b65f4700f966f0faae3c88d806.1618322367.git.fabioaiuto83@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" replace dump_drv_version() usage with netdev_dbg(). The string printed is the same contained in DBG_871X_SEL_NL macro called inside dump_drv_version(). This is just preparation before bulk DBG_871X_SEL_NL macro replacement by coccinelle. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/stagi= ng/rtl8723bs/os_dep/ioctl_linux.c index 332855103b14..98c9eb399ba7 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c @@ -2590,7 +2590,7 @@ static int rtw_dbg_port(struct net_device *dev, break; =20 case 0x10:/* driver version display */ - dump_drv_version(RTW_DBGDUMP); + netdev_dbg(dev, "%s %s\n", "rtl8723bs", DRIVERVERSION); break; case 0x11:/* dump linked status */ { --=20 2.20.1 From nobody Tue May 7 01:15:14 2024 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1618323080; cv=none; d=zohomail.com; s=zohoarc; b=jQauzSwEsLuKAhCOec5U5OUctJwMKYigdgkg8GzKtQ/ZCdxjSnnlW74qjFylabGx4FAT9qcKS4WsQutnsFNaJpFnUNR+uDnGdYtd3p1xITKRMXwla7B1+iZ2eoWpqYMFyyUa6HJXBzdylUNglCoXaYE835jMOjGjPTV5InCtdrw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618323080; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Subject:To; bh=B3rpQGWrqKW/s7QbBC9Cbbf9cXI28JVOTOSLh/yBH1M=; b=ejOt3sCkSMfxNKW/cyU9uVOr5Vlkuu18fs6y4bWtZxnFyPeGlP0h55l89AgVj/GvdlYIAWCsXS/qcTozWbVxPR7gfqTRrf/Tw/1YLgbNnNlAGTYPC55StQS9DDLOBvISRYMhEC92p+4t71VEQJVlOWii90zzPy8bp6e1M17pdnw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 16183230807581.6416478638038825; Tue, 13 Apr 2021 07:11:20 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346305AbhDMOLY (ORCPT ); Tue, 13 Apr 2021 10:11:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231838AbhDMOLK (ORCPT ); Tue, 13 Apr 2021 10:11:10 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84A3FC061574 for ; Tue, 13 Apr 2021 07:10:49 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id 12so8818499wmf.5 for ; Tue, 13 Apr 2021 07:10:49 -0700 (PDT) Received: from agape ([5.171.81.171]) by smtp.gmail.com with ESMTPSA id m17sm10525922wrq.63.2021.04.13.07.10.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 07:10:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=B3rpQGWrqKW/s7QbBC9Cbbf9cXI28JVOTOSLh/yBH1M=; b=WpsaeFL3u13gWmEF34HRreUTaIqGah8lcSrJv73ie+KZpolrAepFs+uJ3rAJeZtplQ ouH5wY3MxIFNLDfU5tyuKACVQ89g34WJ8CUPTGabCvSWam/AcV8ql8071XeEmpiCQt9X vN9j22fgrc6LhJmcHPYeSuCeOv+6G3LsejiCseJTKkJ9b+2qBIqnJNyydY5r70GDpQV2 t/zFMhqpoDIFB8J+vRI88jm4SeguNqqNQlGtTpYiEealhGp9GbrYi3wR6Gmeq7DuELHp 6fMyThnIQ+wyAFOa7BS+xM8Q4HlJLwdrGe4XPDLNl8/BnOXLS0oENXUS6SbZekb10FLN YUpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=B3rpQGWrqKW/s7QbBC9Cbbf9cXI28JVOTOSLh/yBH1M=; b=hLT4dh3+s5uBU7Abd4f68Cj09Xh3LaZyskO+chmJ6YvzmmT952YpDr/pI8a+x9CsNb KnG9mn5cFRRhhMv91tO8KsfBgpiuxOJqL/YfWIbQPv4BhZqLpfNoxTN03V0dxrAAian8 turiACi4rz1dMTv1UIg/ZdhiPBMNRUtgNQplKvPSdzSIz/iqzkv9hk3yfdZoGrLnBJPF LEfqBiwM309xbqW34v5BYd+WPf+MBsGnqI/cW7qovw4daKywnMyD8yiN66nkkc2FmV/X 31mH2WDQwd2OCnY1m2o/XjxhmB/9I3X5CQ+NBHOoYahvmLDSpYzjLwl2oq2MY9xqUgia AUfA== X-Gm-Message-State: AOAM531DgicKmQ4hFfe/N2MYANdOY6Wlsfa6eaPEz7ZjUCxAZW4RbWrP SvwOtb7XU0RWp2TGrDOmUwadwYB+At32nA== X-Google-Smtp-Source: ABdhPJyiGwnP7Q9+ErwLtyrlvYnHHdXx5Pnm8vKOiNMHvca4e6/T/Z6AIUR3ZsUeuv9hIKHbm3Sigg== X-Received: by 2002:a1c:f614:: with SMTP id w20mr226170wmc.70.1618323048095; Tue, 13 Apr 2021 07:10:48 -0700 (PDT) From: Fabio Aiuto Cc: julia.lawall@inria.fr, joe@perches.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 2/7] staging: rtl8723bs: remove unnecessary dump_drv_version() usage Date: Tue, 13 Apr 2021 16:10:37 +0200 Message-Id: X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" remove unnecessary dump_drv_version() usage. This prepares dump_drv_version() for removal and further DBG_871X_SEL_NL removal. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index a9a9631dd23c..d5ff22ebbc5c 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -491,7 +491,6 @@ static int __init rtw_drv_entry(void) int ret; =20 DBG_871X_LEVEL(_drv_always_, "module init start\n"); - dump_drv_version(RTW_DBGDUMP); #ifdef BTCOEXVERSION DBG_871X_LEVEL(_drv_always_, "rtl8723bs BT-Coex version =3D %s\n", BTCOEX= VERSION); #endif /* BTCOEXVERSION */ --=20 2.20.1 From nobody Tue May 7 01:15:14 2024 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1618323083; cv=none; d=zohomail.com; s=zohoarc; b=CAOSpcJ98jKDS7UM/Qyfb+CC46txmWjwqGBxt9Jo3UhnXsqvzVboGilA/DPFD/LRnbXH3I5U50wj/q6DaYt+njTfgKjFAob7eq7o3H//BhOBDpTG7SRmUzRLBPQ9Bv68gFzvH737QAah0UbXDA5XInohrzE+O/z0JXSQJI1RopA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618323083; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Subject:To; bh=KltcSRDP7X3Yfu3VWFhrzHyopiix35MMmWdtK3KZ1EE=; b=mu7cdQvzmSfY3zZhxDufj1om4jDqI3nntyHg8ZZZbS9uZY9tJROdxPt8YoegdUaUBayRBctcKekXOh1nI/CQ4nZ7FWj/Xow607PrVnbCXcJiXt+Ab5AUU68d6onhCfwr8+rwuLhTyTsBcOUrAfs99/N8EuI4DYfnmyZFHt0Ro6o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 161832308346264.36333872332807; Tue, 13 Apr 2021 07:11:23 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346313AbhDMOL0 (ORCPT ); Tue, 13 Apr 2021 10:11:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231910AbhDMOLM (ORCPT ); Tue, 13 Apr 2021 10:11:12 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4DCCC061574 for ; Tue, 13 Apr 2021 07:10:52 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id h4so7589831wrt.12 for ; Tue, 13 Apr 2021 07:10:52 -0700 (PDT) Received: from agape ([5.171.81.171]) by smtp.gmail.com with ESMTPSA id m15sm19392261wrp.96.2021.04.13.07.10.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 07:10:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KltcSRDP7X3Yfu3VWFhrzHyopiix35MMmWdtK3KZ1EE=; b=CRgfq8FTkXFHrs5B9IshafQuRK7Z+orJ77vQ+QoJo4K+N8ZAyL9wGghM1YsYgBeapq Cihil2w6hTs3oJKbzuL2gs1ioGaMM0RKYeMI+7XOtvbIzrGRefF5sRf3s2JU35kvkNX5 bOkI4Z6jf0o+ELdBR94AAGImgB78ThNLe5tMBVQ1Dd/ZwETXxblZXNfjMbZYWjD8jzyf ZWaYQoTJhjS2bv0bTuSnefvOu7P0kNbJx6k+sa2uI6KFGnUIy+0LcDbohJ3+yOz88NMb 6cUTWILTIVOK2wgyzHrUncqOxbHu8ih5fl8WrOt9s2RK6UmMvlBpGnYLM4A9FWqED1sN iN+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KltcSRDP7X3Yfu3VWFhrzHyopiix35MMmWdtK3KZ1EE=; b=O4h1C3cB2iyH1jS5gftOvKzRlkpzjFxSwyBYhg2O94jFyaRH1gVHrEE8mhteGqNBwk ig6trrP3IchUY8Gk8HzhOIVBBR0lYSPSEHbBNmH1pxq8Hvd0eZU/K+BNqEZelafgjxiG 5YL4kCUswiJFO828OHRCes/kHELsSs0DsqQZNGjJUBW14dvbA5iLz/0trWEySP0PYv/g EyXscUyOj5oRmKxmw1RoAFr/QDt7yatf4z1tXIrSxP5SAG33CSlYL4XqHe73QfjkeHjY lpxpDnjJeIf5jI1oEGZwzki+SyfrDE0CdgCjDYUSW1PzxqCSguRYgfNsMlhFl9o5oveZ 0hLg== X-Gm-Message-State: AOAM533adPwIupEfnHrcQbYCYL+0aXvCttYGyqMDdwV1nLrNWqwB9GZ8 Qhhf3AkBcMJRsow5LS1TzFLZzNqR0IIEDw== X-Google-Smtp-Source: ABdhPJxbByITxA1Mm1H0RKdUh+zCeKbEJVVFVdAEsWGFWd78HtlSBmBlIGoeHujOzKeRrMdNRKJV5w== X-Received: by 2002:a5d:6d0f:: with SMTP id e15mr36634018wrq.218.1618323050179; Tue, 13 Apr 2021 07:10:50 -0700 (PDT) From: Fabio Aiuto Cc: julia.lawall@inria.fr, joe@perches.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 3/7] staging: rtl8723bs: remove two unused functions Date: Tue, 13 Apr 2021 16:10:38 +0200 Message-Id: <4d241b4cbc0c081a1d31d615b5069a223b2b7e7b.1618322367.git.fabioaiuto83@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" remove dump_drv_version() and dump_log_level() function definitions and prototypes. These two functions incapsulate DBG_871X_SEL_NL macro which does a raw printk call (something to avoid in a driver). The DBG_871X_SEL_NL seq_printf usage is never triggered. So we remove dump_drv_version() which is no more used and dump_log_level() which was never used. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_debug.c | 10 ---------- drivers/staging/rtl8723bs/include/rtw_debug.h | 3 --- 2 files changed, 13 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/r= tl8723bs/core/rtw_debug.c index d3ee7b7f6fde..324c7e5248f8 100644 --- a/drivers/staging/rtl8723bs/core/rtw_debug.c +++ b/drivers/staging/rtl8723bs/core/rtw_debug.c @@ -14,16 +14,6 @@ u32 GlobalDebugLevel =3D _drv_err_; =20 #include =20 -void dump_drv_version(void *sel) -{ - DBG_871X_SEL_NL(sel, "%s %s\n", "rtl8723bs", DRIVERVERSION); -} - -void dump_log_level(void *sel) -{ - DBG_871X_SEL_NL(sel, "log_level:%d\n", GlobalDebugLevel); -} - void sd_f0_reg_dump(void *sel, struct adapter *adapter) { int i; diff --git a/drivers/staging/rtl8723bs/include/rtw_debug.h b/drivers/stagin= g/rtl8723bs/include/rtw_debug.h index 7747e90bd1cc..f1b37d511f27 100644 --- a/drivers/staging/rtl8723bs/include/rtw_debug.h +++ b/drivers/staging/rtl8723bs/include/rtw_debug.h @@ -192,9 +192,6 @@ =20 #endif /* defined(_dbgdump) */ =20 -void dump_drv_version(void *sel); -void dump_log_level(void *sel); - void sd_f0_reg_dump(void *sel, struct adapter *adapter); =20 void mac_reg_dump(void *sel, struct adapter *adapter); --=20 2.20.1 From nobody Tue May 7 01:15:14 2024 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1618323088; cv=none; d=zohomail.com; s=zohoarc; b=giHHKqAqiLTeiLLADR/6Sn8MFX02rfMouNXDiyeeJdoiBkxZ5Dkf49JjLnj+/LK+nehcekyKXo/eTbZ1O0kO/QIIX0GkvOUPxoVU39niB7mTiudRcz61S9Bx99KPmdetGeWPXJI2Gvy1h/lRKBV6/Pu4DwlY1c/Rwpj9H0DSwTM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618323088; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Subject:To; bh=jSEnliZNTsHjR6wKzUjuLn3oIHLdeYnyhs9bbaWyIUA=; b=ONZLn9QrlINE6+JRUQq4PAou+d/psDFhfcjRcCTO7mM/6b4NElFQI0oToxUaVYcXttYogcNKX35zYoW5c16ES2kk7mvipP9c0BIYLb3loLMobLQ18/tZ4MXZjEtHK6bYMFJUzFwI0RAnGtTgCsOf2wbSitCBLWzE3CIH1fr9l/c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1618323088094200.31262874246931; Tue, 13 Apr 2021 07:11:28 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346323AbhDMOL1 (ORCPT ); Tue, 13 Apr 2021 10:11:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231978AbhDMOLN (ORCPT ); Tue, 13 Apr 2021 10:11:13 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C51CC061756 for ; Tue, 13 Apr 2021 07:10:53 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id y124-20020a1c32820000b029010c93864955so10758083wmy.5 for ; Tue, 13 Apr 2021 07:10:53 -0700 (PDT) Received: from agape ([5.171.81.171]) by smtp.gmail.com with ESMTPSA id e33sm2453814wmp.43.2021.04.13.07.10.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 07:10:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jSEnliZNTsHjR6wKzUjuLn3oIHLdeYnyhs9bbaWyIUA=; b=nB0cmwNsf63cUFYyHFjtEpVDZH0Kcofnws9rf8b8M1U4/ngpQe7u7pQW4FJ7fyf6G3 PivU5CmB+mcZbCVZSgsXly9MqPS3jLdTdKRtexzrlbeIxMFBLxmQ0OJjOWmBEwmLtN5l i9SMwpxgEggVAhwHxSFt8oKpMaAMefwybg4S+/icb6TIBdjOFhRi3izp8pz3v4t4GF8W dul6ExSruQP+eB+aJihNMftnfQ0OYIpAKDeY1/3hfuiem+VsBnXJg3jUJKI1DPzEMGJE xt/g7XAExqQ4r+E8G2fEBB9HstOZnSYd6oMDwYtB9nkL97kgSXNBIC1PKxHwkHZnXHMr GEuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jSEnliZNTsHjR6wKzUjuLn3oIHLdeYnyhs9bbaWyIUA=; b=oPcfRnJrponN1VRhO65ghzLA0dIUNWAW7dhhg0oWWWE5P1YUWNYh91PS0MjZLrZzUc DuLgEvuP9rud58qFC2V+aR4JPDeVrYpbm+A8mLK0OqhZFuKouWlpTTKXKjViftohMuoL Zvj73RjWzu5XuZcIDV3KK2ROO23ZT9IU8ss+9WWELhK2KkgNYtfRPuu8xIuEoaw8i11l kFlIEVjp4naWpvTiDRK/Tx3gvIbHuTZNop5LenNSUWF+uhQJAa2zj/01WL+yAgdYqyFS jA4A79JwfgPl2w7vvkNQp1srW/p0ZeK8RtdEg86wJ28S0Jqsy1ZsRRv/xq0F8yNcnk4O 1YwA== X-Gm-Message-State: AOAM531ljDtqSGKMAP4dkMNJeAi9Qq8qBFw5ryUkXLsm6O4WVvPlJc5l hdkkk/Lbojm66kasZtBGdvSPTe7c8gYnDw== X-Google-Smtp-Source: ABdhPJzemJVhR4vIenwSVzj0/E5nwHOJqJpCXv+QjR8HaJB9oXL7zts48rK4je6UhBvqiky5YT2HMg== X-Received: by 2002:a1c:6585:: with SMTP id z127mr239025wmb.46.1618323051737; Tue, 13 Apr 2021 07:10:51 -0700 (PDT) From: Fabio Aiuto Cc: julia.lawall@inria.fr, joe@perches.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 4/7] staging: rtl8723bs: replace DBG_871X_SEL_NL with netdev_dbg() Date: Tue, 13 Apr 2021 16:10:39 +0200 Message-Id: <248f5113a2970d5f0199f12082a65f2af1164d72.1618322367.git.fabioaiuto83@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" replace DGB_871X_SEL_NL macro with netdev_dbg(). DBG_871X_SEL_NL macro expands to a raw prink call or a seq_printf if selected stream _is not_ a local debug symbol set to null. This second scenario never occurs so replace all macro usages with netdev_dbg(). This is done with the following coccinelle script: @@ expression sel; expression list args; identifier padapter; identifier func; @@ func(..., struct adapter *padapter, ...) { <... - DBG_871X_SEL_NL(sel, args); + netdev_dbg(padapter->pnetdev, args); ...> } @rule@ identifier func, context, padapter; @@ func(void *context) { ... struct adapter *padapter =3D context; ... } @@ expression sel; expression list args; identifier rule.padapter; identifier rule.func, rule.context; @@ func(void *context) { <... - DBG_871X_SEL_NL(sel, args); + netdev_dbg(padapter->pnetdev, args); ...> } @@ expression sel; expression list args; expression get_dev; identifier func, dev; @@ func(...) { ... struct net_device *dev =3D get_dev; <... - DBG_871X_SEL_NL(sel, args); + netdev_dbg(dev, args); ...> } @@ expression sel; expression list args; identifier func, dev; @@ func(struct net_device *dev) { <... - DBG_871X_SEL_NL(sel, args); + netdev_dbg(dev, args); ...> } @@ expression sel; expression list args; identifier func, dvobj; @@ func(struct dvobj_priv *dvobj) { <... - DBG_871X_SEL_NL(sel, args); + netdev_dbg(dvobj->if1->pnetdev, args); ...> } Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_debug.c | 16 +++---- drivers/staging/rtl8723bs/core/rtw_odm.c | 49 +++++++++++----------- drivers/staging/rtl8723bs/hal/hal_com.c | 31 ++++++-------- 3 files changed, 46 insertions(+), 50 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/r= tl8723bs/core/rtw_debug.c index 324c7e5248f8..79fd968bb147 100644 --- a/drivers/staging/rtl8723bs/core/rtw_debug.c +++ b/drivers/staging/rtl8723bs/core/rtw_debug.c @@ -20,7 +20,7 @@ void sd_f0_reg_dump(void *sel, struct adapter *adapter) =20 for (i =3D 0x0; i <=3D 0xff; i++) { if (i%16 =3D=3D 0) - DBG_871X_SEL_NL(sel, "0x%02x ", i); + netdev_dbg(adapter->pnetdev, "0x%02x ", i); =20 DBG_871X_SEL(sel, "%02x ", rtw_sd_f0_read8(adapter, i)); =20 @@ -35,11 +35,11 @@ void mac_reg_dump(void *sel, struct adapter *adapter) { int i, j =3D 1; =20 - DBG_871X_SEL_NL(sel, "=3D=3D=3D=3D=3D=3D=3D MAC REG =3D=3D=3D=3D=3D=3D=3D= \n"); + netdev_dbg(adapter->pnetdev, "=3D=3D=3D=3D=3D=3D=3D MAC REG =3D=3D=3D=3D= =3D=3D=3D\n"); =20 for (i =3D 0x0; i < 0x800; i +=3D 4) { if (j%4 =3D=3D 1) - DBG_871X_SEL_NL(sel, "0x%03x", i); + netdev_dbg(adapter->pnetdev, "0x%03x", i); DBG_871X_SEL(sel, " 0x%08x ", rtw_read32(adapter, i)); if ((j++)%4 =3D=3D 0) DBG_871X_SEL(sel, "\n"); @@ -50,10 +50,10 @@ void bb_reg_dump(void *sel, struct adapter *adapter) { int i, j =3D 1; =20 - DBG_871X_SEL_NL(sel, "=3D=3D=3D=3D=3D=3D=3D BB REG =3D=3D=3D=3D=3D=3D=3D\= n"); + netdev_dbg(adapter->pnetdev, "=3D=3D=3D=3D=3D=3D=3D BB REG =3D=3D=3D=3D= =3D=3D=3D\n"); for (i =3D 0x800; i < 0x1000 ; i +=3D 4) { if (j%4 =3D=3D 1) - DBG_871X_SEL_NL(sel, "0x%03x", i); + netdev_dbg(adapter->pnetdev, "0x%03x", i); DBG_871X_SEL(sel, " 0x%08x ", rtw_read32(adapter, i)); if ((j++)%4 =3D=3D 0) DBG_871X_SEL(sel, "\n"); @@ -73,14 +73,14 @@ void rf_reg_dump(void *sel, struct adapter *adapter) else path_nums =3D 2; =20 - DBG_871X_SEL_NL(sel, "=3D=3D=3D=3D=3D=3D=3D RF REG =3D=3D=3D=3D=3D=3D=3D\= n"); + netdev_dbg(adapter->pnetdev, "=3D=3D=3D=3D=3D=3D=3D RF REG =3D=3D=3D=3D= =3D=3D=3D\n"); =20 for (path =3D 0; path < path_nums; path++) { - DBG_871X_SEL_NL(sel, "RF_Path(%x)\n", path); + netdev_dbg(adapter->pnetdev, "RF_Path(%x)\n", path); for (i =3D 0; i < 0x100; i++) { value =3D rtw_hal_read_rfreg(adapter, path, i, 0xffffffff); if (j%4 =3D=3D 1) - DBG_871X_SEL_NL(sel, "0x%02x ", i); + netdev_dbg(adapter->pnetdev, "0x%02x ", i); DBG_871X_SEL(sel, " 0x%08x ", value); if ((j++)%4 =3D=3D 0) DBG_871X_SEL(sel, "\n"); diff --git a/drivers/staging/rtl8723bs/core/rtw_odm.c b/drivers/staging/rtl= 8723bs/core/rtw_odm.c index 53f7cc0444ba..084f6ae040ee 100644 --- a/drivers/staging/rtl8723bs/core/rtw_odm.c +++ b/drivers/staging/rtl8723bs/core/rtw_odm.c @@ -96,12 +96,13 @@ void rtw_odm_dbg_comp_msg(void *sel, struct adapter *ad= apter) int i; =20 rtw_hal_get_def_var(adapter, HW_DEF_ODM_DBG_FLAG, &dbg_comp); - DBG_871X_SEL_NL(sel, "odm.DebugComponents =3D 0x%016llx\n", dbg_comp); + netdev_dbg(adapter->pnetdev, "odm.DebugComponents =3D 0x%016llx\n", + dbg_comp); for (i =3D 0; i < RTW_ODM_COMP_MAX; i++) { if (odm_comp_str[i]) - DBG_871X_SEL_NL(sel, "%cBIT%-2d %s\n", - (BIT0 << i) & dbg_comp ? '+' : ' ', - i, odm_comp_str[i]); + netdev_dbg(adapter->pnetdev, "%cBIT%-2d %s\n", + (BIT0 << i) & dbg_comp ? '+' : ' ', i, + odm_comp_str[i]); } } =20 @@ -116,11 +117,11 @@ void rtw_odm_dbg_level_msg(void *sel, struct adapter = *adapter) int i; =20 rtw_hal_get_def_var(adapter, HW_DEF_ODM_DBG_LEVEL, &dbg_level); - DBG_871X_SEL_NL(sel, "odm.DebugLevel =3D %u\n", dbg_level); + netdev_dbg(adapter->pnetdev, "odm.DebugLevel =3D %u\n", dbg_level); for (i =3D 0; i < RTW_ODM_DBG_LEVEL_NUM; i++) { if (odm_dbg_level_str[i]) - DBG_871X_SEL_NL(sel, "%u %s\n", - i, odm_dbg_level_str[i]); + netdev_dbg(adapter->pnetdev, "%u %s\n", i, + odm_dbg_level_str[i]); } } =20 @@ -135,12 +136,12 @@ void rtw_odm_ability_msg(void *sel, struct adapter *a= dapter) int i; =20 rtw_hal_get_hwreg(adapter, HW_VAR_DM_FLAG, (u8 *)&ability); - DBG_871X_SEL_NL(sel, "odm.SupportAbility =3D 0x%08x\n", ability); + netdev_dbg(adapter->pnetdev, "odm.SupportAbility =3D 0x%08x\n", ability); for (i =3D 0; i < RTW_ODM_ABILITY_MAX; i++) { if (odm_ability_str[i]) - DBG_871X_SEL_NL(sel, "%cBIT%-2d %s\n", - (BIT0 << i) & ability ? '+' : ' ', i, - odm_ability_str[i]); + netdev_dbg(adapter->pnetdev, "%cBIT%-2d %s\n", + (BIT0 << i) & ability ? '+' : ' ', i, + odm_ability_str[i]); } } =20 @@ -154,17 +155,16 @@ void rtw_odm_adaptivity_parm_msg(void *sel, struct ad= apter *adapter) struct hal_com_data *pHalData =3D GET_HAL_DATA(adapter); struct dm_odm_t *odm =3D &pHalData->odmpriv; =20 - DBG_871X_SEL_NL(sel, "%10s %16s %8s %10s %11s %14s\n", - "TH_L2H_ini", "TH_EDCCA_HL_diff", "IGI_Base", - "ForceEDCCA", "AdapEn_RSSI", "IGI_LowerBound"); - DBG_871X_SEL_NL(sel, "0x%-8x %-16d 0x%-6x %-10d %-11u %-14u\n", - (u8)odm->TH_L2H_ini, - odm->TH_EDCCA_HL_diff, - odm->IGI_Base, - odm->ForceEDCCA, - odm->AdapEn_RSSI, - odm->IGI_LowerBound - ); + netdev_dbg(adapter->pnetdev, "%10s %16s %8s %10s %11s %14s\n", + "TH_L2H_ini", "TH_EDCCA_HL_diff", "IGI_Base", "ForceEDCCA", + "AdapEn_RSSI", "IGI_LowerBound");netdev_dbg(adapter->pnetdev, + "0x%-8x %-16d 0x%-6x %-10d %-11u %-14u\n", + (u8)odm->TH_L2H_ini, + odm->TH_EDCCA_HL_diff, + odm->IGI_Base, + odm->ForceEDCCA, + odm->AdapEn_RSSI, + odm->IGI_LowerBound); } =20 void rtw_odm_adaptivity_parm_set(struct adapter *adapter, s8 TH_L2H_ini, @@ -188,6 +188,7 @@ void rtw_odm_get_perpkt_rssi(void *sel, struct adapter = *adapter) struct hal_com_data *hal_data =3D GET_HAL_DATA(adapter); struct dm_odm_t *odm =3D &hal_data->odmpriv; =20 - DBG_871X_SEL_NL(sel, "RxRate =3D %s, RSSI_A =3D %d(%%), RSSI_B =3D %d(%%)= \n", - HDATA_RATE(odm->RxRate), odm->RSSI_A, odm->RSSI_B); + netdev_dbg(adapter->pnetdev, + "RxRate =3D %s, RSSI_A =3D %d(%%), RSSI_B =3D %d(%%)\n", + HDATA_RATE(odm->RxRate), odm->RSSI_A, odm->RSSI_B); } diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index 4cceb3a969a8..2e2d40469a83 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -1522,12 +1522,10 @@ void rtw_get_raw_rssi_info(void *sel, struct adapte= r *padapter) struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); struct rx_raw_rssi *psample_pkt_rssi =3D &padapter->recvpriv.raw_rssi_inf= o; =20 - DBG_871X_SEL_NL( - sel, - "RxRate =3D %s, PWDBALL =3D %d(%%), rx_pwr_all =3D %d(dBm)\n", - HDATA_RATE(psample_pkt_rssi->data_rate), - psample_pkt_rssi->pwdball, psample_pkt_rssi->pwr_all - ); + netdev_dbg(padapter->pnetdev, + "RxRate =3D %s, PWDBALL =3D %d(%%), rx_pwr_all =3D %d(dBm)\n", + HDATA_RATE(psample_pkt_rssi->data_rate), + psample_pkt_rssi->pwdball, psample_pkt_rssi->pwr_all); =20 isCCKrate =3D psample_pkt_rssi->data_rate <=3D DESC_RATE11M; =20 @@ -1535,20 +1533,17 @@ void rtw_get_raw_rssi_info(void *sel, struct adapte= r *padapter) psample_pkt_rssi->mimo_signal_strength[0] =3D psample_pkt_rssi->pwdball; =20 for (rf_path =3D 0; rf_path < pHalData->NumTotalRFPath; rf_path++) { - DBG_871X_SEL_NL( - sel, - "RF_PATH_%d =3D>signal_strength:%d(%%), signal_quality:%d(%%)\n", - rf_path, psample_pkt_rssi->mimo_signal_strength[rf_path], - psample_pkt_rssi->mimo_signal_quality[rf_path] - ); + netdev_dbg(padapter->pnetdev, + "RF_PATH_%d =3D>signal_strength:%d(%%), signal_quality:%d(%%)\n", + rf_path, + psample_pkt_rssi->mimo_signal_strength[rf_path], + psample_pkt_rssi->mimo_signal_quality[rf_path]); =20 if (!isCCKrate) { - DBG_871X_SEL_NL( - sel, - "\trx_ofdm_pwr:%d(dBm), rx_ofdm_snr:%d(dB)\n", - psample_pkt_rssi->ofdm_pwr[rf_path], - psample_pkt_rssi->ofdm_snr[rf_path] - ); + netdev_dbg(padapter->pnetdev, + "\trx_ofdm_pwr:%d(dBm), rx_ofdm_snr:%d(dB)\n", + psample_pkt_rssi->ofdm_pwr[rf_path], + psample_pkt_rssi->ofdm_snr[rf_path]); } } } --=20 2.20.1 From nobody Tue May 7 01:15:14 2024 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1618323092; cv=none; d=zohomail.com; s=zohoarc; b=HDZEXDmdHuk+E3NVcDj0TZcl8usow4hahGQ7KVxmugZoEygQ4GMje6ZQ/KlEySo+OGhQH+4ahR7yZP1SWQ14smWuLy4Pt90uWPRoqO4SzQ7nC/u4M4fAusyCnHhOFzMxNeQC+VLtIZPMdhqo33x8x5EKtjJ12gClMMZD6tdNyN0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618323092; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Subject:To; bh=uXx9LUIjVsmXNCgsOPYQWPc+fsuv7zkfU+hMAJWj5xE=; b=f6AnkrRuiON8JfujGY0UBRru5uVIesCsYJihod31Frw+iIqVU+iAdtzW3Lmx1BVyHhm5FCy1siUvyLDOuXJUDz1oasgdJ6LIc1CO5A/raAY5yab9rwKwnukfj5U+/Exrm1qCrUp/rs0xdx5u3t9gByxZNML85mO5aT1nfAgQBuQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1618323092486343.64151279849614; Tue, 13 Apr 2021 07:11:32 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346332AbhDMOLb (ORCPT ); Tue, 13 Apr 2021 10:11:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346265AbhDMOLP (ORCPT ); Tue, 13 Apr 2021 10:11:15 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B8BBC061574 for ; Tue, 13 Apr 2021 07:10:55 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id k26so204801wrc.8 for ; Tue, 13 Apr 2021 07:10:55 -0700 (PDT) Received: from agape ([5.171.81.171]) by smtp.gmail.com with ESMTPSA id n2sm3115865wmb.32.2021.04.13.07.10.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 07:10:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uXx9LUIjVsmXNCgsOPYQWPc+fsuv7zkfU+hMAJWj5xE=; b=Xn3p3r977PS4h0KsOTaf5zXgkYdGHCsrVtwKoY4xz1Gq18hveixZLRoXPEkdvvEQw1 PVIzRFY/lROV5qJREmDIhsmkwEiJkWGzNMTGFyIUXq2er3QTVOEmifBO42suR4WReE+b T2xoldIdhthDIEvjwxRgx67CxSKX4P1mz/WU1FprlFZprDRsgDjaMYWwYR4dcfhyQEZr wIwzPN192GUeNn07V4X4Ul49NXjIWeT6U4hlMZ3NMVVJ5ImLom5IDlRFQwx6OyHvKi1E dxhhPiGjPHCmFtrC1u1R8BhBCpyOd2Z+8ap+kNy9l/t6G4Z7f0p2BQ4cOOND24+72HGV //Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uXx9LUIjVsmXNCgsOPYQWPc+fsuv7zkfU+hMAJWj5xE=; b=LvnpMDRxzbowhQzTnmCH2FXgyK/hU0qZKgzIttMbFWfmWj0w/DflEfgK/7qT8D1LKq KwCfUTeFZaNtnUhthUq+DFo/uClUXjyT23dSBZCeVn6JvqhxOtYmarX8zxJdxipJ3+ti CrV/y82KOKHtrZ+h/fLcnaNBJbx1AOkmnkUvPB9+GavyBHrhjl+/do+p/83Y6kv8+ZSx AZ1KDaNEuKTPW6FASwtCkgzBLWctWjG8T1831tU2eQ2PElb9iQ554OcRmfGUl15ImTJ1 6VKeuE8BsB6JKOXHCQ9ojsQf4Csx56xHefbqtpTmA8YrIvj/cqkQQU+8Fd+UoMTJ+FPN A3EA== X-Gm-Message-State: AOAM53324aJhEchBiO3oeXGVoJ+rlXmnH1J/QKCEliIoVzN0j5HiDA83 J44w8xQ/1RSOxHzr8HDsvcXf5qXhDWHgYQ== X-Google-Smtp-Source: ABdhPJzuo31nctLBPDq3bIIbrfjlIWxWew+kmiyvGSk4vEyjOwb9ZhCiTY8KDnB0i6iMFJrRtDAhig== X-Received: by 2002:adf:e608:: with SMTP id p8mr20379184wrm.249.1618323053681; Tue, 13 Apr 2021 07:10:53 -0700 (PDT) From: Fabio Aiuto Cc: julia.lawall@inria.fr, joe@perches.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 5/7] staging: rtl8723bs: put a new line after ';' Date: Tue, 13 Apr 2021 16:10:40 +0200 Message-Id: <686dff07c78a1be994c56083a4640d1b66a1f34e.1618322367.git.fabioaiuto83@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" fix the following post commit hook checkpatch issue: ERROR: space required after that ';' (ctx:VxV) 232: FILE: drivers/staging/rtl8723bs/core/rtw_odm.c:160: + "AdapEn_RSSI", "IGI_LowerBound");netdev_dbg (adapter->pnetdev, This was coccinelle script output coding style issue. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_odm.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_odm.c b/drivers/staging/rtl= 8723bs/core/rtw_odm.c index 084f6ae040ee..f4a0ef428564 100644 --- a/drivers/staging/rtl8723bs/core/rtw_odm.c +++ b/drivers/staging/rtl8723bs/core/rtw_odm.c @@ -157,14 +157,15 @@ void rtw_odm_adaptivity_parm_msg(void *sel, struct ad= apter *adapter) =20 netdev_dbg(adapter->pnetdev, "%10s %16s %8s %10s %11s %14s\n", "TH_L2H_ini", "TH_EDCCA_HL_diff", "IGI_Base", "ForceEDCCA", - "AdapEn_RSSI", "IGI_LowerBound");netdev_dbg(adapter->pnetdev, - "0x%-8x %-16d 0x%-6x %-10d %-11u %-14u\n", - (u8)odm->TH_L2H_ini, - odm->TH_EDCCA_HL_diff, - odm->IGI_Base, - odm->ForceEDCCA, - odm->AdapEn_RSSI, - odm->IGI_LowerBound); + "AdapEn_RSSI", "IGI_LowerBound"); + netdev_dbg(adapter->pnetdev, + "0x%-8x %-16d 0x%-6x %-10d %-11u %-14u\n", + (u8)odm->TH_L2H_ini, + odm->TH_EDCCA_HL_diff, + odm->IGI_Base, + odm->ForceEDCCA, + odm->AdapEn_RSSI, + odm->IGI_LowerBound); } =20 void rtw_odm_adaptivity_parm_set(struct adapter *adapter, s8 TH_L2H_ini, --=20 2.20.1 From nobody Tue May 7 01:15:14 2024 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1618323094; cv=none; d=zohomail.com; s=zohoarc; b=gxGkFnTIicCPZbW69HPTDk6sLOYJL5NcMY2dkiChgz55JndHWZX0zbV8hLsn9HXwNGO8mEidkpdUmADFcXKq4pCzLKdM4nMpVY7ughvGBp76fYi0xYykK4nVLX1sptAwZe/i7xJD6IfGxEmJWzVesb3vRc/b+tjiPdigU6mtKPY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618323094; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Subject:To; bh=AzC9o1o0ixYi6KaDWY1ROlCOIjizjCzFaIisDwi93jA=; b=ZXWmVd51sN/y/Z82ig6Q/HDC1sqVSG+qfT0fPIBI2Dv+7iXEZWziTzrDXITfzlsIh5r7Cau+Z+0APxBqam5LdtkjyKxO0FPaRy0g6EKgMKG9znCeXRgLw71NfxhLWlUd5SSk0LC4cKRfummclWaFV8AMGnBMRb1//gyFfns4X5A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1618323094370707.7221343819326; Tue, 13 Apr 2021 07:11:34 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346341AbhDMOLd (ORCPT ); Tue, 13 Apr 2021 10:11:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346280AbhDMOLR (ORCPT ); Tue, 13 Apr 2021 10:11:17 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0501C061756 for ; Tue, 13 Apr 2021 07:10:56 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id c15so7670376wro.13 for ; Tue, 13 Apr 2021 07:10:56 -0700 (PDT) Received: from agape ([5.171.81.171]) by smtp.gmail.com with ESMTPSA id t20sm2484713wmi.35.2021.04.13.07.10.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 07:10:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AzC9o1o0ixYi6KaDWY1ROlCOIjizjCzFaIisDwi93jA=; b=AjqC7NnTumKdnkqksajoC/+27I/jmvb7CpNcND4yph3S5YRl6lbeHqJGwfRnWlkg0J n7TLfUoFQgxmk0b11WnhKOA/rl3FFraAdVB/5ODdBanIC3Q15Cigisng0l9zyfmzHAn3 EQnlzex9vvupi7kYneX2grW6QNVldg7a8HOPygECvDQ2LCwYJVTF6bu20KNWom2XVhO9 WW3cdIXWRoVLZ30HrBM0jJ6IE/VXHDxHMnclcJFva1I6V1pF4CFj0lX9uOY+4kNtX8bj hZ+PzamVXRcblDa8cjFroUsfo0G5jiMbPN04eI/qcrQ4eIJw8/7QBEoBJcNp7a5Bu29D f3Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AzC9o1o0ixYi6KaDWY1ROlCOIjizjCzFaIisDwi93jA=; b=N1U7UV+SnwVFex163g/F0EbOcN8pVPX1FCXgUJw8mJYu4D3cNqRmoTz59+oTcagbAO CfnFw7MytLz2YuORq/l+rORHDPuWnTWoRtXVF9+6ZjZ8E+R8irTR7KJ1rcamVp6v2oAL a24AyWLEdtVbX1AldvTb2X5CJ30Vf7Rh/YxP2DhdKoYw51psTbUARqbIzZDwyotdJbaF l6XmQGBbAmLc34+qYO6L12MMATCjFTDzhvNxr7nIPUty+yW07GLGmfSiVJEjl7aQYs4b qPpJGPzWLJ2SvdYfTeQhvbFdI8BH7G9ltlcbDvbOV5UgPTr5EkJaqRg25Ohu7eQnWtRG 1D2w== X-Gm-Message-State: AOAM532/1SNYObGK0LkZ+1LlnQ1gPCwtbCPBjkeMfsSBderM7/AiCnHB rZO6e/4NIOxUoRde0d07Ek9Qm1JKDVr0/A== X-Google-Smtp-Source: ABdhPJwh491G5m7V9l1l4klrj8KgHm55jZ0xL2TlOTb8oMz+Bl5QvQlPr1gBzfZRjF7CKIj2EgH/fQ== X-Received: by 2002:adf:f844:: with SMTP id d4mr19224032wrq.203.1618323055321; Tue, 13 Apr 2021 07:10:55 -0700 (PDT) From: Fabio Aiuto Cc: julia.lawall@inria.fr, joe@perches.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 6/7] staging: rtl8723bs: remove DBG_871X_SEL_NL macro declaration Date: Tue, 13 Apr 2021 16:10:41 +0200 Message-Id: <412587ee7cc21572b68af564dc58f738aee2338d.1618322367.git.fabioaiuto83@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" remove DBG_871X_SEL_NL obsolete macro declaration. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/rtw_debug.h | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/rtw_debug.h b/drivers/stagin= g/rtl8723bs/include/rtw_debug.h index f1b37d511f27..12873c3d801d 100644 --- a/drivers/staging/rtl8723bs/include/rtw_debug.h +++ b/drivers/staging/rtl8723bs/include/rtw_debug.h @@ -181,15 +181,6 @@ seq_printf(sel, fmt, ##arg); \ } while (0) =20 -/* dump message to selected 'stream' with driver-defined prefix */ -#define DBG_871X_SEL_NL(sel, fmt, arg...) \ - do { \ - if (sel =3D=3D RTW_DBGDUMP) \ - DBG_871X_LEVEL(_drv_always_, fmt, ##arg); \ - else \ - seq_printf(sel, fmt, ##arg); \ - } while (0) - #endif /* defined(_dbgdump) */ =20 void sd_f0_reg_dump(void *sel, struct adapter *adapter); --=20 2.20.1 From nobody Tue May 7 01:15:14 2024 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1618323099; cv=none; d=zohomail.com; s=zohoarc; b=ggnUdE6v7cbT/Qc2to1DQoqVidtDm9jNHmoVRZvhRgbQMug9Hh+eFhe7L1BqbgpkVWYRQDRk9+1zr2q2yVeOmHQNSXuMkOO26WhAjGK1wCd/0PV7LZsPjF0n7oGqhBbpnEjLlfZANQR5vn0/VQ0vZMrBnJS+JlC/s0F90vEOr2Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618323099; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Subject:To; bh=ZHxXKOLbXXf4jCbvUXo0q9HvS5LSluPLIgJqE3tNdY0=; b=Oa3tJo7AiqZaskd3g28YkjU179N4t4A2cbEAQ7qwecUT3gUO7zkgQkcYAHEg7sk1HVvjKlpP9j+VuY0eXOFFDOSR3ohSMEAGMERyRPbbRqB4WxqrKhTPRTVIeoTj23gTaAE+T0XsmGoZmQjfFTLW8s0vpkAp5G2Q0QPyTpZr7ZE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1618323099887963.2716833860203; Tue, 13 Apr 2021 07:11:39 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346355AbhDMOLh (ORCPT ); Tue, 13 Apr 2021 10:11:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346287AbhDMOLU (ORCPT ); Tue, 13 Apr 2021 10:11:20 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C64E1C061574 for ; Tue, 13 Apr 2021 07:10:59 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id a4so16637086wrr.2 for ; Tue, 13 Apr 2021 07:10:59 -0700 (PDT) Received: from agape ([5.171.81.171]) by smtp.gmail.com with ESMTPSA id s83sm2610974wms.16.2021.04.13.07.10.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 07:10:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZHxXKOLbXXf4jCbvUXo0q9HvS5LSluPLIgJqE3tNdY0=; b=StmWosAqmPvyTpA5E50Wou71XRa8HdKzDscM5ABNr55qfv8aEjc2BPOffT9X2amJhb sgBJCLuHUVVf9QQ76RbD6uBdoAllOKyWok59IPUrnqz35qpESAQbs15fbeKxdCrrmAlE +aaqvtWdoPzfAP9zh5pa+z9x+ERvylFuTGozBccJt+5pY/K8yLfqB0p51hK5gYVtUc2R 9Lqu9rphDH4blILBRJa00Ska+1Q4wbRMLEmQ/mekNv1cglMpcbRQ9kL4E0xx1ExPZcGP 5j7rSUJ+O14RGpKVBKpgH/QQmrQKi6drlJU6aL2DMBqskajrBaPJep1JIcq8+iKW5YKG lwfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZHxXKOLbXXf4jCbvUXo0q9HvS5LSluPLIgJqE3tNdY0=; b=jtKUBdn61TaR42WdcpH1IzB+u62Uytoj1dxbYEULIXZBeNXKXVF+NdKUdP17/AFDTx I39drPWtE5QNBVpCgjK472P34b2OiwGA7BrnpPDKGnC6UX29oOHjj9ZlmT5u198dNqox cI+J2no3O4m7fLO8KvKdTROe53py1b424/vRVKSzq8TuVrh1kqigtGFluGVPJWztKHN5 yopaYCMQPx2lmYVg/HjHi0vgtnIkBFbUMQShTbBxYze3aGKFRCWXFuE0ddiKkaw+A4pf RmZyoyec+XLPIOifGbOQdc+Gn5tZi7PBHAIAHNIekmJEQoGlyvbz5K1wIbWKVPA4xMyq XoZQ== X-Gm-Message-State: AOAM533mCvXUMQKXbhFAZ5JN9c6AvlnFYvguY85RsI3btHk1IilaAySi pQKiWaag2mN2uVDXzHVu+63cgb6yXsdMuQ== X-Google-Smtp-Source: ABdhPJyZ3r7quLihI/5dLMrLQxHkuI1Sn0dinWQuzqJuxaHf6fgOZMim1uOtoBdV0940OBObvuyojA== X-Received: by 2002:adf:fb0e:: with SMTP id c14mr38174219wrr.140.1618323056943; Tue, 13 Apr 2021 07:10:56 -0700 (PDT) From: Fabio Aiuto Cc: julia.lawall@inria.fr, joe@perches.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 7/7] staging: rtl8723bs: remove unused argument in function Date: Tue, 13 Apr 2021 16:10:42 +0200 Message-Id: X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" removed unused 'void *sel' argument in rtw_odm_dbg_comp_msg() function, after DBG_871X_SEL_NL replacement. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_odm.c | 2 +- drivers/staging/rtl8723bs/include/rtw_odm.h | 2 +- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_odm.c b/drivers/staging/rtl= 8723bs/core/rtw_odm.c index f4a0ef428564..f6b73a2a0270 100644 --- a/drivers/staging/rtl8723bs/core/rtw_odm.c +++ b/drivers/staging/rtl8723bs/core/rtw_odm.c @@ -90,7 +90,7 @@ static const char * const odm_dbg_level_str[] =3D { =20 #define RTW_ODM_DBG_LEVEL_NUM 6 =20 -void rtw_odm_dbg_comp_msg(void *sel, struct adapter *adapter) +void rtw_odm_dbg_comp_msg(struct adapter *adapter) { u64 dbg_comp; int i; diff --git a/drivers/staging/rtl8723bs/include/rtw_odm.h b/drivers/staging/= rtl8723bs/include/rtw_odm.h index 263e92cfea96..94fc68a5c424 100644 --- a/drivers/staging/rtl8723bs/include/rtw_odm.h +++ b/drivers/staging/rtl8723bs/include/rtw_odm.h @@ -13,7 +13,7 @@ * This file provides utilities/wrappers for rtw driver to use ODM */ =20 -void rtw_odm_dbg_comp_msg(void *sel, struct adapter *adapter); +void rtw_odm_dbg_comp_msg(struct adapter *adapter); void rtw_odm_dbg_comp_set(struct adapter *adapter, u64 comps); void rtw_odm_dbg_level_msg(void *sel, struct adapter *adapter); void rtw_odm_dbg_level_set(struct adapter *adapter, u32 level); diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/stagi= ng/rtl8723bs/os_dep/ioctl_linux.c index 98c9eb399ba7..816033b6847c 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c @@ -2622,7 +2622,7 @@ static int rtw_dbg_port(struct net_device *dev, case 0x16: { if (arg =3D=3D 0xff) { - rtw_odm_dbg_comp_msg(RTW_DBGDUMP, padapter); + rtw_odm_dbg_comp_msg(padapter); } else { u64 dbg_comp =3D (u64)extra_arg; rtw_odm_dbg_comp_set(padapter, dbg_comp); --=20 2.20.1