From nobody Sat May 11 20:59:39 2024 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1622646346; cv=none; d=zohomail.com; s=zohoarc; b=Imm6RwOEBNkeYH7suTgmrUMgMbXypiPrisZp5MRDcozkJJbR0FPwPqPgk1uHm8/aGgn0BraWi3LEy/gWskSipoEtsanQ2jzgzvmDN23pOdjVxhFrW8ZvH2aArcCpK2cpkOOsHGSUfuuJb302NjmMWNAVypjaLFR/M0/3hpx5Yts= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622646346; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Sender:Subject:To; bh=99bWEcwXbLfFcU9ASgbtxwVmu9OyHMnhfEkScCjmerc=; b=fbWmTmE89sfGdBcABxZlqv/jbif68GlEgYl3vGbL/I4590rc7rwwVof5QwClfiJqT7csodpjqycMJS/e7XRUq7pDYyabPKTx0kSyRKHYe3VupZX6xdwZwKAUWzs9+Gk9Zw6+5ggIVlpSh+NRCwscokIIEpC/tyZPwQNv0/PVvgo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1622646346740397.2829575680287; Wed, 2 Jun 2021 08:05:46 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232143AbhFBPH1 (ORCPT ); Wed, 2 Jun 2021 11:07:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:37154 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231222AbhFBPHK (ORCPT ); Wed, 2 Jun 2021 11:07:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EF42A613DC; Wed, 2 Jun 2021 15:05:26 +0000 (UTC) Received: by mail.kernel.org with local (Exim 4.94.2) (envelope-from ) id 1loSQu-006Wab-On; Wed, 02 Jun 2021 17:05:24 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622646327; bh=VcUDzLBpUXY5w7/LYOXYcxyvTx01ee92Vnvy8qVnODQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=puvJ1OCMuD6zuTdAvfzr+bSGjb9RO1Ro86mtJ8F3R4nAi53e35OGbfiUwOFeQLkV2 RtquLnYsDzjLea6jfh8X+JjwGHhlvvZ0ilB014Qe01co67oJzy17bxVw/uh22s0FyD sUtN5J6T7BbvPsp0uKoWQW1ZC+LpaSQtxNbIvpO5PX/OSBUHdgfIZiKETrKwLRAxW4 7GV6hZQ7CV8a7qZezRCQK0AU3KG/PAGMJSBIdrmgtsY9vGfe1K3ATrsgx0cp9mVvMc /P3BbQDPUUOedvs/l3j/OjUWI3hu1ApwyFXu3R59fUfvSM2mr9qwoVZp2UmGUUvLRK uftohUaBfTHiw== From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , "Gustavo A. R. Silva" , Hans Verkuil , Mauro Carvalho Chehab , Sakari Ailus , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH 1/6] media: gspca: ov519: replace RIGHT SINGLE QUOTATION MARK Date: Wed, 2 Jun 2021 17:05:18 +0200 Message-Id: <81641fb8f0ed60ccaf9f9291e4ac1d238140bc4a.1622646256.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Replace the occurences of the following character: - U+2019 ('=E2=80=99'): RIGHT SINGLE QUOTATION MARK By a normal single comma character. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/gspca/ov519.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/gspca/ov519.c b/drivers/media/usb/gspca/ov51= 9.c index cd6776c3163b..bffa94e76da5 100644 --- a/drivers/media/usb/gspca/ov519.c +++ b/drivers/media/usb/gspca/ov519.c @@ -614,7 +614,7 @@ static const struct ov_i2c_regvals norm_3620b[] =3D { /* * From the datasheet: "Note that after writing to register COMH * (0x12) to change the sensor mode, registers related to the - * sensor=E2=80=99s cropping window will be reset back to their default + * sensor's cropping window will be reset back to their default * values." * * "wait 4096 external clock ... to make sure the sensor is --=20 2.31.1 From nobody Sat May 11 20:59:39 2024 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1622646349; cv=none; d=zohomail.com; s=zohoarc; b=TcJEHRHdR/Y7/x1RVg5tFf5othRMuuPmtnSYfWXTXobaB1Lg9QqmJui9Qp9jhntc+1H3QzoCSyfvvUfdvTYrj6w7ZsxJdNoRaIK6bJFHbLFYfkIE2gLwU1BWSTVU6mUKgRH7VL4TqxA6kYgftl1MS1d+CCqSMnD95TR2ijdD4XY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622646349; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Sender:Subject:To; bh=431X4ojgbqvseeP7jqYBhp16OcYUhodoMbuPaEBVxBY=; b=kQxk4m8Pui0hn4NSPvXqu58X3koUJE3eRIN715bZxyxjB11Ue/MpY0MnQ1pnNfxGjJw8mRd6mZz1D1/fxrZsMK4AjAbkkLWxal1FqE3gEFkx/19eAeYXOBH7wvPYZAoCv0/Sjd14tV/q4dSa2miDI84zy9irDB7pGtbXA1ptm7w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1622646349561728.813472286573; Wed, 2 Jun 2021 08:05:49 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232172AbhFBPHa (ORCPT ); Wed, 2 Jun 2021 11:07:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:37176 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231416AbhFBPHK (ORCPT ); Wed, 2 Jun 2021 11:07:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F39F1613E6; Wed, 2 Jun 2021 15:05:26 +0000 (UTC) Received: by mail.kernel.org with local (Exim 4.94.2) (envelope-from ) id 1loSQu-006Wae-Qg; Wed, 02 Jun 2021 17:05:24 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622646327; bh=eRZOupZBFmZ1BZK79Vn+IxtuultSvsJ6g2ZE0mpM3rY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Kdn3szau7+7gl1OwRdqarEsQNACxDRuVFXKgV0OeVeYUMZQZYxNLfhdSHyiBPA2aX zRMZKno1hhzoHBwcPk8eUswklAvnFirxlQcyN8y63wwPoFlSHzSFXCoE9Gqmbyj9kz 9P0wzLvIuNk2sSd83lqxcYL0VyiVTv7RrWM6J40O4ZRR5VPpDBHJb9Sz+ySWyD5yhu qmG4JySoR42gm91bZb0DUV9zEAON0StdEjNcqGhlFLQtM86SqVqJF9oPogNGZGJc7m cCVWRoKYMCfy3iwZ44notNcb3pnA6Ee020nbDpI+hIHpjMQrlb8h5oAngj79ZKdJGL 3Nq+ti+QiceAw== From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , Antti Palosaari , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH 2/6] media: rtl28xxu: replace a NO-BREAK SPACE character Date: Wed, 2 Jun 2021 17:05:19 +0200 Message-Id: X-Mailer: git-send-email 2.31.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Instead of using: - U+00a0 ('=C2=A0'): NO-BREAK SPACE Use a normal white space. This was probably introduced by some cut-and-paste. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dv= b-usb-v2/rtl28xxu.c index 2c04ed8af0e4..83705730e37e 100644 --- a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c +++ b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c @@ -1777,7 +1777,7 @@ static int rtl2832u_rc_query(struct dvb_usb_device *d) ir_raw_event_store_with_filter(d->rc_dev, &ev); } =20 - /* 'flush'=C2=A0ir_raw_event_store_with_filter() */ + /* 'flush' ir_raw_event_store_with_filter() */ ir_raw_event_handle(d->rc_dev); exit: return ret; --=20 2.31.1 From nobody Sat May 11 20:59:39 2024 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1622646340; cv=none; d=zohomail.com; s=zohoarc; b=dXfis+Rm5RRoQL7p+fLURwn9kgMTGU77FIg+CPLSgS48o6BgA2jCZ5OdO/2aCUPqAiHDM6EVMI43UwxiBhWyURT3QTBVOSSXZhYE0k9rWhSB8dTBzfkdyqiHmH2tPJSy7rMixBoN3L9nOyaq0GVOkbXSH00yKv0GicnOL2VsKT0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622646340; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Wvr02D7a0QPJ2cq4dRfcn0pwYFbbBba919weg49kKIc=; b=QXbUD2dJIussfI5AsbN61SCYe3hAayqYxnEcgR1vP2xGwPcvH1CDHLug8k9OmE6TXqt6cJx6z2ISNV4+DJgy+Kwf62REkaE6mLaBcAKGufDHuvEvkytTpKNKKdMKCWbwJ/NUbj7mGnnoYQ3URMBsiwynHIj2ONT9pipDYflqz6I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1622646340016914.8536943113178; Wed, 2 Jun 2021 08:05:40 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231998AbhFBPHV (ORCPT ); Wed, 2 Jun 2021 11:07:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:37140 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230482AbhFBPHK (ORCPT ); Wed, 2 Jun 2021 11:07:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E73D6613D0; Wed, 2 Jun 2021 15:05:26 +0000 (UTC) Received: by mail.kernel.org with local (Exim 4.94.2) (envelope-from ) id 1loSQu-006Waj-Rq; Wed, 02 Jun 2021 17:05:24 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622646327; bh=JZH2HyNn+bokqhbpV6owb8yumaHCOUaoiPPXWSuP7RQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kIbwOdIs/E+yLFKzNEl2LI2MTR5H5X78n4NCRWmX8AsPpuUb8wlEsefatwflmFA24 F6zBT0br9QpX24PG86M1+O4j2VROs2MqZhqPKyzc/qIrT5WbiOYWqdHGws+CzY1Yol v36vk9fYduS1S5GujZALtivIqouKBsOT7HASn3TyoWL2KPixaL9VsgpigVXkmXHISE imsqAIrXqNrKHlF8YwJDoClDaZ0vQwaH3ag2Tb6D+VzRMRaa3TxIsiA2sQ51B6Vx0L CKGos8ja9nuiN5VQl8OQ5pX4Dib65lX4/1KYBZ7cLQJD/9wepJd9YWQPhMb8NKm4Se kusLeMktNKLpw== From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , Mauro Carvalho Chehab , Michael Tretter , Pengutronix Kernel Team , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH 3/6] media: allegro-dvt: avoid EN DASH char Date: Wed, 2 Jun 2021 17:05:20 +0200 Message-Id: <94f20b3817342ace2ac06057150b73996874c43f.1622646256.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) While there's nothing wrong with EN DASH on C code, this probably came from some cut-and paste from an ITU-T table. It sounds better to just an HYPHEN here. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/allegro-dvt/nal-h264.c | 2 +- drivers/media/platform/allegro-dvt/nal-hevc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/allegro-dvt/nal-h264.c b/drivers/media/= platform/allegro-dvt/nal-h264.c index 94dd9266d850..a02095eb3fcf 100644 --- a/drivers/media/platform/allegro-dvt/nal-h264.c +++ b/drivers/media/platform/allegro-dvt/nal-h264.c @@ -25,7 +25,7 @@ #include "nal-rbsp.h" =20 /* - * See Rec. ITU-T H.264 (04/2017) Table 7-1 =E2=80=93 NAL unit type codes,= syntax + * See Rec. ITU-T H.264 (04/2017) Table 7-1 -- NAL unit type codes, syntax * element categories, and NAL unit type classes */ enum nal_unit_type { diff --git a/drivers/media/platform/allegro-dvt/nal-hevc.c b/drivers/media/= platform/allegro-dvt/nal-hevc.c index 5db540c69bfe..15a352e45831 100644 --- a/drivers/media/platform/allegro-dvt/nal-hevc.c +++ b/drivers/media/platform/allegro-dvt/nal-hevc.c @@ -25,7 +25,7 @@ #include "nal-rbsp.h" =20 /* - * See Rec. ITU-T H.265 (02/2018) Table 7-1 =E2=80=93 NAL unit type codes = and NAL unit + * See Rec. ITU-T H.265 (02/2018) Table 7-1 - NAL unit type codes and NAL = unit * type classes */ enum nal_unit_type { --=20 2.31.1 From nobody Sat May 11 20:59:39 2024 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1622646341; cv=none; d=zohomail.com; s=zohoarc; b=CJ95oXT3o1+H5//0P2N+bmrNgFG0oiwD/KxfBKguzG2yNTgZcjqbsKlmDLxxgUZ0wDEmrGUrQqPuP072oG7Iq9GfiDgckYNe9T7GwqfuV7QQ61kH9GM49pNS5M7Z9mGtsn6jthTQeJWLS+sUtInf2xbvJKDXHK1xw43uG7mGb2I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622646341; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lAyto+4OJZb5/ZEPZZDDMm4pzFsyvHd9zKnTInGTEfg=; b=XAo7s87gxewcTdN5Lf92G894qSwFMl7nznj80r67sVvUVhrhPfo7Lm8uPU/gdlstcXMN5loxYWUc98dtC8B1hqfXbve+KynDwe3IM2ATowLOCSk16BlNFX92eD19HVQWV/j3Zp7NlsdcIPJfM7jIsU5dfp1Zt2dk0scOaEIccUo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1622646341987211.09183377214902; Wed, 2 Jun 2021 08:05:41 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232123AbhFBPHX (ORCPT ); Wed, 2 Jun 2021 11:07:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:37150 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231200AbhFBPHK (ORCPT ); Wed, 2 Jun 2021 11:07:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E4E36613BF; Wed, 2 Jun 2021 15:05:26 +0000 (UTC) Received: by mail.kernel.org with local (Exim 4.94.2) (envelope-from ) id 1loSQu-006Wan-T3; Wed, 02 Jun 2021 17:05:24 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622646327; bh=O+MVZK2/VWrOv0uNopPTZk4ef5SjBfIFg4HgutEUxc4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=M2dpSqDMav4VZzm17qWX3o18vHiY0sFfvlftLEIwcDyfxZs9nS51U7xANVUh31S1X h1EuuzY13soZbe19UGG+tJwuPRb4pIjaeBPxy2lliZkdCaiJcO8BHAQi8DwIT08i+u M6JomKk3PBwSPnf+zyJGMK9DRUnwQBPVVr84KEtEQoT9+9DjnkVlGoRQULVCrkFqvO TwKGKG2OezPfo+Ty45YS68LT/LrXR8dSd1fT9qFuKZhP6KPUMWbuxPekOKB5vOv9OK hJCh7y4/rm/U2Inex1qDwUqMHZBTyjZHxkxZ63PJbDFf3KQVqCAM38wUEg23Ky/YjI j2o62Dkf/dzzQ== From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , "Gustavo A. R. Silva" , Hans Verkuil , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH 4/6] media: saa7134: drop a NO-BREAK SPACE Date: Wed, 2 Jun 2021 17:05:21 +0200 Message-Id: X-Mailer: git-send-email 2.31.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) There are two spaces on a comment there, being one of them an U+00a0 ('=C2=A0'): NO-BREAK SPACE. Drop it. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/pci/saa7134/saa7134-tvaudio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/saa7134/saa7134-tvaudio.c b/drivers/media/pc= i/saa7134/saa7134-tvaudio.c index aa0895d2d735..9e0c442abc76 100644 --- a/drivers/media/pci/saa7134/saa7134-tvaudio.c +++ b/drivers/media/pci/saa7134/saa7134-tvaudio.c @@ -871,7 +871,7 @@ void saa7134_enable_i2s(struct saa7134_dev *dev) switch (dev->pci->device) { case PCI_DEVICE_ID_PHILIPS_SAA7133: case PCI_DEVICE_ID_PHILIPS_SAA7135: - /* Set I2S format (SONY) =C2=A0*/ + /* Set I2S format (SONY) */ saa_writeb(SAA7133_I2S_AUDIO_CONTROL, 0x00); /* Start I2S */ saa_writeb(SAA7134_I2S_AUDIO_OUTPUT, 0x11); --=20 2.31.1 From nobody Sat May 11 20:59:39 2024 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1622646343; cv=none; d=zohomail.com; s=zohoarc; b=ImkxHRbyvWGdg52IXHx1xBY4fXPxyrfnAjqd6UDCMfAxLe16WSmgTzGUBnuLZFo95/pt0pKGQgC9Knn9AAzbPadT7kS94Q6G/oZ0dBvRkxcvSapYE84bJ9QOGCgC8/mxlhda+rrpyLaF7MoYhEfWoagOZrH+nK+eBuE69bEuF4k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622646343; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Sender:Subject:To; bh=30do9F/Uh/ljBMhB5hglXoSHWzbaPZ2jtTylqeB7LuQ=; b=LlVGKLzErurE39zJsCoac3ICWCxdQzjahh2P0y6aWJjDlvaG+ShH81lXyAQh283wU8fNo8zS0ZIz+os/DpRfVCqxEDZO2aJ18jtluSXAy0zUnsoWrUiEZJQYw/Kzk8w140eHCJDDX1BfdQZDR/SjxNC/52MfM0kUR5F/m4aQbs8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1622646343532127.48312914639712; Wed, 2 Jun 2021 08:05:43 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232137AbhFBPHZ (ORCPT ); Wed, 2 Jun 2021 11:07:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:37148 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231163AbhFBPHK (ORCPT ); Wed, 2 Jun 2021 11:07:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E9E18613D8; Wed, 2 Jun 2021 15:05:26 +0000 (UTC) Received: by mail.kernel.org with local (Exim 4.94.2) (envelope-from ) id 1loSQu-006War-Un; Wed, 02 Jun 2021 17:05:24 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622646327; bh=/VW98BgUxBbnSJt1QxDOoQylKRCwxutfrTn0iL4Fd+c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Fjab3ZAN6VOblK9+K+BfCs3qvRr83jIvsquOfOPwICcGmGj1wHAXxnigg8Nx73Hr/ Iekz8fljMvBFTWhvt9ZvwY+rMl/CUtK+d1Z+C5nEkOGXnuFJSegQAbTnRPEylob7/B z76RTJVF512p3TUVYoX7MsELJu9UNOsXbF9XdGvzOCtB1ddUcgWUJ4ZSZBDKFrgHO1 sekdekop49Pb6U9VV4cmp8FBl7+SB1hD8EBDNE7czMleN4E2Tdn/+p1x73Y85U9Ykv PcMHVH7vLfHKJqtp9NZey8xYwwAo1EXatXBtWGGQE6CeCcoi7/FHXGaYwMTTDMMBoj aqTr4TTTJ0t1w== From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , Mauro Carvalho Chehab , Sean Young , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH 5/6] media: rc: ite-cir: replace some an EN DASH Date: Wed, 2 Jun 2021 17:05:22 +0200 Message-Id: <2b66c88a59b270f26c826e6eeb498a12168de7ef.1622646256.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Instead of using U+2013 ('=E2=80=93'): EN DASH, let's just use an hyphen there, as this was probably introduced by some cut-and-paste from some other place. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/rc/ite-cir.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/rc/ite-cir.h b/drivers/media/rc/ite-cir.h index ce7a40b10828..4b4294d77555 100644 --- a/drivers/media/rc/ite-cir.h +++ b/drivers/media/rc/ite-cir.h @@ -167,7 +167,7 @@ struct ite_dev { * hardware data obtained from: * * IT8712F - * Environment Control =E2=80=93 Low Pin Count Input / Output + * Environment Control - Low Pin Count Input / Output * (EC - LPC I/O) * Preliminary Specification V0. 81 */ --=20 2.31.1 From nobody Sat May 11 20:59:39 2024 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1622646352; cv=none; d=zohomail.com; s=zohoarc; b=PKyVk+QpvqodokiywIaPvklC6J6GDvYqRjnYwI4lif8UmCfQSCtPluLrkrHR8mOTqzHeSvFO5j+UgoK3hR0yp0GWHA4gISgbVjbT3wZDcHnKmjPBKCmxx3TpGO7ryhHh0hkk7kmjHi/SKLdx02UlO2pecJ5gHycBA7FkbCCBBBQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622646352; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qg8h+lni4ZRzHGS3yo0j/2JtW8TeKcZoMcXFLd9daRc=; b=l7VCYPA1+2lFc8se4NgpyZES/8Xyq2kIPhzwhIf92qVb0zjGvk/HjLrR4BxTjRp34IN3f7KseARsm9kl43L56JB//OYWipUUhLcapf6Ne/DK0uGcJAqgPM8HBynUUoJ6uaB/gJAeM9ian+SSOYVFDZoQYyfAYEeHr8WJPpiB7Xk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1622646352319343.92759369377654; Wed, 2 Jun 2021 08:05:52 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232163AbhFBPHe (ORCPT ); Wed, 2 Jun 2021 11:07:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:37178 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231562AbhFBPHK (ORCPT ); Wed, 2 Jun 2021 11:07:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id ECBE3613B1; Wed, 2 Jun 2021 15:05:26 +0000 (UTC) Received: by mail.kernel.org with local (Exim 4.94.2) (envelope-from ) id 1loSQu-006Wav-Vm; Wed, 02 Jun 2021 17:05:24 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622646327; bh=+7eD8ire9eZTnXGswm7e8pAOBUmbjkyw9SqBn7O/068=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LdzLIMEU27CqRpvn8MDydKwQa/VO5odpka7KgPTT+Gxb0EBF4jougb3tLo+lFYYaa JAgsM6SuA/sLW1TIclr93tBQbHiZLzsGeEi/6q08DeY4D2H87nUrYWE/A2LF/BhFyP 28JqxX0spkNcEk0uLIUmfcYg9Qx//7JUugyGlhv2HQfWdRDO4rA3IFv4IEjIzohHvo SGJpTyg5F22Koxa+dRI0mtdfaawLuALCRHZXNVvWijUI2aUiWsO74YlRkTlaRTXidW TksTQesZQAm5WFqAJjPIFs+liYH2p/EGXpeNoboE8Z/MJq0HqpLX+2AGCJotjSDLwR CdtWfb95cnmYA== From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , Andrey Utkin , Anton Sviridenko , Bluecherry Maintainers , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH 6/6] media: pci: tw5864: avoid usage of some characters Date: Wed, 2 Jun 2021 17:05:23 +0200 Message-Id: <0b6f77961da3bd83c4c024b38fa45bc07b7719c2.1622646256.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) There are several comments on this driver using those chars: - U+2013 ('=E2=80=93'): EN DASH - U+2018 ('=E2=80=98'): LEFT SINGLE QUOTATION MARK - U+2019 ('=E2=80=99'): RIGHT SINGLE QUOTATION MARK They probably came from cut-and-pasting some texts found elsewhere. While there's nothing wrong on having those on comments in C, it is better to use ASCII chars for those specific cases, as the current variant doesn't really add any value. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/pci/tw5864/tw5864-reg.h | 62 +++++++++++++-------------- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/drivers/media/pci/tw5864/tw5864-reg.h b/drivers/media/pci/tw58= 64/tw5864-reg.h index a74f30f2f78e..a26a439c4dc0 100644 --- a/drivers/media/pci/tw5864/tw5864-reg.h +++ b/drivers/media/pci/tw5864/tw5864-reg.h @@ -289,13 +289,13 @@ /* OSD enable bit for each channel */ #define TW5864_DSP_OSD_ENABLE 0x0228 =20 -/* 0x0280 ~ 0x029c =E2=80=93 Motion Vector for 1st 4x4 Block, e.g., 80 (X)= , 84 (Y) */ +/* 0x0280 ~ 0x029c - Motion Vector for 1st 4x4 Block, e.g., 80 (X), 84 (Y)= */ #define TW5864_ME_MV_VEC1 0x0280 -/* 0x02a0 ~ 0x02bc =E2=80=93 Motion Vector for 2nd 4x4 Block, e.g., A0 (X)= , A4 (Y) */ +/* 0x02a0 ~ 0x02bc - Motion Vector for 2nd 4x4 Block, e.g., A0 (X), A4 (Y)= */ #define TW5864_ME_MV_VEC2 0x02a0 -/* 0x02c0 ~ 0x02dc =E2=80=93 Motion Vector for 3rd 4x4 Block, e.g., C0 (X)= , C4 (Y) */ +/* 0x02c0 ~ 0x02dc - Motion Vector for 3rd 4x4 Block, e.g., C0 (X), C4 (Y)= */ #define TW5864_ME_MV_VEC3 0x02c0 -/* 0x02e0 ~ 0x02fc =E2=80=93 Motion Vector for 4th 4x4 Block, e.g., E0 (X)= , E4 (Y) */ +/* 0x02e0 ~ 0x02fc - Motion Vector for 4th 4x4 Block, e.g., E0 (X), E4 (Y)= */ #define TW5864_ME_MV_VEC4 0x02e0 =20 /* @@ -462,13 +462,13 @@ =20 #define TW5864_VLC_BUF 0x100c /* Define controls in register TW5864_VLC_BUF */ -/* VLC BK0 full status, write =E2=80=981=E2=80=99 to clear */ +/* VLC BK0 full status, write '1' to clear */ #define TW5864_VLC_BK0_FULL BIT(0) -/* VLC BK1 full status, write =E2=80=981=E2=80=99 to clear */ +/* VLC BK1 full status, write '1' to clear */ #define TW5864_VLC_BK1_FULL BIT(1) -/* VLC end slice status, write =E2=80=981=E2=80=99 to clear */ +/* VLC end slice status, write '1' to clear */ #define TW5864_VLC_END_SLICE BIT(2) -/* VLC Buffer overflow status, write =E2=80=981=E2=80=99 to clear */ +/* VLC Buffer overflow status, write '1' to clear */ #define TW5864_DSP_RD_OF BIT(3) /* VLC string length in either buffer 0 or 1 at end of frame */ #define TW5864_VLC_STREAM_LEN_SHIFT 4 @@ -476,7 +476,7 @@ =20 /* [15:0] Total coefficient number in a frame */ #define TW5864_TOTAL_COEF_NO 0x1010 -/* [0] VLC Encoder Interrupt. Write =E2=80=981=E2=80=99 to clear */ +/* [0] VLC Encoder Interrupt. Write '1' to clear */ #define TW5864_VLC_DSP_INTR 0x1014 /* [31:0] VLC stream CRC checksum */ #define TW5864_VLC_STREAM_CRC 0x1018 @@ -494,7 +494,7 @@ */ #define TW5864_VLC_RD_BRST BIT(1) =20 -/* 0x2000 ~ 0x2ffc -- H264 Stream Memory Map */ +/* 0x2000 ~ 0x2ffc - H264 Stream Memory Map */ /* * A word is 4 bytes. I.e., * VLC_STREAM_MEM[0] address: 0x2000 @@ -506,7 +506,7 @@ #define TW5864_VLC_STREAM_MEM_MAX_OFFSET 0x3ff #define TW5864_VLC_STREAM_MEM(offset) (TW5864_VLC_STREAM_MEM_START + 4 * o= ffset) =20 -/* 0x4000 ~ 0x4ffc -- Audio Register Map */ +/* 0x4000 ~ 0x4ffc - Audio Register Map */ /* [31:0] config 1ms cnt =3D Realtime clk/1000 */ #define TW5864_CFG_1MS_CNT 0x4000 =20 @@ -688,10 +688,10 @@ =20 /* * [1:0] - * 2=E2=80=99b00 phase set to 180 degree - * 2=E2=80=99b01 phase set to 270 degree - * 2=E2=80=99b10 phase set to 0 degree - * 2=E2=80=99b11 phase set to 90 degree + * 2'b00 phase set to 180 degree + * 2'b01 phase set to 270 degree + * 2'b10 phase set to 0 degree + * 2'b11 phase set to 90 degree */ #define TW5864_I2C_PHASE_CFG 0x800c =20 @@ -826,7 +826,7 @@ /* SPLL_IREF, SPLL_LPX4, SPLL_CPX4, SPLL_PD, SPLL_DBG */ #define TW5864_SPLL 0x8028 =20 -/* 0x8800 ~ 0x88fc -- Interrupt Register Map */ +/* 0x8800 ~ 0x88fc - Interrupt Register Map */ /* * Trigger mode of interrupt source 0 ~ 15 * 1 Edge trigger mode @@ -909,7 +909,7 @@ #define TW5864_INTR_I2C_DONE BIT(25) #define TW5864_INTR_AD BIT(26) =20 -/* 0x9000 ~ 0x920c -- Video Capture (VIF) Register Map */ +/* 0x9000 ~ 0x920c - Video Capture (VIF) Register Map */ /* * H264EN_CH_STATUS[n] Status of Vsync synchronized H264EN_CH_EN (Read Onl= y) * 1 Channel Enabled @@ -1009,7 +1009,7 @@ /* GPIO Output Enable of Group n */ #define TW5864_GPIO_OEN (0xff << 8) =20 -/* 0xa000 ~ 0xa8ff =E2=80=93 DDR Controller Register Map */ +/* 0xa000 ~ 0xa8ff - DDR Controller Register Map */ /* DDR Controller A */ /* * [2:0] Data valid counter after read command to DDR. This is the delay v= alue @@ -1111,7 +1111,7 @@ */ #define TW5864_DDR_B_OFFSET 0x0800 =20 -/* 0xb004 ~ 0xb018 =E2=80=93 HW version/ARB12 Register Map */ +/* 0xb004 ~ 0xb018 - HW version/ARB12 Register Map */ /* [15:0] Default is C013 */ #define TW5864_HW_VERSION 0xb004 =20 @@ -1145,7 +1145,7 @@ /* ARB12 maximum value of time out counter (default 15"h1FF) */ #define TW5864_ARB12_TIME_OUT_CNT 0x7fff =20 -/* 0xb800 ~ 0xb80c -- Indirect Access Register Map */ +/* 0xb800 ~ 0xb80c - Indirect Access Register Map */ /* * Spec says: * In order to access the indirect register space, the following procedure= is @@ -1177,7 +1177,7 @@ /* [31:0] Data used to read/write indirect register space */ #define TW5864_IND_DATA 0xb804 =20 -/* 0xc000 ~ 0xc7fc -- Preview Register Map */ +/* 0xc000 ~ 0xc7fc - Preview Register Map */ /* Mostly skipped this section. */ /* * [15:0] Status of Vsync Synchronized PCI_PV_CH_EN (Read Only) @@ -1192,12 +1192,12 @@ */ #define TW5864_PCI_PV_CH_EN 0xc004 =20 -/* 0xc800 ~ 0xc804 -- JPEG Capture Register Map */ +/* 0xc800 ~ 0xc804 - JPEG Capture Register Map */ /* Skipped. */ -/* 0xd000 ~ 0xd0fc -- JPEG Control Register Map */ +/* 0xd000 ~ 0xd0fc - JPEG Control Register Map */ /* Skipped. */ =20 -/* 0xe000 ~ 0xfc04 =E2=80=93 Motion Vector Register Map */ +/* 0xe000 ~ 0xfc04 - Motion Vector Register Map */ =20 /* ME Motion Vector data (Four Byte Each) 0xe000 ~ 0xe7fc */ #define TW5864_ME_MV_VEC_START 0xe000 @@ -1231,7 +1231,7 @@ */ #define TW5864_MPI_DDR_SEL2 BIT(15) =20 -/* 0x18000 ~ 0x181fc =E2=80=93 PCI Master/Slave Control Map */ +/* 0x18000 ~ 0x181fc - PCI Master/Slave Control Map */ #define TW5864_PCI_INTR_STATUS 0x18000 /* Define controls in register TW5864_PCI_INTR_STATUS */ /* vlc done */ @@ -1400,11 +1400,11 @@ #define TW5864_VLC_STREAM_BASE_ADDR 0x18080 /* MV stream base address */ #define TW5864_MV_STREAM_BASE_ADDR 0x18084 -/* 0x180a0 =E2=80=93 0x180bc: audio burst base address. Skipped. */ -/* 0x180c0 ~ 0x180dc =E2=80=93 JPEG Push Mode Buffer Base Address. Skipped= . */ -/* 0x18100 =E2=80=93 0x1817c: preview burst base address. Skipped. */ +/* 0x180a0 ~ 0x180bc: audio burst base address. Skipped. */ +/* 0x180c0 ~ 0x180dc: JPEG Push Mode Buffer Base Address. Skipped. */ +/* 0x18100 ~ 0x1817c: preview burst base address. Skipped. */ =20 -/* 0x80000 ~ 0x87fff -- DDR Burst RW Register Map */ +/* 0x80000 ~ 0x87fff - DDR Burst RW Register Map */ #define TW5864_DDR_CTL 0x80000 /* Define controls in register TW5864_DDR_CTL */ #define TW5864_BRST_LENGTH_SHIFT 2 @@ -1516,7 +1516,7 @@ * Vertical Sharpness Control. Writable. * 0 =3D None (default) * 7 =3D Highest - * **Note: VSHP must be set to =E2=80=980=E2=80=99 if COMB =3D 0 + * **Note: VSHP must be set to '0' if COMB =3D 0 */ #define TW5864_INDIR_VIN_1_VSHP 0x07 =20 @@ -1595,7 +1595,7 @@ #define TW5864_INDIR_VIN_9_CNTRST(channel) (0x009 + channel * 0x010) =20 /* - * These bits control the brightness. They have value of =E2=80=93128 to 1= 27 in 2's + * These bits control the brightness. They have value of -128 to 127 in 2's * complement form. Positive value increases brightness. A value 0 has no * effect on the data. The default is 00h. */ --=20 2.31.1