From nobody Sat May 10 03:31:08 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1620314692; cv=none; d=zohomail.com; s=zohoarc; b=ZeTA2joQUFY1CC5UNTvCXefepbRUsMk8fdozD7pNabCPbY4BelwiYSCpLzSBP/aOKKUSfXH9+lndCJUvXMdwsr+scYnChxCQknzwMvID+MTlGXEAUR9EOYgNRUt3rVWy3YrnwyeKZsqQZGIRC87IRKhwAjJSaVkQlvBTydG5ed0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620314692; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fMPnqzv8RyB/pFyrZ77/bX9UlLHM2eXfJsmxW+ioCL4=; b=fa6xafSxtK8Khge3tnxsCred2LQJFHYFJROx9+oKTOAEbqIdZIL4lgH3tn+6HeelJBhoaWdLWJzEWSNkb5sXi5cLSyn5S5vQ4Jem8dJr54r7B0+a1qK/Kbh0UrPcuK8NFcLk00kq35HJIfNPJmF50xPK4kmdEGYUl05kN8a3OwQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 162031469290451.98827734681629; Thu, 6 May 2021 08:24:52 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235501AbhEFPZs (ORCPT ); Thu, 6 May 2021 11:25:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:38228 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235205AbhEFPYd (ORCPT ); Thu, 6 May 2021 11:24:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 771F7613F1; Thu, 6 May 2021 15:23:30 +0000 (UTC) Received: by mail.kernel.org with local (Exim 4.94.2) (envelope-from ) id 1lefqa-000Rvm-Kq; Thu, 06 May 2021 17:23:28 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620314610; bh=5KztMjooOddzA79l4hTCyOZrgNAAq7qVnwZ9IgWgZxo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AO1K+ztJy0oV30u1iC4G7m4X8l+MgPWqY2fFg9YCKesRQgzoTTol8SMCbMhZfsURh AWfTXx7dLckj+KX647RhVkO3YeWNaek1NYfTVhLG53FiSuuKgZCmIHKHQZ0PdIcgud cBiJf45DCpFYjkG49aKiZv3UiMEjaNmYXUvrlbkFbqiKdxpnyl4tjLi0Y5xyZXwDGT Z9jyd6+CbHDlvVzCwUD6PD9igTy+ECIKoipy1APajZ5CYUCzDelC/aYvmGOFPcUymb Vxjwhjf5MG0nLaAs5Z8J+ksWgrpSD/uaX7yre16wtldola1rwVYSsqPfw/ymzSJmHf kS6q0MPiixGCQ== From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , Dave Stevenson , Jacopo Mondi , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v5 19/30] media: i2c: ov5647: use pm_runtime_resume_and_get() Date: Thu, 6 May 2021 17:23:15 +0200 Message-Id: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal wi= th usage counter") added pm_runtime_resume_and_get() in order to automatically handle dev->power.usage_count decrement on errors. Use the new API, in order to cleanup the error check logic. Acked-by: Jacopo Mondi Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/ov5647.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/ov5647.c b/drivers/media/i2c/ov5647.c index 1cefa15729ce..38faa74755e3 100644 --- a/drivers/media/i2c/ov5647.c +++ b/drivers/media/i2c/ov5647.c @@ -882,20 +882,20 @@ static int ov5647_s_stream(struct v4l2_subdev *sd, in= t enable) } =20 if (enable) { - ret =3D pm_runtime_get_sync(&client->dev); + ret =3D pm_runtime_resume_and_get(&client->dev); if (ret < 0) goto error_unlock; =20 ret =3D ov5647_stream_on(sd); if (ret < 0) { dev_err(&client->dev, "stream start failed: %d\n", ret); - goto error_unlock; + goto error_pm; } } else { ret =3D ov5647_stream_off(sd); if (ret < 0) { dev_err(&client->dev, "stream stop failed: %d\n", ret); - goto error_unlock; + goto error_pm; } pm_runtime_put(&client->dev); } @@ -905,8 +905,9 @@ static int ov5647_s_stream(struct v4l2_subdev *sd, int = enable) =20 return 0; =20 +error_pm: + pm_runtime_put(&client->dev); error_unlock: - pm_runtime_put(&client->dev); mutex_unlock(&sensor->lock); =20 return ret; --=20 2.30.2