From nobody Sat May 10 02:49:33 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1619519389; cv=none; d=zohomail.com; s=zohoarc; b=eK/lidsnMjnzTP/6+epdRPCY0xMrhMKCCGw9GxdKesKewlDUVPsc5esHG4jpW3GURGobeNnUhKBY4py5MPwA0Fgbp1kFFeunSctpOQaeieXUMMTZTLtb49VtjxDLEcODypHLsLT+ZTsDpEESrd1qPoJVuW+nhzl6qzHeqAfZdfU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619519389; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qRTMTvpczQKE+X3g27UzHLGlN/Kg7/wYaxpaH83PSm4=; b=nrWFoFbQUDZeH8hT69q5qwrO9P9UQUtA7+JbGGNj3N3ul+WovNWsAyMnLH3aG0twxzU7MadNgMenxgDFdgT7pefNdMGYkjNG7F8LnIJJd91/bBLoHcIdcZnzvsTmlgHb0hXbrtYRigP9oVxstwhO+qfA+m3Qt1g+mnX6wK72+Ps= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 161951938954841.94859150692605; Tue, 27 Apr 2021 03:29:49 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238311AbhD0Kaa (ORCPT ); Tue, 27 Apr 2021 06:30:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:48278 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235613AbhD0K2F (ORCPT ); Tue, 27 Apr 2021 06:28:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5925E613FE; Tue, 27 Apr 2021 10:27:16 +0000 (UTC) Received: by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1lbKvx-000o19-5J; Tue, 27 Apr 2021 12:27:13 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619519236; bh=Q0bHrDKjUOjsdiFC7y51wKhz9eviTnP6n0iV74l2LA8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ONLvm551PXN4wdOfSePFx78XwTlfDQKJG71nnYWcye9pm0Dt33drJjYT04cJxL46C RRqRvqBeq40PuhlGiZXiAjWsSS3C8+vP682ozSZv2MLlzYxDcr7RkgDEshhxY6lfvU ue3lvil3AfJJbLjLdRiwr7TyKgRTLZtZUPhCZs9jphqkgj/k6ow6A67FVKvmWcw9hi oaOtCuotIBH59TuSRFhD75aYxw//6PnSB7YSDgavXLe1ALzG1tk4UTDzk7e2PlHi9r 2A2HDfHS9lcMo53z4XthDeABGNrH85oNlwF4/3t/QfcQ5b+Uwgkzlg7gbBs8rM6o0p Iwho8OjtWNNxw== From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , "Paul J. Murphy" , Daniele Alessandrelli , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v3 40/79] media: i2c: imx334: use pm_runtime_resume_and_get() Date: Tue, 27 Apr 2021 12:26:30 +0200 Message-Id: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal wi= th usage counter") added pm_runtime_resume_and_get() in order to automatically handle dev->power.usage_count decrement on errors. Use the new API, in order to cleanup the error check logic. Reviewed-by: Daniele Alessandrelli Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/imx334.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c index 047aa7658d21..a5a03bb4a6ae 100644 --- a/drivers/media/i2c/imx334.c +++ b/drivers/media/i2c/imx334.c @@ -717,9 +717,9 @@ static int imx334_set_stream(struct v4l2_subdev *sd, in= t enable) } =20 if (enable) { - ret =3D pm_runtime_get_sync(imx334->dev); + ret =3D pm_runtime_resume_and_get(imx334->dev); if (ret) - goto error_power_off; + goto error_unlock; =20 ret =3D imx334_start_streaming(imx334); if (ret) @@ -737,6 +737,7 @@ static int imx334_set_stream(struct v4l2_subdev *sd, in= t enable) =20 error_power_off: pm_runtime_put(imx334->dev); +error_unlock: mutex_unlock(&imx334->mutex); =20 return ret; --=20 2.30.2