From nobody Sat May 10 03:25:36 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1619518647; cv=none; d=zohomail.com; s=zohoarc; b=YsQ8dEg/XMcD+uMlcCKPEoOdulg3wIYtKDcNnmbZIoH2dK134y2UVGClFqoF/vNM/bnKOzDA8Rv9e8RTtUD+bLOOrw680KHAeYtFYL/JaIJ4zsRnFYP1EfrzgrkLAVgw4Usank4r9qQVxhnhEuRkzDM7RIha8xpiyvX1A/kn9Io= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619518647; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qRTMTvpczQKE+X3g27UzHLGlN/Kg7/wYaxpaH83PSm4=; b=Zuo+IxbwscDZ/+yl4hmy9JWL1vhESbudHrsL+WvtSiBRkqEqUYXw2GfBGP52k5ep1r9tUVytAE9L0Z3ll1YZe/0GuDmLapkXDYF+HN/8yeIhNCpQDOYEjwPXxe7oweEZ57P6Gb/zVATuiIdSZTU5p7UyNwmjdzZT93SbMYhxT+I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 16195186477031012.0483782803134; Tue, 27 Apr 2021 03:17:27 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237882AbhD0KSH (ORCPT ); Tue, 27 Apr 2021 06:18:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:35286 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235527AbhD0KOo (ORCPT ); Tue, 27 Apr 2021 06:14:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8F0EE613E8; Tue, 27 Apr 2021 10:13:52 +0000 (UTC) Received: by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1lbKj0-000j6W-5a; Tue, 27 Apr 2021 12:13:50 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619518432; bh=Q0bHrDKjUOjsdiFC7y51wKhz9eviTnP6n0iV74l2LA8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NXmG/9eu8AaxnkVHJjjXtDIKlJy2Dlfm2BCZ2/MihqF58VANihAxMazB4fnaqihqz X5PS80Wq3pMMaXMAlwZt0wQO8ztiSgN/sikXGCmH83OxVC6ut5wXOb/umardTQQ5lL 4KCEUJOQMoxjPrQ5oqkVIo3syrsQvIoyhTc+WxOBDZBWMbqzOBexhvCxks9AYXCEYb 7CE8fV44YeJ6H9SSnnBssSKFigYLchpbx5MiZCeGQ33AvGQdnBxyliUSbrQ78PU4qL WGEKSA7MMhfbHOEWYY59d0v389ilVdlF+4NhMRtgTPZfkpUJp7Ld0wHxJCMNV9fX/O v6WQQ4Sza9eDw== From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , "Paul J. Murphy" , Daniele Alessandrelli , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v2 40/79] media: i2c: imx334: use pm_runtime_resume_and_get() Date: Tue, 27 Apr 2021 12:13:07 +0200 Message-Id: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal wi= th usage counter") added pm_runtime_resume_and_get() in order to automatically handle dev->power.usage_count decrement on errors. Use the new API, in order to cleanup the error check logic. Reviewed-by: Daniele Alessandrelli Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/imx334.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c index 047aa7658d21..a5a03bb4a6ae 100644 --- a/drivers/media/i2c/imx334.c +++ b/drivers/media/i2c/imx334.c @@ -717,9 +717,9 @@ static int imx334_set_stream(struct v4l2_subdev *sd, in= t enable) } =20 if (enable) { - ret =3D pm_runtime_get_sync(imx334->dev); + ret =3D pm_runtime_resume_and_get(imx334->dev); if (ret) - goto error_power_off; + goto error_unlock; =20 ret =3D imx334_start_streaming(imx334); if (ret) @@ -737,6 +737,7 @@ static int imx334_set_stream(struct v4l2_subdev *sd, in= t enable) =20 error_power_off: pm_runtime_put(imx334->dev); +error_unlock: mutex_unlock(&imx334->mutex); =20 return ret; --=20 2.30.2