From nobody Sat May 10 06:21:12 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1612273458; cv=none; d=zohomail.com; s=zohoarc; b=UBVqfce3Cy7FYyNf/KMg/CLv7MJ26y1778J7R8DIt5HE5Pk9fAgldBWQEduO0lXpJqnT7Vcs1EAgZZlVq/zxMXGc559V9BgCUXPfwKY+i7iC4PkTCzCkrL0CfOa64OoyAKvm9ZvJXGjHWAv3c91SCEaKPEqAVpDDCUJpznoO/3I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612273458; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Sender:Subject:To; bh=m+r8mnYJQ0hFqDOHTrSCSYL3VjepkJKswUoARlqpj3c=; b=h1DYcSPe8kQi/6xPkxXLQBKB5JIt6eBTtmhCKIn7p/VBdpbCsW7Asz/bOAbPyZVKtWM3QRiyAtejqvcbTm9LT42L20TDdRNR/Nf7uIG5AzAhvdobfdqiGCm76FwhnvUk1jEJdxtdw6geKBradIozszPqlQOmL1xn9sKE5UKCUUY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1612273458815591.1633163496601; Tue, 2 Feb 2021 05:44:18 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232866AbhBBNnk (ORCPT ); Tue, 2 Feb 2021 08:43:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:59572 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232321AbhBBNbZ (ORCPT ); Tue, 2 Feb 2021 08:31:25 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id E058364F66; Tue, 2 Feb 2021 13:30:01 +0000 (UTC) Received: by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1l6vkl-0011zD-Sz; Tue, 02 Feb 2021 14:29:59 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612272602; bh=ezNQ33gqeTJQlThS5T6ajxdq1pnm4VEvay3F+5RFye8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kOlcAydoxHp9DQ4ujW5nUImaRK4VEO1n0sTAkyhibsDc0TBup3S7WrN+YyGQMuJIC TBdKNp/Nz2NewPNABpGzEngsnlj/e4I7kQpzEIUSlet8/0/XsxcqmPZkGpTgIU6Nyw 4S18cU23hkeKqXCbnXLSQLeYt1+NJtAbDUVL8jD6zR0bjHlHxuHIvgVssBR7IxRYQf mbNv679ohAPvgn5MLAXclLYs00xLGaQNgSrJW+euXcAq4W0lW37u5rXZ1oy+DgC9OC fHmh5zS2XP8i8F5FLGrFuNXqZ+5OeHt/9DLDsmfgdyGOlijCCLLM4u5LEIbsU/lIqH HWTtwxXh/AM3w== From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , Binghui Wang , Bjorn Helgaas , Lorenzo Pieralisi , Rob Herring , Xiaowei Song , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: [PATCH 12/13] pci: dwc: pcie-kirin: cleanup kirin970_pcie_get_eyeparam() Date: Tue, 2 Feb 2021 14:29:57 +0100 Message-Id: X-Mailer: git-send-email 2.29.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Cleanup the routine, to let it clearer that eye_param is optional and that, if not specified, the driver will assume the default. While here, also drop the useless debug prints. Signed-off-by: Mauro Carvalho Chehab --- drivers/pci/controller/dwc/pcie-kirin.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-kirin.c b/drivers/pci/controll= er/dwc/pcie-kirin.c index 37b964386d21..769110b39302 100644 --- a/drivers/pci/controller/dwc/pcie-kirin.c +++ b/drivers/pci/controller/dwc/pcie-kirin.c @@ -246,21 +246,18 @@ static long kirin_pcie_get_clk(struct kirin_pcie *kir= in_pcie, void kirin970_pcie_get_eyeparam(struct kirin_pcie *pcie) { struct device *dev =3D pcie->pci->dev; - int i; struct device_node *np; + int ret, i; =20 np =3D dev->of_node; =20 - if (of_property_read_u32_array(np, "eye_param", pcie->eye_param, 5)) { - for (i =3D 0; i < 5; i++) + ret =3D of_property_read_u32_array(np, "eye_param", pcie->eye_param, 5); + if (!ret) + return; + + /* There's no optional eye_param property. Set array to default */ + for (i =3D 0; i < 5; i++) pcie->eye_param[i] =3D EYEPARAM_NOCFG; - } - - dev_dbg(dev, "eye_param_vboost =3D [0x%x]\n", pcie->eye_param[0]); - dev_dbg(dev, "eye_param_iboost =3D [0x%x]\n", pcie->eye_param[1]); - dev_dbg(dev, "eye_param_pre =3D [0x%x]\n", pcie->eye_param[2]); - dev_dbg(dev, "eye_param_post =3D [0x%x]\n", pcie->eye_param[3]); - dev_dbg(dev, "eye_param_main =3D [0x%x]\n", pcie->eye_param[4]); } =20 static void kirin970_pcie_set_eyeparam(struct kirin_pcie *kirin_pcie) --=20 2.29.2