From nobody Tue Feb 10 16:53:14 2026 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1621350942; cv=none; d=zohomail.com; s=zohoarc; b=Z49UoEHAePvoqVEDmH9qPmrw6YeqasVN4+74U4Uwyc4cxJBfN7uQQsWarrevDQXwsf9cM05E2EH8o/d/Lke9oigOxR46DLJCpQn1ooSQfr7Z4pp2wm6dP33Uc1LSyvt6eVsGTMZCDD+oTN3xQ4GapmJFlSPaBJGkrhSVDZ5kMHs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621350942; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3EjOQtd1FIUlY1xhcPL2gqecRk1h44gepnYy2DzxRTw=; b=MID8wGY/AWPkli96yKCDVQzAvu6XvlD8j0isCacH5ECZavCqN1qPxL5rCnPQw3dBf+w6M3+jAGoQsCYb+6r4wm/FOMrV0cDNFrEwiWmy4ypojF3tLYiZsuym2P1rVCc9fme/bcchhah7+5S0iENs7OnCcmZoHPy7MaZQoQiMIb4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1621350942243880.5128166615268; Tue, 18 May 2021 08:15:42 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237974AbhERPMu (ORCPT ); Tue, 18 May 2021 11:12:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:49498 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345115AbhERPKk (ORCPT ); Tue, 18 May 2021 11:10:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3253E6135D; Tue, 18 May 2021 15:09:10 +0000 (UTC) Received: by mail.kernel.org with local (Exim 4.94.2) (envelope-from ) id 1lj1LI-007HOY-Bw; Tue, 18 May 2021 17:09:08 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621350550; bh=8ScJfoPrpnNH7Ei2h6t3H6qX9PFlvMLFJOxUxAyJWbo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MGpA9S7fryvwpywoR65U81eKP6hAtoGc6aMbEfHuEda4ggeClN9x95PlMaZmwzdg4 kLWy38h5Oh+xuH0sjkd98ffmR/5kJc31txtieHonumuc3SdcGdWOogQtQKtxc41Eqn I93tsyr0KsAYWu/ctEyRGpM7QoniqaKMgJV4+T4wOigjpLcbrhyWquQ91l3GvGR1oi 031LMAksauC0gTx7UmJhiSKYIyv72p/6OF1jtWR1h0mrgill9WjxR7fxLpOuceXWns cGKpzz7wH88kdI0qRyjBigAWXz4UAwEFpT3FiS9tDSn9Cxfue7ZnoT2+BzjDNCkJ7a +LztTjvPwTVLQ== From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , Pavel Machek , gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: [PATCH v2 10/17] leds: leds-nuc: Add support to blink behavior for NUC8/10 Date: Tue, 18 May 2021 17:08:59 +0200 Message-Id: X-Mailer: git-send-email 2.31.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The hardware blink logic works for both Power State and Software controlled LEDs. Just like brightness, there is one different blink behavior per different power state. Due to that, the logic is somewhat more complex than what it would be expected otherwise. Signed-off-by: Mauro Carvalho Chehab --- drivers/leds/leds-nuc.c | 347 +++++++++++++++++++++++++++++++++++++--- 1 file changed, 322 insertions(+), 25 deletions(-) diff --git a/drivers/leds/leds-nuc.c b/drivers/leds/leds-nuc.c index 03fa8bafc5de..a5eb625d7b51 100644 --- a/drivers/leds/leds-nuc.c +++ b/drivers/leds/leds-nuc.c @@ -530,18 +530,30 @@ static ssize_t nuc_wmi_set_brightness_offset(struct d= evice *dev, #define LED_ATTR_RW(_name) \ DEVICE_ATTR(_name, 0644, show_##_name, store_##_name) =20 -#define LED_ATTR_POWER_STATE_RW(_name, offset) \ +#define LED_ATTR_POWER_STATE_RW(_name, _offname, _offset) \ static ssize_t show_##_name(struct device *dev, \ struct device_attribute *attr, \ char *buf) \ { \ - return show_brightness_offset(dev, attr, offset, buf); \ + struct led_classdev *cdev =3D dev_get_drvdata(dev); \ + struct nuc_nmi_led *led; \ + \ + led =3D container_of(cdev, struct nuc_nmi_led, cdev); \ + if (led->indicator !=3D LED_IND_POWER_STATE) \ + return -ENODEV; \ + return offset_show_##_offname(dev, attr, _offset, buf); \ } \ static ssize_t store_##_name(struct device *dev, \ - struct device_attribute *attr, \ - const char *buf, size_t len) \ + struct device_attribute *attr, \ + const char *buf, size_t len) \ { \ - return store_brightness_offset(dev, attr, offset, buf, len); \ + struct led_classdev *cdev =3D dev_get_drvdata(dev); \ + struct nuc_nmi_led *led; \ + \ + led =3D container_of(cdev, struct nuc_nmi_led, cdev); \ + if (led->indicator !=3D LED_IND_POWER_STATE) \ + return -ENODEV; \ + return offset_store_##_offname(dev, attr, _offset, buf, len); \ } \ static DEVICE_ATTR(_name, 0644, show_##_name, store_##_name) =20 @@ -684,7 +696,7 @@ static ssize_t nuc6_store_color(struct device *dev, const char *tmp; int ret, color; =20 - tmp =3D strsep((char **)&buf, ",\n"); + tmp =3D strsep((char **)&buf, "\n"); =20 if (led->id =3D=3D POWER_LED) { for (color =3D ARRAY_SIZE(nuc6_power_colors)+1; color >=3D 0; color--) @@ -1003,7 +1015,7 @@ static umode_t nuc_wmi_led_color_is_visible(struct ko= bject *kobj, } =20 /* Show/store brightness */ -static ssize_t show_brightness_offset(struct device *dev, +static ssize_t offset_show_brightness(struct device *dev, struct device_attribute *attr, u8 offset, char *buf) @@ -1012,9 +1024,6 @@ static ssize_t show_brightness_offset(struct device *= dev, struct nuc_nmi_led *led =3D container_of(cdev, struct nuc_nmi_led, cdev); int ret; =20 - if (led->indicator !=3D LED_IND_POWER_STATE) - return -ENODEV; - offset *=3D led->reg_table[led->indicator][LED_FUNC_POWER_STATE_NUM_CTRLS= ]; =20 ret =3D nuc_wmi_get_brightness_offset(dev, led, offset); @@ -1024,7 +1033,7 @@ static ssize_t show_brightness_offset(struct device *= dev, return scnprintf(buf, PAGE_SIZE, "%d\n", ret); } =20 -static ssize_t store_brightness_offset(struct device *dev, +static ssize_t offset_store_brightness(struct device *dev, struct device_attribute *attr, u8 offset, const char *buf, size_t len) @@ -1034,9 +1043,6 @@ static ssize_t store_brightness_offset(struct device = *dev, int ret; u8 val; =20 - if (led->indicator !=3D LED_IND_POWER_STATE) - return -ENODEV; - if (kstrtou8(buf, 0, &val) || val > 100) return -EINVAL; =20 @@ -1070,6 +1076,8 @@ static int nuc_wmi_set_brightness(struct led_classdev= *cdev, return nuc_wmi_set_brightness_offset(cdev->dev, led, 0, brightness); } =20 +#define cmp_attr_prefix(a, b) strncmp(a, b, strlen(b)) + static umode_t nuc_wmi_led_power_state_is_visible(struct kobject *kobj, struct attribute *attr, int idx) @@ -1077,33 +1085,297 @@ static umode_t nuc_wmi_led_power_state_is_visible(= struct kobject *kobj, struct device *dev =3D kobj_to_dev(kobj); struct led_classdev *cdev =3D dev_get_drvdata(dev); struct nuc_nmi_led *led =3D container_of(cdev, struct nuc_nmi_led, cdev); - umode_t mode =3D attr->mode; =20 - if (!strcmp(attr->name, "s0_brightness") || - !strcmp(attr->name, "s3_brightness")) + if (!cmp_attr_prefix(attr->name, "s0_") || + !cmp_attr_prefix(attr->name, "s3_")) return mode; =20 if (led->api_rev =3D=3D LED_API_REV_0_64) { - if (!strcmp(attr->name, "s5_brightness") || - !strcmp(attr->name, "ready_mode_brightness")) + if (!cmp_attr_prefix(attr->name, "s5_") || + !cmp_attr_prefix(attr->name, "ready_mode_")) return mode; } else { - if (!strcmp(attr->name, "standby_brightness")) + if (!cmp_attr_prefix(attr->name, "standby_")) return mode; } =20 return 0; } =20 +/* Blink */ +static const char * const led_blink_behaviors[] =3D { + "solid", + "breathing", + "pulsing", + "strobing" +}; + +static const char * const led_blink_frequencies[] =3D { + "0.1", + "0.2", + "0.3", + "0.4", + "0.5", + "0.6", + "0.7", + "0.8", + "0.9", + "1.0", +}; + +static ssize_t offset_show_blink_behavior(struct device *dev, + struct device_attribute *attr, + u8 offset, + char *buf) +{ + struct led_classdev *cdev =3D dev_get_drvdata(dev); + struct nuc_nmi_led *led =3D container_of(cdev, struct nuc_nmi_led, cdev); + u8 input[NUM_INPUT_ARGS]; + u8 output[NUM_OUTPUT_ARGS]; + int ret, ctrl, val, i, n; + int size =3D PAGE_SIZE; + char *p =3D buf; + + if (led->indicator =3D=3D LED_IND_DISABLE) + return -ENODEV; + + offset *=3D led->reg_table[led->indicator][LED_FUNC_POWER_STATE_NUM_CTRLS= ]; + ctrl =3D led->reg_table[led->indicator][LED_FUNC_BLINK_BEHAVIOR] + offset; + + if (!nuc_wmi_test_control(dev, led, ctrl)) + return -ENODEV; + + input[0] =3D LED_NEW_GET_CONTROL_ITEM; + input[1] =3D led->id; + input[2] =3D led->indicator; + input[3] =3D ctrl; + + ret =3D nuc_nmi_cmd(dev, LED_NEW_GET_STATUS, input, output); + if (ret) + return ret; + + val =3D output[0]; + + for (i =3D 0; i < ARRAY_SIZE(led_blink_behaviors); i++) { + if (i =3D=3D val) + n =3D scnprintf(p, size, "[%s] ", led_blink_behaviors[i]); + else + n =3D scnprintf(p, size, "%s ", led_blink_behaviors[i]); + p +=3D n; + size -=3D n; + } + size -=3D scnprintf(p, size, "\n"); + + return PAGE_SIZE - size; +} + +static ssize_t offset_store_blink_behavior(struct device *dev, + struct device_attribute *attr, + u8 offset, + const char *buf, size_t len) +{ + struct led_classdev *cdev =3D dev_get_drvdata(dev); + struct nuc_nmi_led *led =3D container_of(cdev, struct nuc_nmi_led, cdev); + u8 input[NUM_INPUT_ARGS] =3D { 0 }; + int ctrl, val, ret; + const char *tmp; + + if (led->indicator =3D=3D LED_IND_DISABLE) + return -ENODEV; + + + if (led->id !=3D LED_IND_SOFTWARE && led->id !=3D LED_IND_POWER_STATE) + return -ENODEV; + + offset *=3D led->reg_table[led->indicator][LED_FUNC_POWER_STATE_NUM_CTRLS= ]; + ctrl =3D led->reg_table[led->indicator][LED_FUNC_BLINK_BEHAVIOR] + offset; + + if (!nuc_wmi_test_control(dev, led, ctrl)) + return -ENODEV; + + tmp =3D strsep((char **)&buf, "\n"); + + for (val =3D 0; val < ARRAY_SIZE(led_blink_behaviors); val++) + if (!strcasecmp(tmp, led_blink_behaviors[val])) + break; + + if (val >=3D ARRAY_SIZE(led_blink_behaviors)) + return -EINVAL; + + input[0] =3D led->id; + input[1] =3D led->indicator; + input[2] =3D ctrl; + input[3] =3D val; + + ret =3D nuc_nmi_cmd(dev, LED_SET_VALUE, input, NULL); + if (ret) + return ret; + + return len; +} + +static ssize_t show_blink_behavior(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + return offset_show_blink_behavior(dev, attr, 0, buf); +} + +static ssize_t store_blink_behavior(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t len) +{ + return offset_store_blink_behavior(dev, attr, 0, buf, len); +} + +static ssize_t offset_show_blink_frequency(struct device *dev, + struct device_attribute *attr, + u8 offset, + char *buf) +{ + struct led_classdev *cdev =3D dev_get_drvdata(dev); + struct nuc_nmi_led *led =3D container_of(cdev, struct nuc_nmi_led, cdev); + u8 input[NUM_INPUT_ARGS]; + u8 output[NUM_OUTPUT_ARGS]; + int ret, ctrl, val, i, n; + int size =3D PAGE_SIZE; + char *p =3D buf; + + if (led->indicator =3D=3D LED_IND_DISABLE) + return -ENODEV; + + offset *=3D led->reg_table[led->indicator][LED_FUNC_POWER_STATE_NUM_CTRLS= ]; + ctrl =3D led->reg_table[led->indicator][LED_FUNC_BLINK_BEHAVIOR] + offset; + + if (!nuc_wmi_test_control(dev, led, ctrl)) + return -ENODEV; + + input[0] =3D LED_NEW_GET_CONTROL_ITEM; + input[1] =3D led->id; + input[2] =3D led->indicator; + input[3] =3D ctrl; + + ret =3D nuc_nmi_cmd(dev, LED_NEW_GET_STATUS, input, output); + if (ret) + return ret; + + val =3D output[0]; + + for (i =3D 0; i < ARRAY_SIZE(led_blink_frequencies); i++) { + if (i =3D=3D val) + n =3D scnprintf(p, size, "[%s] ", led_blink_frequencies[i]); + else + n =3D scnprintf(p, size, "%s ", led_blink_frequencies[i]); + p +=3D n; + size -=3D n; + } + size -=3D scnprintf(p, size, "\n"); + + return PAGE_SIZE - size; +} + +static ssize_t offset_store_blink_frequency(struct device *dev, + struct device_attribute *attr, + u8 offset, + const char *buf, size_t len) +{ + struct led_classdev *cdev =3D dev_get_drvdata(dev); + struct nuc_nmi_led *led =3D container_of(cdev, struct nuc_nmi_led, cdev); + u8 input[NUM_INPUT_ARGS] =3D { 0 }; + int ctrl, val, ret; + const char *tmp; + + if (led->indicator =3D=3D LED_IND_DISABLE) + return -ENODEV; + + + if (led->id !=3D LED_IND_SOFTWARE && led->id !=3D LED_IND_POWER_STATE) + return -ENODEV; + + offset *=3D led->reg_table[led->indicator][LED_FUNC_POWER_STATE_NUM_CTRLS= ]; + ctrl =3D led->reg_table[led->indicator][LED_FUNC_BLINK_BEHAVIOR] + offset; + + if (!nuc_wmi_test_control(dev, led, ctrl)) + return -ENODEV; + + tmp =3D strsep((char **)&buf, "\n"); + + for (val =3D 0; val < ARRAY_SIZE(led_blink_frequencies); val++) + if (!strcasecmp(tmp, led_blink_frequencies[val])) + break; + + if (val >=3D ARRAY_SIZE(led_blink_frequencies)) + return -EINVAL; + + input[0] =3D led->id; + input[1] =3D led->indicator; + input[2] =3D ctrl; + input[3] =3D val + 1; + + ret =3D nuc_nmi_cmd(dev, LED_SET_VALUE, input, NULL); + if (ret) + return ret; + + return len; +} + +static ssize_t show_blink_frequency(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + return offset_show_blink_frequency(dev, attr, 0, buf); +} + +static ssize_t store_blink_frequency(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t len) +{ + return offset_store_blink_frequency(dev, attr, 0, buf, len); +} + +static umode_t nuc_wmi_led_blink_is_visible(struct kobject *kobj, + struct attribute *attr, int idx) +{ + struct device *dev =3D kobj_to_dev(kobj); + struct led_classdev *cdev =3D dev_get_drvdata(dev); + struct nuc_nmi_led *led =3D container_of(cdev, struct nuc_nmi_led, cdev); + umode_t mode =3D attr->mode; + + // TODO: implement for NUC6 API + if (led->api_rev =3D=3D LED_API_NUC6) + return 0; + + if (led->id =3D=3D LED_IND_SOFTWARE) + return mode; + + return 0; +} + static LED_ATTR_RW(indicator); static LED_ATTR_RW(color); +static LED_ATTR_RW(blink_behavior); +static LED_ATTR_RW(blink_frequency); =20 -LED_ATTR_POWER_STATE_RW(s0_brightness, 0); -LED_ATTR_POWER_STATE_RW(s3_brightness, 1); -LED_ATTR_POWER_STATE_RW(s5_brightness, 2); // Rev 0.64 -LED_ATTR_POWER_STATE_RW(standby_brightness, 2); // Rev 1.0 -LED_ATTR_POWER_STATE_RW(ready_mode_brightness, 3); // Rev 1.0 +LED_ATTR_POWER_STATE_RW(s0_brightness, brightness, 0); +LED_ATTR_POWER_STATE_RW(s0_blink_behavior, blink_behavior, 0); +LED_ATTR_POWER_STATE_RW(s0_blink_frequency, blink_frequency, 0); +LED_ATTR_POWER_STATE_RW(s3_brightness, brightness, 1); +LED_ATTR_POWER_STATE_RW(s3_blink_behavior, blink_behavior, 1); +LED_ATTR_POWER_STATE_RW(s3_blink_frequency, blink_frequency, 1); + +/* Rev 0.64 */ +LED_ATTR_POWER_STATE_RW(s5_brightness, brightness, 2); +LED_ATTR_POWER_STATE_RW(s5_blink_behavior, blink_behavior, 2); +LED_ATTR_POWER_STATE_RW(s5_blink_frequency, blink_frequency, 2); +LED_ATTR_POWER_STATE_RW(ready_mode_brightness, brightness, 3); +LED_ATTR_POWER_STATE_RW(ready_mode_blink_behavior, blink_behavior, 3); +LED_ATTR_POWER_STATE_RW(ready_mode_blink_frequency, blink_frequency, 3); + +/* Rev 1.0 */ +LED_ATTR_POWER_STATE_RW(standby_brightness, brightness, 2); +LED_ATTR_POWER_STATE_RW(standby_blink_behavior, blink_behavior, 2); +LED_ATTR_POWER_STATE_RW(standby_blink_frequency, blink_frequency, 2); =20 /* * Attributes for LEDs @@ -1124,6 +1396,19 @@ static struct attribute *nuc_wmi_led_power_state_att= r[] =3D { &dev_attr_standby_brightness.attr, &dev_attr_s5_brightness.attr, &dev_attr_ready_mode_brightness.attr, + + &dev_attr_s0_blink_behavior.attr, + &dev_attr_s3_blink_behavior.attr, + &dev_attr_standby_blink_behavior.attr, + &dev_attr_s5_blink_behavior.attr, + &dev_attr_ready_mode_blink_behavior.attr, + + &dev_attr_s0_blink_frequency.attr, + &dev_attr_s3_blink_frequency.attr, + &dev_attr_standby_blink_frequency.attr, + &dev_attr_s5_blink_frequency.attr, + &dev_attr_ready_mode_blink_frequency.attr, + NULL, }; =20 @@ -1142,10 +1427,22 @@ static const struct attribute_group nuc_wmi_led_col= or_attribute_group =3D { .attrs =3D nuc_wmi_led_color_attr, }; =20 +static struct attribute *nuc_wmi_led_blink_behavior_attr[] =3D { + &dev_attr_blink_behavior.attr, + &dev_attr_blink_frequency.attr, + NULL, +}; + +static const struct attribute_group nuc_wmi_led_blink_attribute_group =3D { + .is_visible =3D nuc_wmi_led_blink_is_visible, + .attrs =3D nuc_wmi_led_blink_behavior_attr, +}; + static const struct attribute_group *nuc_wmi_led_attribute_groups[] =3D { &nuc_wmi_led_attribute_group, &nuc_wmi_led_power_state_group, &nuc_wmi_led_color_attribute_group, + &nuc_wmi_led_blink_attribute_group, NULL }; =20 --=20 2.31.1