[edk2] [platforms: PATCH 00/10] Armada 70x0/80x0 SPI improvements

Marcin Wojtas posted 10 patches 7 years, 3 months ago
Failed in applying to current master (apply log)
Platform/Marvell/Applications/FirmwareUpdate/FUpdate.c       |   6 +-
Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c          |  13 +-
Platform/Marvell/Applications/SpiTool/SpiFlashCmd.inf        |   2 +
Platform/Marvell/Armada/Armada70x0.dsc                       |   2 +
Platform/Marvell/Documentation/Drivers/EepromDriver.txt      |  96 -----
Platform/Marvell/Documentation/Drivers/I2cDriver.txt         |  64 ----
Platform/Marvell/Documentation/Drivers/SpiDriver.txt         | 116 ------
Platform/Marvell/Documentation/PortingGuide/ComPhy.txt       |  45 ---
Platform/Marvell/Documentation/PortingGuide/I2c.txt          |  20 --
Platform/Marvell/Documentation/PortingGuide/Mdio.txt         |   7 -
Platform/Marvell/Documentation/PortingGuide/Mpp.txt          |  48 ---
Platform/Marvell/Documentation/PortingGuide/PciEmulation.txt |  31 --
Platform/Marvell/Documentation/PortingGuide/Phy.txt          |  45 ---
Platform/Marvell/Documentation/PortingGuide/Pp2.txt          |  35 --
Platform/Marvell/Documentation/PortingGuide/Reset.txt        |   7 -
Platform/Marvell/Documentation/PortingGuide/Spi.txt          |  16 -
Platform/Marvell/Documentation/PortingGuide/SpiFlash.txt     |  23 --
Platform/Marvell/Documentation/PortingGuide/Utmi.txt         |  35 --
Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.c            |  36 +-
Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.h            |   6 +
Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.inf          |   1 +
Platform/Marvell/Drivers/Spi/MvSpiDxe.c                      |   6 +-
Platform/Marvell/Marvell.dec                                 |   3 +
Silicon/Marvell/Documentation/Drivers/EepromDriver.txt       |  96 +++++
Silicon/Marvell/Documentation/Drivers/I2cDriver.txt          |  64 ++++
Silicon/Marvell/Documentation/Drivers/SpiDriver.txt          | 116 ++++++
Silicon/Marvell/Documentation/PortingGuide.txt               | 377 ++++++++++++++++++++
27 files changed, 707 insertions(+), 609 deletions(-)
delete mode 100644 Platform/Marvell/Documentation/Drivers/EepromDriver.txt
delete mode 100644 Platform/Marvell/Documentation/Drivers/I2cDriver.txt
delete mode 100644 Platform/Marvell/Documentation/Drivers/SpiDriver.txt
delete mode 100644 Platform/Marvell/Documentation/PortingGuide/ComPhy.txt
delete mode 100644 Platform/Marvell/Documentation/PortingGuide/I2c.txt
delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Mdio.txt
delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Mpp.txt
delete mode 100644 Platform/Marvell/Documentation/PortingGuide/PciEmulation.txt
delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Phy.txt
delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Pp2.txt
delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Reset.txt
delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Spi.txt
delete mode 100644 Platform/Marvell/Documentation/PortingGuide/SpiFlash.txt
delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Utmi.txt
create mode 100644 Silicon/Marvell/Documentation/Drivers/EepromDriver.txt
create mode 100644 Silicon/Marvell/Documentation/Drivers/I2cDriver.txt
create mode 100644 Silicon/Marvell/Documentation/Drivers/SpiDriver.txt
create mode 100644 Silicon/Marvell/Documentation/PortingGuide.txt
[edk2] [platforms: PATCH 00/10] Armada 70x0/80x0 SPI improvements
Posted by Marcin Wojtas 7 years, 3 months ago
Hi,

Finally I found time to respin SPI patchset. As agreed, I extracted
style fixes from dynamic flash detection patch, but its main part
is kept aside for now until FlashId table (and additionally both SPI
protocols land in the edk2 mainline). A lot of minor fixes were
implemented, details can be found in the commit logs and changelog
below.

Patches are available in the github:
https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/spi-upstream-r20170925

I'm looking forward to the comments or remarks.

Best regards,
Marcin

Changelog
v1 -> v2
Slightly improve commit log prefixes.

1/10
* Move documentation to Silicon/Marvell
* Update PortingGuide with new paths in edk2-platforms repository

2/10
* Correct error print

4/10
* Sort PCDs

7/10
* Simplify change and remove additional local variable

8/10
* Correct FileSize type and let it really compile for ARM and AARCH64

9/10
* modify macros -> s/SPI_ERASE_SIZE_/SIZE_/

10/10
* New patch

3/10, 5/10, 6/10
* Add Reviewed-by's

Ard Biesheuvel (3):
  Marvell/Applications/SpiTool: Fix bug in error test
  Marvell/Applications/FirmwareUpdate: Fix 32-bit issues
  Marvell/Applications/SpiTool: Fix 32-bit issues

Joe Zhou (1):
  Marvell/Drivers: MvSpiDxe: Fix write bug

Marcin Wojtas (4):
  Marvell/Applications/SpiTool: Enable configurable CS and SCLK mode
  Platform/Marvell/Armada70x0: set CS and SCLK Mode for SPI flash
  Marvell/Drivers: MvSpiFlash: Fix usage of erase size parameter
  Marvell/Drivers: MvSpiFlash: Minor style fix

Nir Erez (1):
  Silicon/Marvell: Refactor Documentation

Piotr Król (1):
  Marvell/Drivers: MvSpiDxe: Log and return correct error

 Platform/Marvell/Applications/FirmwareUpdate/FUpdate.c       |   6 +-
 Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c          |  13 +-
 Platform/Marvell/Applications/SpiTool/SpiFlashCmd.inf        |   2 +
 Platform/Marvell/Armada/Armada70x0.dsc                       |   2 +
 Platform/Marvell/Documentation/Drivers/EepromDriver.txt      |  96 -----
 Platform/Marvell/Documentation/Drivers/I2cDriver.txt         |  64 ----
 Platform/Marvell/Documentation/Drivers/SpiDriver.txt         | 116 ------
 Platform/Marvell/Documentation/PortingGuide/ComPhy.txt       |  45 ---
 Platform/Marvell/Documentation/PortingGuide/I2c.txt          |  20 --
 Platform/Marvell/Documentation/PortingGuide/Mdio.txt         |   7 -
 Platform/Marvell/Documentation/PortingGuide/Mpp.txt          |  48 ---
 Platform/Marvell/Documentation/PortingGuide/PciEmulation.txt |  31 --
 Platform/Marvell/Documentation/PortingGuide/Phy.txt          |  45 ---
 Platform/Marvell/Documentation/PortingGuide/Pp2.txt          |  35 --
 Platform/Marvell/Documentation/PortingGuide/Reset.txt        |   7 -
 Platform/Marvell/Documentation/PortingGuide/Spi.txt          |  16 -
 Platform/Marvell/Documentation/PortingGuide/SpiFlash.txt     |  23 --
 Platform/Marvell/Documentation/PortingGuide/Utmi.txt         |  35 --
 Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.c            |  36 +-
 Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.h            |   6 +
 Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.inf          |   1 +
 Platform/Marvell/Drivers/Spi/MvSpiDxe.c                      |   6 +-
 Platform/Marvell/Marvell.dec                                 |   3 +
 Silicon/Marvell/Documentation/Drivers/EepromDriver.txt       |  96 +++++
 Silicon/Marvell/Documentation/Drivers/I2cDriver.txt          |  64 ++++
 Silicon/Marvell/Documentation/Drivers/SpiDriver.txt          | 116 ++++++
 Silicon/Marvell/Documentation/PortingGuide.txt               | 377 ++++++++++++++++++++
 27 files changed, 707 insertions(+), 609 deletions(-)
 delete mode 100644 Platform/Marvell/Documentation/Drivers/EepromDriver.txt
 delete mode 100644 Platform/Marvell/Documentation/Drivers/I2cDriver.txt
 delete mode 100644 Platform/Marvell/Documentation/Drivers/SpiDriver.txt
 delete mode 100644 Platform/Marvell/Documentation/PortingGuide/ComPhy.txt
 delete mode 100644 Platform/Marvell/Documentation/PortingGuide/I2c.txt
 delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Mdio.txt
 delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Mpp.txt
 delete mode 100644 Platform/Marvell/Documentation/PortingGuide/PciEmulation.txt
 delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Phy.txt
 delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Pp2.txt
 delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Reset.txt
 delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Spi.txt
 delete mode 100644 Platform/Marvell/Documentation/PortingGuide/SpiFlash.txt
 delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Utmi.txt
 create mode 100644 Silicon/Marvell/Documentation/Drivers/EepromDriver.txt
 create mode 100644 Silicon/Marvell/Documentation/Drivers/I2cDriver.txt
 create mode 100644 Silicon/Marvell/Documentation/Drivers/SpiDriver.txt
 create mode 100644 Silicon/Marvell/Documentation/PortingGuide.txt

-- 
1.8.3.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [platforms: PATCH 00/10] Armada 70x0/80x0 SPI improvements
Posted by Leif Lindholm 7 years, 2 months ago
On Mon, Sep 25, 2017 at 03:51:49AM +0200, Marcin Wojtas wrote:
> Hi,
> 
> Finally I found time to respin SPI patchset. As agreed, I extracted
> style fixes from dynamic flash detection patch, but its main part
> is kept aside for now until FlashId table (and additionally both SPI
> protocols land in the edk2 mainline). A lot of minor fixes were
> implemented, details can be found in the commit logs and changelog
> below.
> 
> Patches are available in the github:
> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/spi-upstream-r20170925
> 
> I'm looking forward to the comments or remarks.

If the two minor changes I have suggested are acceptable - for the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

As mentioned, I can fold these in before pushing. Let me know.

/
    Leif

> Best regards,
> Marcin
> 
> Changelog
> v1 -> v2
> Slightly improve commit log prefixes.
> 
> 1/10
> * Move documentation to Silicon/Marvell
> * Update PortingGuide with new paths in edk2-platforms repository
> 
> 2/10
> * Correct error print
> 
> 4/10
> * Sort PCDs
> 
> 7/10
> * Simplify change and remove additional local variable
> 
> 8/10
> * Correct FileSize type and let it really compile for ARM and AARCH64
> 
> 9/10
> * modify macros -> s/SPI_ERASE_SIZE_/SIZE_/
> 
> 10/10
> * New patch
> 
> 3/10, 5/10, 6/10
> * Add Reviewed-by's
> 
> Ard Biesheuvel (3):
>   Marvell/Applications/SpiTool: Fix bug in error test
>   Marvell/Applications/FirmwareUpdate: Fix 32-bit issues
>   Marvell/Applications/SpiTool: Fix 32-bit issues
> 
> Joe Zhou (1):
>   Marvell/Drivers: MvSpiDxe: Fix write bug
> 
> Marcin Wojtas (4):
>   Marvell/Applications/SpiTool: Enable configurable CS and SCLK mode
>   Platform/Marvell/Armada70x0: set CS and SCLK Mode for SPI flash
>   Marvell/Drivers: MvSpiFlash: Fix usage of erase size parameter
>   Marvell/Drivers: MvSpiFlash: Minor style fix
> 
> Nir Erez (1):
>   Silicon/Marvell: Refactor Documentation
> 
> Piotr Król (1):
>   Marvell/Drivers: MvSpiDxe: Log and return correct error
> 
>  Platform/Marvell/Applications/FirmwareUpdate/FUpdate.c       |   6 +-
>  Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c          |  13 +-
>  Platform/Marvell/Applications/SpiTool/SpiFlashCmd.inf        |   2 +
>  Platform/Marvell/Armada/Armada70x0.dsc                       |   2 +
>  Platform/Marvell/Documentation/Drivers/EepromDriver.txt      |  96 -----
>  Platform/Marvell/Documentation/Drivers/I2cDriver.txt         |  64 ----
>  Platform/Marvell/Documentation/Drivers/SpiDriver.txt         | 116 ------
>  Platform/Marvell/Documentation/PortingGuide/ComPhy.txt       |  45 ---
>  Platform/Marvell/Documentation/PortingGuide/I2c.txt          |  20 --
>  Platform/Marvell/Documentation/PortingGuide/Mdio.txt         |   7 -
>  Platform/Marvell/Documentation/PortingGuide/Mpp.txt          |  48 ---
>  Platform/Marvell/Documentation/PortingGuide/PciEmulation.txt |  31 --
>  Platform/Marvell/Documentation/PortingGuide/Phy.txt          |  45 ---
>  Platform/Marvell/Documentation/PortingGuide/Pp2.txt          |  35 --
>  Platform/Marvell/Documentation/PortingGuide/Reset.txt        |   7 -
>  Platform/Marvell/Documentation/PortingGuide/Spi.txt          |  16 -
>  Platform/Marvell/Documentation/PortingGuide/SpiFlash.txt     |  23 --
>  Platform/Marvell/Documentation/PortingGuide/Utmi.txt         |  35 --
>  Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.c            |  36 +-
>  Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.h            |   6 +
>  Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.inf          |   1 +
>  Platform/Marvell/Drivers/Spi/MvSpiDxe.c                      |   6 +-
>  Platform/Marvell/Marvell.dec                                 |   3 +
>  Silicon/Marvell/Documentation/Drivers/EepromDriver.txt       |  96 +++++
>  Silicon/Marvell/Documentation/Drivers/I2cDriver.txt          |  64 ++++
>  Silicon/Marvell/Documentation/Drivers/SpiDriver.txt          | 116 ++++++
>  Silicon/Marvell/Documentation/PortingGuide.txt               | 377 ++++++++++++++++++++
>  27 files changed, 707 insertions(+), 609 deletions(-)
>  delete mode 100644 Platform/Marvell/Documentation/Drivers/EepromDriver.txt
>  delete mode 100644 Platform/Marvell/Documentation/Drivers/I2cDriver.txt
>  delete mode 100644 Platform/Marvell/Documentation/Drivers/SpiDriver.txt
>  delete mode 100644 Platform/Marvell/Documentation/PortingGuide/ComPhy.txt
>  delete mode 100644 Platform/Marvell/Documentation/PortingGuide/I2c.txt
>  delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Mdio.txt
>  delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Mpp.txt
>  delete mode 100644 Platform/Marvell/Documentation/PortingGuide/PciEmulation.txt
>  delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Phy.txt
>  delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Pp2.txt
>  delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Reset.txt
>  delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Spi.txt
>  delete mode 100644 Platform/Marvell/Documentation/PortingGuide/SpiFlash.txt
>  delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Utmi.txt
>  create mode 100644 Silicon/Marvell/Documentation/Drivers/EepromDriver.txt
>  create mode 100644 Silicon/Marvell/Documentation/Drivers/I2cDriver.txt
>  create mode 100644 Silicon/Marvell/Documentation/Drivers/SpiDriver.txt
>  create mode 100644 Silicon/Marvell/Documentation/PortingGuide.txt
> 
> -- 
> 1.8.3.1
> 
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [platforms: PATCH 00/10] Armada 70x0/80x0 SPI improvements
Posted by Marcin Wojtas 7 years, 2 months ago
Hi Leif,

2017-10-05 15:30 GMT+02:00 Leif Lindholm <leif.lindholm@linaro.org>:
>
> On Mon, Sep 25, 2017 at 03:51:49AM +0200, Marcin Wojtas wrote:
> > Hi,
> >
> > Finally I found time to respin SPI patchset. As agreed, I extracted
> > style fixes from dynamic flash detection patch, but its main part
> > is kept aside for now until FlashId table (and additionally both SPI
> > protocols land in the edk2 mainline). A lot of minor fixes were
> > implemented, details can be found in the commit logs and changelog
> > below.
> >
> > Patches are available in the github:
> > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/spi-upstream-r20170925
> >
> > I'm looking forward to the comments or remarks.
>
> If the two minor changes I have suggested are acceptable - for the series:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
> As mentioned, I can fold these in before pushing. Let me know.
>

If that's not a big problem, please do.

Thanks,
Marcin
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [platforms: PATCH 00/10] Armada 70x0/80x0 SPI improvements
Posted by Marcin Wojtas 7 years, 2 months ago
Leif,

2017-10-05 15:37 GMT+02:00 Marcin Wojtas <mw@semihalf.com>:
> Hi Leif,
>
> 2017-10-05 15:30 GMT+02:00 Leif Lindholm <leif.lindholm@linaro.org>:
>>
>> On Mon, Sep 25, 2017 at 03:51:49AM +0200, Marcin Wojtas wrote:
>> > Hi,
>> >
>> > Finally I found time to respin SPI patchset. As agreed, I extracted
>> > style fixes from dynamic flash detection patch, but its main part
>> > is kept aside for now until FlashId table (and additionally both SPI
>> > protocols land in the edk2 mainline). A lot of minor fixes were
>> > implemented, details can be found in the commit logs and changelog
>> > below.
>> >
>> > Patches are available in the github:
>> > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/spi-upstream-r20170925
>> >
>> > I'm looking forward to the comments or remarks.
>>
>> If the two minor changes I have suggested are acceptable - for the series:
>> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>>
>> As mentioned, I can fold these in before pushing. Let me know.
>>

Here:
https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/spi-upstream-r20171005

you can find rebased commits, with 2 modifications you pointed (%a and
use BaseLib size types). Added RB's everywhere and tested - working
fine.

Best regards,
Marcin
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [platforms: PATCH 00/10] Armada 70x0/80x0 SPI improvements
Posted by Leif Lindholm 7 years, 2 months ago
On Thu, Oct 05, 2017 at 04:54:26PM +0200, Marcin Wojtas wrote:
> Leif,
> 
> 2017-10-05 15:37 GMT+02:00 Marcin Wojtas <mw@semihalf.com>:
> > Hi Leif,
> >
> > 2017-10-05 15:30 GMT+02:00 Leif Lindholm <leif.lindholm@linaro.org>:
> >>
> >> On Mon, Sep 25, 2017 at 03:51:49AM +0200, Marcin Wojtas wrote:
> >> > Hi,
> >> >
> >> > Finally I found time to respin SPI patchset. As agreed, I extracted
> >> > style fixes from dynamic flash detection patch, but its main part
> >> > is kept aside for now until FlashId table (and additionally both SPI
> >> > protocols land in the edk2 mainline). A lot of minor fixes were
> >> > implemented, details can be found in the commit logs and changelog
> >> > below.
> >> >
> >> > Patches are available in the github:
> >> > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/spi-upstream-r20170925
> >> >
> >> > I'm looking forward to the comments or remarks.
> >>
> >> If the two minor changes I have suggested are acceptable - for the series:
> >> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> >>
> >> As mentioned, I can fold these in before pushing. Let me know.
> >>
> 
> Here:
> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/spi-upstream-r20171005
> 
> you can find rebased commits, with 2 modifications you pointed (%a and
> use BaseLib size types). Added RB's everywhere and tested - working
> fine.

Many thanks - pushed as a4591fe0b0..13f15e8113.

/
    Leif
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel