Commit 77298458d027db4d3e082213355e2d792f65158d changed the esx storage
adapter from busLogic to lsilogic, introducing a typo. Changing it back
to lsiLogic (with capital L) solves the issue. With this change, libvirt can now
create volumes in ESX again.

Thanks to Jaroslav Suchanek who figured out what was the issue in the
first place.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1571759
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
---
 src/esx/esx_storage_backend_vmfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/esx/esx_storage_backend_vmfs.c b/src/esx/esx_storage_backend_vmfs.c
index 630a6aa8c9..bb2de4b69f 100644
--- a/src/esx/esx_storage_backend_vmfs.c
+++ b/src/esx/esx_storage_backend_vmfs.c
@@ -967,9 +967,9 @@ esxStorageVolCreateXML(virStoragePoolPtr pool,
         /*
          * FIXME: The adapter type is a required parameter, but there is no
          * way to let the user specify it in the volume XML config. Therefore,
-         * default to 'lsilogic' here.
+         * default to 'lsiLogic' here.
          */
-        virtualDiskSpec->adapterType = (char *)"lsilogic";
+        virtualDiskSpec->adapterType = (char *)"lsiLogic";
 
         virtualDiskSpec->capacityKb->value =
           VIR_DIV_UP(def->target.capacity, 1024); /* Scale from byte to kilobyte */
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On 07/24/2018 02:15 AM, Marcos Paulo de Souza wrote:
> Commit 77298458d027db4d3e082213355e2d792f65158d changed the esx storage
> adapter from busLogic to lsilogic, introducing a typo. Changing it back
> to lsiLogic (with capital L) solves the issue. With this change, libvirt can now
> create volumes in ESX again.
> 
> Thanks to Jaroslav Suchanek who figured out what was the issue in the
> first place.
> 
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1571759
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> ---
>  src/esx/esx_storage_backend_vmfs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/esx/esx_storage_backend_vmfs.c b/src/esx/esx_storage_backend_vmfs.c
> index 630a6aa8c9..bb2de4b69f 100644
> --- a/src/esx/esx_storage_backend_vmfs.c
> +++ b/src/esx/esx_storage_backend_vmfs.c
> @@ -967,9 +967,9 @@ esxStorageVolCreateXML(virStoragePoolPtr pool,
>          /*
>           * FIXME: The adapter type is a required parameter, but there is no
>           * way to let the user specify it in the volume XML config. Therefore,
> -         * default to 'lsilogic' here.
> +         * default to 'lsiLogic' here.
>           */
> -        virtualDiskSpec->adapterType = (char *)"lsilogic";
> +        virtualDiskSpec->adapterType = (char *)"lsiLogic";
>  
>          virtualDiskSpec->capacityKb->value =
>            VIR_DIV_UP(def->target.capacity, 1024); /* Scale from byte to kilobyte */
> 

Ooops. Yes. ACKed and pushed.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list