[libvirt] [PATCH 1/6] spec: Enable fuse only if LXC is enabled

Jiri Denemark posted 6 patches 7 years, 2 months ago
[libvirt] [PATCH 1/6] spec: Enable fuse only if LXC is enabled
Posted by Jiri Denemark 7 years, 2 months ago
Enabling fuse without LXC does not make a lot of sense because fuse is
used only by LXC.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---
 libvirt.spec.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 44f846a169..4821da826e 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -163,7 +163,7 @@
 %endif
 
 # fuse is used to provide virtualized /proc for LXC
-%if 0%{?fedora} || 0%{?rhel} >= 7
+%if %{with_lxc}
     %define with_fuse      0%{!?_without_fuse:1}
 %endif
 
-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 1/6] spec: Enable fuse only if LXC is enabled
Posted by Daniel P. Berrangé 7 years, 2 months ago
On Wed, Feb 14, 2018 at 03:11:36PM +0100, Jiri Denemark wrote:
> Enabling fuse without LXC does not make a lot of sense because fuse is
> used only by LXC.
> 
> Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
> ---
>  libvirt.spec.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 44f846a169..4821da826e 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -163,7 +163,7 @@
>  %endif
>  
>  # fuse is used to provide virtualized /proc for LXC
> -%if 0%{?fedora} || 0%{?rhel} >= 7
> +%if %{with_lxc}
>      %define with_fuse      0%{!?_without_fuse:1}
>  %endif

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list