rewrite to use libdbus and some other fixes

[libvirt] [dbus PATCH 14/18] connect: parse message arguments as first thing

Posted by Pavel Hrdina 7 years, 2 months ago

There is no need to open connection if parsing arguments fails.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
---
 src/connect.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/connect.c b/src/connect.c
index b31f08e..695fc0d 100644
--- a/src/connect.c
+++ b/src/connect.c
@@ -120,11 +120,11 @@ virtDBusConnectListDomains(sd_bus_message *message,
     uint32_t flags;
     int r;
 
-    r = virtDBusConnectOpen(connect, error);
+    r = sd_bus_message_read(message, "u", &flags);
     if (r < 0)
         return r;
 
-    r = sd_bus_message_read(message, "u", &flags);
+    r = virtDBusConnectOpen(connect, error);
     if (r < 0)
         return r;
 
@@ -170,11 +170,11 @@ virtDBusConnectCreateXML(sd_bus_message *message,
     _cleanup_(virtDBusUtilFreep) char *path = NULL;
     int r;
 
-    r = virtDBusConnectOpen(connect, error);
+    r = sd_bus_message_read(message, "su", &xml, &flags);
     if (r < 0)
         return r;
 
-    r = sd_bus_message_read(message, "su", &xml, &flags);
+    r = virtDBusConnectOpen(connect, error);
     if (r < 0)
         return r;
 
@@ -198,11 +198,11 @@ virtDBusConnectDefineXML(sd_bus_message *message,
     _cleanup_(virtDBusUtilFreep) char *path = NULL;
     int r;
 
-    r = virtDBusConnectOpen(connect, error);
+    r = sd_bus_message_read(message, "s", &xml);
     if (r < 0)
         return r;
 
-    r = sd_bus_message_read(message, "s", &xml);
+    r = virtDBusConnectOpen(connect, error);
     if (r < 0)
         return r;
 
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [dbus PATCH 14/18] connect: parse message arguments as first thing

Posted by Daniel P. Berrangé 7 years, 2 months ago

On Mon, Mar 12, 2018 at 05:21:44PM +0100, Pavel Hrdina wrote:
> There is no need to open connection if parsing arguments fails.
> 
> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> ---
>  src/connect.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list