[PATCH 0/2] hw: aspeed: Init all UART's with serial devices

Peter Delevoryas posted 2 patches 1 year, 11 months ago
There is a newer version of this series
hw/arm/aspeed_ast10x0.c     | 38 ++++++++++++++++++++++++++++++++++---
hw/arm/aspeed_ast2600.c     | 29 +++++++++++++++++++++++++++-
hw/arm/aspeed_soc.c         | 16 +++++++++++++++-
include/hw/arm/aspeed_soc.h |  8 ++++++++
4 files changed, 86 insertions(+), 5 deletions(-)
[PATCH 0/2] hw: aspeed: Init all UART's with serial devices
Posted by Peter Delevoryas 1 year, 11 months ago
CC'ing Zev and OpenBMC since this was motivated by a problem Zev had there:

https://lore.kernel.org/openbmc/YnzGnWjkYdMUUNyM@hatter.bewilderbeest.net/

This series adds all the missing UART's in the Aspeed chips, and initializes
them all with serial devices (even if there is no peer character device provided
by the QEMU user).

This allows users to quickly test UART output without any code changes. In fact,
you could even connect all the UART's to separate sockets and check which one is
emitting data.

The first commit is just focusing on adding the missing hardware #define's.

The second commit has more info on the state of the whole Aspeed BMC UART cli
interface, and adds the additional initialization code.

By the way, could I put this code into aspeed_soc.h or something? If not,
maybe after this I'll add a file for common code, so that we can move
towards unifying everything.

Peter Delevoryas (2):
  hw: aspeed: Add missing UART's
  hw: aspeed: Init all UART's with serial devices

 hw/arm/aspeed_ast10x0.c     | 38 ++++++++++++++++++++++++++++++++++---
 hw/arm/aspeed_ast2600.c     | 29 +++++++++++++++++++++++++++-
 hw/arm/aspeed_soc.c         | 16 +++++++++++++++-
 include/hw/arm/aspeed_soc.h |  8 ++++++++
 4 files changed, 86 insertions(+), 5 deletions(-)

-- 
2.30.2
Re: [PATCH 0/2] hw: aspeed: Init all UART's with serial devices
Posted by Zev Weiss 1 year, 11 months ago
On Thu, May 12, 2022 at 09:02:18PM PDT, Peter Delevoryas wrote:
> CC'ing Zev and OpenBMC since this was motivated by a problem Zev had there:
> 
> https://lore.kernel.org/openbmc/YnzGnWjkYdMUUNyM@hatter.bewilderbeest.net/
> 
> This series adds all the missing UART's in the Aspeed chips, and initializes
> them all with serial devices (even if there is no peer character device provided
> by the QEMU user).
> 
> This allows users to quickly test UART output without any code changes. In fact,
> you could even connect all the UART's to separate sockets and check which one is
> emitting data.
> 

Thanks Peter -- I tried this out with an ahe-50dc u-boot build (ast2400 
with stdio on uart3), and with

  -serial null -serial null -serial null -serial mon:stdio

added to the command-line I get the u-boot stdio and the qemu monitor in 
my terminal as expected.

Tested-by: Zev Weiss <zev@bewilderbeest.net>